Attachment 362238 Details for Bug 191303 – Patch

[patch] Patch

bug-191303-20190217191124.patch (text/plain), 6.48 KB, created by darshan on 2019-02-17 10:11:25 PST

(hide)

Description:

Filename:

MIME Type:

Creator: darshan

Created: 2019-02-17 10:11:25 PST

Size: 6.48 KB

patch

obsolete

>Subversion Revision: 241648
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 5470296a61a22a0a8ee358dcee000aa598fc7411..f265c1cf8bc683bbcc48536984a04794f5a3f455 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-17  Darshan Kadu  <dkadu@igalia.com>
>+
>+        DumpRenderTree should report unknown options
>+        https://bugs.webkit.org/show_bug.cgi?id=191303
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
>+        to report unknown options.
>+        Added and assigned test options which are currently used in tests.
>+
>+        * DumpRenderTree/TestOptions.cpp:
>+        (TestOptions::TestOptions):
>+        * DumpRenderTree/TestOptions.h:
>+
> 2019-02-16  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] RenderImage's default intrinsic size is 0.
>diff --git a/Tools/DumpRenderTree/TestOptions.cpp b/Tools/DumpRenderTree/TestOptions.cpp
>index c926612b1b1604a83ce2603bcda88ce3983d358e..90054c7776e2d7fc030372b8080b0c32f83d20bb 100644
>--- a/Tools/DumpRenderTree/TestOptions.cpp
>+++ b/Tools/DumpRenderTree/TestOptions.cpp
>@@ -75,7 +75,7 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>         auto value = pairString.substr(equalsLocation + 1, pairEnd - (equalsLocation + 1));
>         if (key == "enableAttachmentElement")
>             enableAttachmentElement = parseBooleanTestHeaderValue(value);
>-        if (key == "useAcceleratedDrawing")
>+        else if (key == "useAcceleratedDrawing")
>             useAcceleratedDrawing = parseBooleanTestHeaderValue(value);
>         else if (key == "enableIntersectionObserver")
>             enableIntersectionObserver = parseBooleanTestHeaderValue(value);
>@@ -111,6 +111,54 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>             enableCSSLogical = parseBooleanTestHeaderValue(value);
>         else if (key == "internal:AdClickAttributionEnabled")
>             adClickAttributionEnabled = parseBooleanTestHeaderValue(value);
>+        else if (key == "applicationManifest")
>+            applicationManifest = value;
>+        else if (key == "experimental:CSSCustomPropertiesAndValuesEnabled")
>+            enableCSSCustomPropertiesAndValues = parseBooleanTestHeaderValue(value);
>+        else if (key == "useFlexibleViewport")
>+            useFlexibleViewport = parseBooleanTestHeaderValue(value);
>+        else if (key == "useThreadedScrolling")
>+            useThreadedScrolling  = parseBooleanTestHeaderValue(value);
>+        else if (key == "experimental:DarkModeCSSEnabled")
>+            enableDarkModeCSS = parseBooleanTestHeaderValue(value);
>+        else if (key == "experimental:CSSTypedOMEnabled")
>+            enableCSSTypedOM = parseBooleanTestHeaderValue(value);
>+        else if (key == "punchOutWhiteBackgrounds")
>+            punchOutWhiteBackgrounds = parseBooleanTestHeaderValue(value);
>+        else if (key == "enableEditableImages")
>+            enableEditableImages = parseBooleanTestHeaderValue(value);
>+        else if (key == "useCharacterSelectionGranularity")
>+            useCharacterSelectionGranularity = parseBooleanTestHeaderValue(value);
>+        else if (key == "spellCheckingDots")
>+            spellCheckingDots = parseBooleanTestHeaderValue(value);
>+        else if (key == "experimental:CSSPaintingAPIEnabled")
>+            enableCSSPaintingAPI = parseBooleanTestHeaderValue(value);
>+        else if (key == "experimental:PointerEventsEnabled")
>+            enablePointerEvents = parseBooleanTestHeaderValue(value);
>+        else if (key =="useMockScrollbars")
>+            useMockScrollbars = parseBooleanTestHeaderValue(value);
>+        else if (key =="ignoresViewportScaleLimits")
>+            ignoresViewportScaleLimits = parseBooleanTestHeaderValue(value);
>+        else if (key =="shouldIgnoreMetaViewport")
>+            shouldIgnoreMetaViewport = parseBooleanTestHeaderValue(value);
>+        else if (key =="enableProcessSwapOnNavigation")
>+            enableProcessSwapOnNavigation = parseBooleanTestHeaderValue(value);
>+        else if (key =="runSingly")
>+            runSingly = parseBooleanTestHeaderValue(value);
>+        else if (key =="internal:WebAPIStatisticsEnabled")
>+            enableWebAPIStatistics = parseBooleanTestHeaderValue(value);
>+        else if (key =="internal:SourceBufferChangeTypeEnabled")
>+            enableSourceBufferChangeType = parseBooleanTestHeaderValue(value);
>+        else if (key =="needsSiteSpecificQuirks")
>+            needsSiteSpecificQuirks = parseBooleanTestHeaderValue(value);
>+        else if (key =="modernMediaControls")
>+            modernMediaControls = parseBooleanTestHeaderValue(value);
>+        else if (key == "experimental:WebGL2Enabled")
>+            enableWebGL2 = parseBooleanTestHeaderValue(value);
>+        else if (key == "language")
>+            language = value;
>+        else
>+            RELEASE_ASSERT_NOT_REACHED();
>         pairStart = pairEnd + 1;
>     }
> }
>diff --git a/Tools/DumpRenderTree/TestOptions.h b/Tools/DumpRenderTree/TestOptions.h
>index c27e842a48f57ac80f5f04bbb5e6a92ad105d81d..f14a7fad4c53d5f69b2520043b8f65d5e6bbf379 100644
>--- a/Tools/DumpRenderTree/TestOptions.h
>+++ b/Tools/DumpRenderTree/TestOptions.h
>@@ -47,6 +47,31 @@ struct TestOptions {
>     bool enableCSSLogical { false };
>     bool adClickAttributionEnabled { false };
>     std::string jscOptions;
>+    // FIXME: Implement the following test options,
>+    // https://bugs.webkit.org/show_bug.cgi?id=194396
>+    bool enableCSSCustomPropertiesAndValues { false };
>+    bool useFlexibleViewport { false };
>+    bool useThreadedScrolling { true };
>+    bool enableDarkModeCSS { true };
>+    bool enableCSSTypedOM { false };
>+    bool punchOutWhiteBackgrounds { false };
>+    bool enableEditableImages { false};
>+    bool useCharacterSelectionGranularity { false };
>+    bool spellCheckingDots { false };
>+    bool enableCSSPaintingAPI { false };
>+    bool enablePointerEvents { true };
>+    bool useMockScrollbars { false };
>+    bool ignoresViewportScaleLimits { true };
>+    bool shouldIgnoreMetaViewport { false };
>+    bool enableProcessSwapOnNavigation { false };
>+    bool runSingly { false };
>+    bool enableWebAPIStatistics { false };
>+    bool enableSourceBufferChangeType { true };
>+    bool needsSiteSpecificQuirks { false };
>+    bool modernMediaControls { true };
>+    bool enableWebGL2 { false };
>+    std::string applicationManifest;
>+    std::string language;
> 
>     TestOptions(const std::string& pathOrURL, const std::string& absolutePath);
>     bool webViewIsCompatibleWithOptions(const TestOptions&) const;

Flags:

dkadu: review?

Actions: View | Formatted Diff | Diff

Attachments on bug 191303: 358263 | 358456 | 360474 | 360733 | 360737 | 360738 | 360743 | 360746 | 360760 | 360762 | 360768 | 360769 | 360779 | 360865 | 360913 | 361201 | 361302 | 361683 | 361687 | 362238