Attachment 362233 Details for Bug 194760 – Patch

[patch] Patch

bug-194760-20190217182133.patch (text/plain), 6.40 KB, created by Alicia Boya García on 2019-02-17 09:21:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alicia Boya García

Created: 2019-02-17 09:21:34 PST

Size: 6.40 KB

patch

obsolete

>Subversion Revision: 241295
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index a3d752bbbe0270f0bbbafe8de398dea1a93d01ae..e0661154cf619d607b1f1e480547ca771ec4dfef 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-17  Alicia Boya GarcÃa  <aboya@igalia.com>
>+
>+        New WPT test: imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay.html
>+        https://bugs.webkit.org/show_bug.cgi?id=194760
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This test checks that playing twice a non-MSE video works.
>+
>+        This does not work in the GStreamer ports, so I'm also updating the
>+        expectations.
>+
>+        * platform/gtk/TestExpectations:
>+        * platform/wpe/TestExpectations:
>+
> 2019-02-17  Alicia Boya GarcÃa  <aboya@igalia.com>
> 
>         New WPT test: imported/w3c/web-platform-tests/media-source/mediasource-replay.html
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index f696437c27a47ed7d54bcb9c42b1138b54b601dd..02f4a7f851ca6379f9f756490e02ada1a11729f5 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-17  Alicia Boya GarcÃa  <aboya@igalia.com>
>+
>+        New WPT test: imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay.html
>+        https://bugs.webkit.org/show_bug.cgi?id=194760
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This test checks that playing twice a non-MSE video works.
>+
>+        * web-platform-tests/html/semantics/embedded-content/media-elements/replay-expected.txt: Added.
>+        * web-platform-tests/html/semantics/embedded-content/media-elements/replay.html: Added.
>+
> 2019-02-17  Alicia Boya GarcÃa  <aboya@igalia.com>
> 
>         New WPT test: imported/w3c/web-platform-tests/media-source/mediasource-replay.html
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..9f5cbe45c9d7578bad1909b93fda887ff28b4af9
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay-expected.txt
>@@ -0,0 +1,11 @@
>+Playing audio/video again after previous playback has finished should work.
>+
>+ 
>+
>+PASS start playing audio 
>+PASS first audio playback worked 
>+PASS second audio playback worked 
>+PASS start playing video 
>+PASS first video playback worked 
>+PASS second video playback worked 
>+
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay.html b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..87ee03d5573f436c1b4e23d73ead3b22b7cab4f8
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay.html
>@@ -0,0 +1,43 @@
>+<!doctype html>
>+<html>
>+<head>
>+    <meta charset="utf-8">
>+    <title>{audio,video} can be played twice</title>
>+    <link rel="author" title="Alicia Boya GarcÃa" href="mailto:aboya@igalia.com">
>+    <meta name="timeout" content="long">
>+    <script src="/resources/testharness.js"></script>
>+    <script src="/resources/testharnessreport.js"></script>
>+    <script src="/common/media.js"></script>
>+</head>
>+<body>
>+<p>Playing audio/video again after previous playback has finished should work.</p>
>+<audio id="a" autoplay controls>
>+</audio>
>+<video id="v" controls>
>+</video>
>+<div id="log"></div>
>+<script>
>+    function playTwiceTest(kind, mediaElement, uri)
>+    {
>+        test(function () {
>+            var testPlay1 = async_test(`first ${kind} playback worked`, {timeout: 30000});
>+            var testPlay2 = async_test(`second ${kind} playback worked`, {timeout: 30000});
>+            mediaElement.addEventListener("error", testPlay1.unreached_func());
>+            mediaElement.src = uri + "?" + new Date() + Math.random();
>+            mediaElement.currentTime = 4;
>+            mediaElement.play();
>+            mediaElement.addEventListener("ended", testPlay1.step_func(function () {
>+                testPlay1.done();
>+                mediaElement.currentTime = 0;
>+                mediaElement.play();
>+                mediaElement.addEventListener("ended", testPlay2.step_func(function () {
>+                    testPlay2.done();
>+                }));
>+            }), false);
>+        }, `start playing ${kind}`);
>+    }
>+    playTwiceTest("audio", document.getElementById("a"), getAudioURI("/media/sound_5"));
>+    playTwiceTest("video", document.getElementById("v"), getVideoURI("/media/movie_5"));
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 2f3e9ac7198f0dad252edcdab9229c2f6356dccf..093f4c4cc598efbe0bb078f2aeae73f3d054d634 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -3744,6 +3744,8 @@ webkit.org/b/193641 webrtc/video-setDirection.html [ Failure ]
> 
> webkit.org/b/194384 compositing/clipping/border-radius-async-overflow-clipping-layer.html [ Failure ]
> 
>+webkit.org/b/194760 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay.html [ Failure Timeout ]
>+
> #////////////////////////////////////////////////////////////////////////////////////////
> # End of non-crashing, non-flaky tests failing
> #////////////////////////////////////////////////////////////////////////////////////////
>diff --git a/LayoutTests/platform/wpe/TestExpectations b/LayoutTests/platform/wpe/TestExpectations
>index 15735d44b64b0f5635c1eeaf7457ce62f26f7d8e..c0ed5c78d6870b42c8a3df87094f3c8756587661 100644
>--- a/LayoutTests/platform/wpe/TestExpectations
>+++ b/LayoutTests/platform/wpe/TestExpectations
>@@ -1558,6 +1558,8 @@ webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word
> 
> webkit.org/b/191886 fast/mediastream/MediaStream-video-element-remove-track.html [ Failure ]
> 
>+webkit.org/b/194760 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/replay.html [ Failure Timeout ]
>+
> #////////////////////////////////////////////////////////////////////////////////////////
> #  >> NOTICE <<
> # Please see guidelines at the top of this file and place new test expectations

Flags:

calvaris: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194760: 362232 | 362233