Attachment 362231 Details for Bug 194759 – Patch

[patch] Patch

bug-194759-20190217172915.patch (text/plain), 5.77 KB, created by Alicia Boya García on 2019-02-17 08:29:16 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alicia Boya García

Created: 2019-02-17 08:29:16 PST

Size: 5.77 KB

patch

obsolete

>Subversion Revision: 241295
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index cc6f2738a4a83ad40864d172bd6ccd41ca51dca3..a3d752bbbe0270f0bbbafe8de398dea1a93d01ae 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-02-17  Alicia Boya GarcÃa  <aboya@igalia.com>
>+
>+        New WPT test: imported/w3c/web-platform-tests/media-source/mediasource-replay.html
>+        https://bugs.webkit.org/show_bug.cgi?id=194759
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This WPT test checks that playing a video after it has finished in the
>+        MSE player works.
>+
>+        This is not working currently in the GStreamer ports (that's the
>+        reason I wrote the test), so I'm also updating TestExpectations.
>+
>+        * platform/gtk/TestExpectations:
>+        * platform/wpe/TestExpectations:
>+
> 2019-02-08  Chris Fleizach  <cfleizach@apple.com>
> 
>         AXObjectCache::childrenChanged shouldn't update layout or style during another style recalc
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index b3d0cbf43885b871124f8ccd0a7f86bbaef9eff2..f696437c27a47ed7d54bcb9c42b1138b54b601dd 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-17  Alicia Boya GarcÃa  <aboya@igalia.com>
>+
>+        New WPT test: imported/w3c/web-platform-tests/media-source/mediasource-replay.html
>+        https://bugs.webkit.org/show_bug.cgi?id=194759
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This WPT test checks that playing a video after it has finished in the
>+        MSE player works.
>+
>+        * web-platform-tests/media-source/mediasource-replay-expected.txt: Added.
>+        * web-platform-tests/media-source/mediasource-replay.html: Added.
>+
> 2019-01-30  Youenn Fablet  <youenn@apple.com>
> 
>         ServiceWorkerJob should notify its client in case its job is cancelled
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-replay-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-replay-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..5ab6336f8451f100a4e838cf9a2951a78b5db06c
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-replay-expected.txt
>@@ -0,0 +1,3 @@
>+
>+PASS Test playing twice. 
>+
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-replay.html b/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-replay.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..69735a2bdba4f683b6646a347fb734928373c798
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-replay.html
>@@ -0,0 +1,42 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+    <meta charset="utf-8">
>+    <title>MediaSource replay test case.</title>
>+    <link rel="author" title="Alicia Boya GarcÃa" href="mailto:aboya@igalia.com">
>+    <script src="/resources/testharness.js"></script>
>+    <script src="/resources/testharnessreport.js"></script>
>+    <script src="mediasource-util.js"></script>
>+</head>
>+<body>
>+<div id="log"></div>
>+<script>
>+    mediasource_testafterdataloaded(function (test, mediaElement, mediaSource, segmentInfo, sourceBuffer, mediaData) {
>+        // To make the test faster, let's clip the duration.
>+        sourceBuffer.appendWindowEnd = 0.5;
>+
>+        test.expectEvent(sourceBuffer, 'updateend', 'sourceBuffer');
>+        sourceBuffer.appendBuffer(mediaData);
>+
>+        test.waitForExpectedEvents(function () {
>+            mediaSource.endOfStream();
>+            test.expectEvent(mediaElement, 'playing', 'Playing triggered');
>+            test.expectEvent(mediaElement, 'ended', 'First playback ends');
>+            mediaElement.play();
>+        });
>+
>+        test.waitForExpectedEvents(function () {
>+            // Play again from the beginning.
>+            mediaElement.play();
>+            test.expectEvent(mediaElement, 'playing', 'Playing triggered');
>+            test.expectEvent(mediaElement, 'ended', 'First playback ends');
>+        });
>+
>+        test.waitForExpectedEvents(function () {
>+            test.done();
>+        })
>+
>+    }, 'Test playing twice.');
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index c851c7557b5ef9a454cd452a423c2a3020248299..2f3e9ac7198f0dad252edcdab9229c2f6356dccf 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -1357,6 +1357,8 @@ webkit.org/b/191882 fast/forms/validation-message-in-relative-body.html [ Failur
> 
> webkit.org/b/194385 imported/w3c/web-platform-tests/service-workers/service-worker/clients-get.https.html [ Crash ]
> 
>+webkit.org/b/194759 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Crash Failure Timeout ]
>+
> #////////////////////////////////////////////////////////////////////////////////////////
> # End of Crashing tests
> #////////////////////////////////////////////////////////////////////////////////////////
>diff --git a/LayoutTests/platform/wpe/TestExpectations b/LayoutTests/platform/wpe/TestExpectations
>index 4436920ed99167c6bd438e802bbe71a9d5216bf8..15735d44b64b0f5635c1eeaf7457ce62f26f7d8e 100644
>--- a/LayoutTests/platform/wpe/TestExpectations
>+++ b/LayoutTests/platform/wpe/TestExpectations
>@@ -629,6 +629,8 @@ webkit.org/b/188162 [ Debug ] fast/canvas/webgl/texImage2D-video-flipY-true.html
> 
> webkit.org/b/188000 animations/play-state-start-paused.html [ Crash ]
> 
>+webkit.org/b/194759 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Crash Failure Timeout ]
>+
> #////////////////////////////////////////////////////////////////////////////////////////
> # 6. FLAKY TESTS
> #////////////////////////////////////////////////////////////////////////////////////////

Flags:

clopez: review-
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 194759: 362231 | 362235 | 362236 | 362239