Attachment 362219 Details for Bug 194745 – Patch

[patch] Patch

bug-194745-20190216074719.patch (text/plain), 4.74 KB, created by zalan on 2019-02-16 07:47:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2019-02-16 07:47:20 PST

Size: 4.74 KB

patch

obsolete

>Subversion Revision: 241647
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f9678c312dac2f5ca9fca7e80374351f177f51b3..4d72ab7d56b8af61da1c0dca8feb66e60f92641a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-16  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC] RenderImage's default intrinsic size is 0.
>+        https://bugs.webkit.org/show_bug.cgi?id=194745
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        While the images are being loaded, their intrinsic size is set to 0 (RenderImage c'tor). Note that this code is temporary.
>+        * layout/layouttree/LayoutTreeBuilder.cpp:
>+        (WebCore::Layout::TreeBuilder::createSubTree):
>+
> 2019-02-16  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC] Add support for block replaced intrinsic width.
>diff --git a/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp b/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
>index 36dbf9f42d14a4207d714d703e347188e81d73d6..e6102dcaed4af834fa00ea4e4b72e6cffab8697f 100644
>--- a/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
>+++ b/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
>@@ -104,8 +104,8 @@ void TreeBuilder::createSubTree(const RenderElement& rootRenderer, Container& ro
>                 box = std::make_unique<Box>(elementAttributes(renderer), RenderStyle::clone(renderer.style()));
>             else
>                 box = std::make_unique<InlineBox>(elementAttributes(renderer), RenderStyle::clone(renderer.style()));
>-            // FIXME: We don't yet support all replaced elements.
>-            if (!renderer.intrinsicSize().isEmpty() && box->replaced())
>+            // FIXME: We don't yet support all replaced elements and this is temporary anyway.
>+            if (box->replaced())
>                 box->replaced()->setIntrinsicSize(renderer.intrinsicSize());
>             if (is<RenderImage>(renderer)) {
>                 auto& imageRenderer = downcast<RenderImage>(renderer);
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6c089559a6fcded6b69a00c3f887aec514233f07..4bfe9cfa29f103c6aee0a9c803ad1f9a942edcf6 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-02-16  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC] RenderImage's default intrinsic size is 0.
>+        https://bugs.webkit.org/show_bug.cgi?id=194745
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * LayoutReloaded/misc/LFC-passing-tests.txt:
>+
> 2019-02-16  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC] Add support for block replaced intrinsic width.
>diff --git a/Tools/LayoutReloaded/misc/LFC-passing-tests.txt b/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>index 0728a2397cd7c0e3a880e5cf86e1e46e55a0ca4d..1fbfb9ebf6708f430e27369ca9e08b81d9956ebf 100644
>--- a/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>+++ b/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>@@ -706,6 +706,12 @@ css2.1/20110323/absolute-non-replaced-width-013.htm
> css2.1/20110323/absolute-non-replaced-width-014.htm
> css2.1/20110323/absolute-non-replaced-width-015.htm
> css2.1/20110323/absolute-non-replaced-width-016.htm
>+css2.1/20110323/absolute-non-replaced-width-017.htm
>+css2.1/20110323/absolute-non-replaced-width-018.htm
>+css2.1/20110323/absolute-non-replaced-width-019.htm
>+css2.1/20110323/absolute-non-replaced-width-020.htm
>+css2.1/20110323/absolute-non-replaced-width-021.htm
>+css2.1/20110323/absolute-non-replaced-width-022.htm
> css2.1/20110323/absolute-replaced-height-001.htm
> css2.1/20110323/absolute-replaced-height-002.htm
> css2.1/20110323/absolute-replaced-height-003.htm
>@@ -793,6 +799,7 @@ css2.1/20110323/block-non-replaced-width-006.htm
> css2.1/20110323/block-non-replaced-width-007.htm
> css2.1/20110323/block-non-replaced-width-008.htm
> css2.1/20110323/block-replaced-height-001.htm
>+css2.1/20110323/block-replaced-height-002.htm
> css2.1/20110323/block-replaced-height-003.htm
> css2.1/20110323/block-replaced-height-004.htm
> css2.1/20110323/block-replaced-height-005.htm
>@@ -824,6 +831,8 @@ css2.1/20110323/float-non-replaced-width-010.htm
> css2.1/20110323/float-non-replaced-width-011.htm
> css2.1/20110323/float-non-replaced-width-012.htm
> css2.1/20110323/float-replaced-height-001.htm
>+css2.1/20110323/float-replaced-height-002.htm
>+css2.1/20110323/float-replaced-height-003.htm
> css2.1/20110323/float-replaced-height-004.htm
> css2.1/20110323/float-replaced-height-005.htm
> css2.1/20110323/float-replaced-height-007.htm
>@@ -838,6 +847,7 @@ css2.1/20110323/floats-001.html
> css2.1/20110323/floats-102.html
> css2.1/20110323/inline-block-non-replaced-width-001.htm
> css2.1/20110323/inline-block-non-replaced-width-002.htm
>+css2.1/20110323/inline-block-non-replaced-width-003.htm
> css2.1/20110323/inline-block-replaced-height-001.htm
> css2.1/20110323/inline-block-replaced-height-002.htm
> css2.1/20110323/inline-block-replaced-height-003.htm

Actions: View | Formatted Diff | Diff

Attachments on bug 194745: 362219