Attachment 362204 Details for Bug 194738 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

oops-1.patch (text/plain), 1.71 KB, created by Joseph Pecoraro on 2019-02-15 20:47:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-02-15 20:47:00 PST

Size: 1.71 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 57692543bac..acb712575a1 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-02-15  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Some timelines views work, show Legacy CPU timeline
>+        https://bugs.webkit.org/show_bug.cgi?id=194738
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/ContentView.js:
>+        (WI.ContentView.createFromRepresentedObject):
>+
> 2019-02-12  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Better categorize CPU usage per-thread / worker
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ContentView.js b/Source/WebInspectorUI/UserInterface/Views/ContentView.js
>index 959036b9cfe..29c617ef473 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ContentView.js
>@@ -83,10 +83,11 @@ WI.ContentView = class ContentView extends WI.View
>             if (timelineType === WI.TimelineRecord.Type.RenderingFrame)
>                 return new WI.RenderingFrameTimelineView(representedObject, extraArguments);
> 
>-            if (timelineType === WI.TimelineRecord.Type.CPU)
>+            if (timelineType === WI.TimelineRecord.Type.CPU) {
>                 if (WI.settings.experimentalEnableCPUUsageEnhancements.value)
>                     return new WI.CPUTimelineView(representedObject, extraArguments);
>                 return new WI.LegacyCPUTimelineView(representedObject, extraArguments);
>+            }
> 
>             if (timelineType === WI.TimelineRecord.Type.Memory)
>                 return new WI.MemoryTimelineView(representedObject, extraArguments);

Actions: View | Formatted Diff | Diff

Attachments on bug 194738: 362204