Attachment 362192 Details for Bug 191368 – Patch

[patch] Patch

bug-191368-20190216022548.patch (text/plain), 3.35 KB, created by Per Arne Vollan on 2019-02-15 17:25:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2019-02-15 17:25:49 PST

Size: 3.35 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 241634)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2019-02-15  Per Arne Vollan  <pvollan@apple.com>
>+
>+        Layout Test fast/text/international/khmer-selection.html is crashing
>+        https://bugs.webkit.org/show_bug.cgi?id=191368
>+        <rdar://problem/47922356>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add an out of bounds check for GlyphBuffer's offsets in string array.
>+
>+        No new tests, covered by existing tests.
>+
>+        * platform/graphics/GlyphBuffer.h:
>+        (WebCore::GlyphBuffer::offsetInString const):
>+
> 2019-02-15  Dean Jackson  <dino@apple.com>
> 
>         Allow emulation of user gestures from Web Inspector console
>Index: Source/WebCore/platform/graphics/GlyphBuffer.h
>===================================================================
>--- Source/WebCore/platform/graphics/GlyphBuffer.h	(revision 241595)
>+++ Source/WebCore/platform/graphics/GlyphBuffer.h	(working copy)
>@@ -157,6 +157,8 @@ public:
>     int offsetInString(unsigned index) const
>     {
>         ASSERT(m_offsetsInString);
>+        if (index >= m_offsetsInString->size())
>+            return GlyphBuffer::noOffset;
>         return (*m_offsetsInString)[index];
>     }
> 
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 241595)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-02-15  Per Arne Vollan  <pvollan@apple.com>
>+
>+        Layout Test fast/text/international/khmer-selection.html is crashing
>+        https://bugs.webkit.org/show_bug.cgi?id=191368
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/win/TestExpectations:
>+
> 2019-02-15  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Out-of-flow box is never a float box
>Index: LayoutTests/platform/win/TestExpectations
>===================================================================
>--- LayoutTests/platform/win/TestExpectations	(revision 241595)
>+++ LayoutTests/platform/win/TestExpectations	(working copy)
>@@ -2506,7 +2506,7 @@ fast/frames/frame-navigation.html [ Skip
> 
> fast/text/atsui-pointtooffset-calls-cg.html [ Pass Failure ]
> fast/text/international/hindi-whitespace.html [ Failure ]
>-fast/text/international/khmer-selection.html [ Failure Crash ]
>+fast/text/international/khmer-selection.html [ Failure ]
> webkit.org/b/140231 fast/text/international/plane2.html [ Failure ]
> webkit.org/b/35973 fast/multicol/hit-test-above-or-below.html [ Failure ]
> webkit.org/b/49769 fast/dom/HTMLProgressElement/progress-element-with-child-crash.html [ Failure ]
>@@ -4222,10 +4222,6 @@ webkit.org/b/191366 fast/block/basic/chi
> webkit.org/b/191366 fast/block/basic/height-percentage-simple.html [ Failure ]
> webkit.org/b/191366 fast/block/basic/quirk-mode-percent-height.html [ Failure ]
> 
>-webkit.org/b/191368 fast/text/stroking-decorations.html [ Crash ]
>-webkit.org/b/191368 imported/blink/fast/text/international/complex-text-trailing-space.html [ Crash ]
>-webkit.org/b/191368 imported/blink/fast/text/sub-pixel/complex-text-preferred-width.html [ Crash ]
>-
> webkit.org/b/191584 animations/animation-direction-normal.html [ Failure ]
> webkit.org/b/191584 animations/animation-direction-reverse.html [ Failure ]
> webkit.org/b/191584 animations/dynamic-stylesheet-loading.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 191368: 362192 | 362361 | 362519 | 362533 | 362552 | 362558 | 362613