Attachment 362182 Details for Bug 194732 – Patch

[patch] Patch

bug-194732-20190215164624.patch (text/plain), 1.82 KB, created by youenn fablet on 2019-02-15 16:46:25 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-02-15 16:46:25 PST

Size: 1.82 KB

patch

obsolete

>Subversion Revision: 241548
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 2899fcf63dd978730d468831ae42f33782916341..b2b5f0d407d4d3cee5b41d50c1f8a1f0bfeead7d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-15  Youenn Fablet  <youenn@apple.com>
>+
>+        NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics
>+        https://bugs.webkit.org/show_bug.cgi?id=194732
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        NetworkDataTask may be kept alive if refing it after its NetworkLoad is gone.
>+        This might happen for instance in DownloadManager or when checking for TLS certificates.
>+        In that case, if the NetworkLoad gets destroyed, it clears the client of the NetworkDataTask.
>+        To ensure that NetworkDataTask does not try to use its client, add a null check.
>+
>+        * NetworkProcess/NetworkDataTask.cpp:
>+        (WebKit::NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics const):
>+
> 2019-02-15  Youenn Fablet  <youenn@apple.com>
> 
>         Move service worker response validation from the service worker client to the service worker itself
>diff --git a/Source/WebKit/NetworkProcess/NetworkDataTask.cpp b/Source/WebKit/NetworkProcess/NetworkDataTask.cpp
>index c69d6504064db34b445f746177111f0f7ef6edac..3e5adaf11b9cd77b9607f839ff09228ccf0e6794 100644
>--- a/Source/WebKit/NetworkProcess/NetworkDataTask.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkDataTask.cpp
>@@ -114,7 +114,7 @@ void NetworkDataTask::didReceiveResponse(ResourceResponse&& response, ResponseCo
> 
> bool NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics() const
> {
>-    return m_client->shouldCaptureExtraNetworkLoadMetrics();
>+    return m_client ? m_client->shouldCaptureExtraNetworkLoadMetrics() : false;
> }
> 
> void NetworkDataTask::failureTimerFired()

Actions: View | Formatted Diff | Diff

Attachments on bug 194732: 362182