Attachment 362180 Details for Bug 194729 – Patch

[patch] Patch

patch.txt (text/plain), 3.46 KB, created by Nikita Vasilyev on 2019-02-15 16:31:36 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-02-15 16:31:36 PST

Size: 3.46 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index e2c797b3cb0..1693f935c97 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-02-15  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Dark Mode: commas in CSS selectors are too dim
>+        https://bugs.webkit.org/show_bug.cgi?id=194729
>+        <rdar://problem/48128592>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use `--text-color-tertiary` for both light and dark modes.
>+
>+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
>+        (.spreadsheet-style-declaration-editor):
>+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
>+        (.spreadsheet-css-declaration):
>+        (.spreadsheet-css-declaration .selector > span):
>+        (@media (prefers-color-scheme: dark)):
>+        * UserInterface/Views/Variables.css:
>+        (:root):
>+
> 2019-02-15  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: valid values in style attributes are reported as unsupported property values
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>index 98b74988b75..9e6439b06fb 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>@@ -28,7 +28,7 @@
>     clear: both;
>     font-family: Menlo, monospace;
>     font-size: 11px;
>-    color: hsl(0, 0%, 70%);
>+    color: var(--text-color-tertiary);
>     -webkit-user-select: text;
> 
>     --background-color-selected: hsl(210, 98%, 93%);
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css
>index 620f6274383..b75cd511d61 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css
>@@ -28,8 +28,8 @@
>     padding: 0 0 var(--css-declaration-vertical-padding);
>     font-family: Menlo, monospace;
>     font-size: 11px;
>-    color: hsl(0, 0%, 70%);
>-    background: white;
>+    color: var(--text-color-tertiary);
>+    background: var(--background-color-code);
>     border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2);
>     -webkit-user-select: text;
> }
>@@ -100,7 +100,7 @@
> }
> 
> .spreadsheet-css-declaration .selector > span {
>-    color: hsl(0, 0%, 50%);
>+    color: var(--text-color-secondary);
> }
> 
> .spreadsheet-css-declaration .selector:focus,
>@@ -135,9 +135,6 @@
> 
> @media (prefers-color-scheme: dark) {
>     .spreadsheet-css-declaration {
>-        background: var(--background-color-code);
>-        color: var(--text-color-tertiary);
>-        color: hsl(0, 0%, 30%);
>         border-bottom-color: var(--text-color-quaternary);
>     }
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Variables.css b/Source/WebInspectorUI/UserInterface/Views/Variables.css
>index 775f1f6105f..3eac5b98ed3 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Variables.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/Variables.css
>@@ -39,6 +39,9 @@
> 
>     --text-color-secondary: hsl(0, 0%, 50%);
> 
>+    /* Disabled text/glyphs */
>+    --text-color-tertiary: hsl(0, 0%, 70%);
>+
>     /* Dividers, separators, background fills */
>     --text-color-quaternary: hsl(0, 0%, 85%);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194729: 362175 | 362177 | 362180 | 362181 | 362191