WebKit Bugzilla
Attachment 362176 Details for
Bug 194730
: NetworkLoad should cancel its task at destruction time
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194730-20190215161721.patch (text/plain), 1.64 KB, created by
youenn fablet
on 2019-02-15 16:17:22 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
youenn fablet
Created:
2019-02-15 16:17:22 PST
Size:
1.64 KB
patch
obsolete
>Subversion Revision: 241548 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 2899fcf63dd978730d468831ae42f33782916341..da0427328ce31adfb59b8d07b6c45962b7372aa8 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,18 @@ >+2019-02-15 Youenn Fablet <youenn@apple.com> >+ >+ NetworkLoad should cancel its task at destruction time >+ https://bugs.webkit.org/show_bug.cgi?id=194730 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ NetworkDataTask may be kept alive if refing it. >+ This might happen for instance in DownloadManager or when checking for TLS certificates. >+ In that case, if the NetworkLoad get destroyed, it clears the client of the NetworkDataTask. >+ To ensure that NetworkDataTask does not try to use its client, cancel it at the same time. >+ >+ * NetworkProcess/NetworkLoad.cpp: >+ (WebKit::NetworkLoad::~NetworkLoad): >+ > 2019-02-15 Youenn Fablet <youenn@apple.com> > > Move service worker response validation from the service worker client to the service worker itself >diff --git a/Source/WebKit/NetworkProcess/NetworkLoad.cpp b/Source/WebKit/NetworkProcess/NetworkLoad.cpp >index 3a6fa10cf9f7ed4bfcd83d0ba27468eb2317060b..8e705d384f5b2c6887670044a72c0e9a21f72fe4 100644 >--- a/Source/WebKit/NetworkProcess/NetworkLoad.cpp >+++ b/Source/WebKit/NetworkProcess/NetworkLoad.cpp >@@ -80,8 +80,10 @@ NetworkLoad::~NetworkLoad() > ASSERT(RunLoop::isMain()); > if (m_redirectCompletionHandler) > m_redirectCompletionHandler({ }); >- if (m_task) >+ if (m_task) { > m_task->clearClient(); >+ m_task->cancel(); >+ } > } > > void NetworkLoad::cancel()
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
achristensen
:
review-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194730
:
362176