Attachment 362172 Details for Bug 194728 – Patch

[patch] Patch

bug-194728-20190215154919.patch (text/plain), 2.05 KB, created by Yusuke Suzuki on 2019-02-15 15:49:19 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-02-15 15:49:19 PST

Size: 2.05 KB

patch

obsolete

>Subversion Revision: 241622
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index afbce2c145902388cb652341e59c4f8e40ca888e..4b9f0951ac7aa7d739297c07519c157735e00de4 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-15  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [JSC] Do not initialize Wasm related data if Wasm is not enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=194728
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Under non-JIT mode, these data structures are unnecessary. Should not allocate extra memory for that.
>+
>+        * runtime/InitializeThreading.cpp:
>+        (JSC::initializeThreading):
>+        * runtime/JSLock.cpp:
>+        (JSC::JSLock::didAcquireLock):
>+
> 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         [WTF] Add environment variable helpers
>diff --git a/Source/JavaScriptCore/runtime/InitializeThreading.cpp b/Source/JavaScriptCore/runtime/InitializeThreading.cpp
>index 50a8052e8f461855ffd56564343ca7e1d465c455..2522ffd7895cbfde10c34a21500b28114e83a2af 100644
>--- a/Source/JavaScriptCore/runtime/InitializeThreading.cpp
>+++ b/Source/JavaScriptCore/runtime/InitializeThreading.cpp
>@@ -81,7 +81,8 @@ void initializeThreading()
>         thread.setSavedLastStackTop(thread.stack().origin());
> 
> #if ENABLE(WEBASSEMBLY)
>-        Wasm::Thunks::initialize();
>+        if (Options::useWebAssembly())
>+            Wasm::Thunks::initialize();
> #endif
> 
>         if (VM::isInMiniMode())
>diff --git a/Source/JavaScriptCore/runtime/JSLock.cpp b/Source/JavaScriptCore/runtime/JSLock.cpp
>index 35d590b0669ab05a8c51a65973af263e3cc5969c..ece526d5c88ccc6ce003f2acc39cf8f989934431 100644
>--- a/Source/JavaScriptCore/runtime/JSLock.cpp
>+++ b/Source/JavaScriptCore/runtime/JSLock.cpp
>@@ -149,7 +149,8 @@ void JSLock::didAcquireLock()
> 
>     m_vm->heap.machineThreads().addCurrentThread();
> #if ENABLE(WEBASSEMBLY)
>-    Wasm::startTrackingCurrentThread();
>+    if (Options::useWebAssembly())
>+        Wasm::startTrackingCurrentThread();
> #endif
> 
> #if HAVE(MACH_EXCEPTIONS)

Actions: View | Formatted Diff | Diff

Attachments on bug 194728: 362172