WebKit Bugzilla
Attachment 362170 Details for
Bug 194727
: [JSC] Make builtin objects more lazily initialized under non-JIT mode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194727-20190215153852.patch (text/plain), 25.23 KB, created by
Yusuke Suzuki
on 2019-02-15 15:38:53 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yusuke Suzuki
Created:
2019-02-15 15:38:53 PST
Size:
25.23 KB
patch
obsolete
>Subversion Revision: 241618 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index b45a448ce856ef0393cba4810d9bdbd51da15a02..0433ee0e2d6e69b9e786b9e8be96df3f1b5b3b51 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,31 @@ >+2019-02-15 Yusuke Suzuki <ysuzuki@apple.com> >+ >+ [JSC] Make builtin objects more lazily initialized under non-JIT mode >+ https://bugs.webkit.org/show_bug.cgi?id=194727 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Boolean, Symbol, and Number constructors and prototypes are initialized eagerly, but this is largely >+ because concurrent compiler can touch NumberPrototype etc. when traversing object's prototypes. This >+ means that eager initialization is not necessary under non-JIT mode. While we can investigate all the >+ accesses to these prototypes from the concurrent compiler threads, this "lazily initialize uder non-JIT" >+ is safe and beneficial to non-JIT mode. This patch lazily initializes them under non-JIT mode, and >+ drop some @Number referneces to avoid eager initialization. This removes some object allocations and 1 >+ MarkedBlock allocation just for Symbols. >+ >+ * runtime/JSGlobalObject.cpp: >+ (JSC::JSGlobalObject::init): >+ (JSC::JSGlobalObject::visitChildren): >+ * runtime/JSGlobalObject.h: >+ (JSC::JSGlobalObject::numberToStringWatchpoint): >+ (JSC::JSGlobalObject::booleanPrototype const): >+ (JSC::JSGlobalObject::numberPrototype const): >+ (JSC::JSGlobalObject::symbolPrototype const): >+ (JSC::JSGlobalObject::booleanObjectStructure const): >+ (JSC::JSGlobalObject::symbolObjectStructure const): >+ (JSC::JSGlobalObject::numberObjectStructure const): >+ (JSC::JSGlobalObject::stringObjectStructure const): >+ > 2019-02-15 Mark Lam <mark.lam@apple.com> > > SamplingProfiler::stackTracesAsJSON() should escape strings. >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index c4b5bc82bfc8f1b69bde6993f1ee94b767ee9b7a..71c17bacbb569d6d66d7440c075a022821f00578 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,14 @@ >+2019-02-15 Yusuke Suzuki <ysuzuki@apple.com> >+ >+ [JSC] Make builtin objects more lazily initialized under non-JIT mode >+ https://bugs.webkit.org/show_bug.cgi?id=194727 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Modules/streams/ReadableByteStreamInternals.js: >+ (privateInitializeReadableByteStreamController): >+ (readableByteStreamControllerRespond): >+ > 2019-02-15 Antoine Quint <graouts@apple.com> > > Add a method to dispatch a PointerEvent based on a PlatformTouchEvent >diff --git a/Source/JavaScriptCore/runtime/JSGlobalObject.cpp b/Source/JavaScriptCore/runtime/JSGlobalObject.cpp >index 019bf9b0128281cd1a5a42ce072637aef242807b..c23c19257f4b297c78bdb2ebd0c558e5991c9453 100644 >--- a/Source/JavaScriptCore/runtime/JSGlobalObject.cpp >+++ b/Source/JavaScriptCore/runtime/JSGlobalObject.cpp >@@ -328,6 +328,7 @@ const GlobalObjectMethodTable JSGlobalObject::s_globalObjectMethodTable = { > Date JSGlobalObject::m_dateStructure DontEnum|ClassStructure > Boolean JSGlobalObject::m_booleanObjectStructure DontEnum|ClassStructure > Number JSGlobalObject::m_numberObjectStructure DontEnum|ClassStructure >+ Symbol JSGlobalObject::m_symbolObjectStructure DontEnum|ClassStructure > WeakMap JSGlobalObject::m_weakMapStructure DontEnum|ClassStructure > WeakSet JSGlobalObject::m_weakSetStructure DontEnum|ClassStructure > @end >@@ -763,7 +764,6 @@ m_ ## lowerName ## Prototype->putDirectWithoutTransition(vm, vm.propertyNames->c > m_asyncGeneratorPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, m_asyncGeneratorFunctionPrototype.get(), PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly); > m_asyncGeneratorFunctionPrototype->putDirectWithoutTransition(vm, vm.propertyNames->prototype, m_asyncGeneratorPrototype.get(), PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly); > >- > m_objectPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, objectConstructor, static_cast<unsigned>(PropertyAttribute::DontEnum)); > m_functionPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, functionConstructor, static_cast<unsigned>(PropertyAttribute::DontEnum)); > m_arrayPrototype->putDirectWithoutTransition(vm, vm.propertyNames->constructor, arrayConstructor, static_cast<unsigned>(PropertyAttribute::DontEnum)); >@@ -906,7 +906,6 @@ putDirectWithoutTransition(vm, vm.propertyNames-> jsName, lowerName ## Construct > GlobalPropertyInfo(vm.propertyNames->builtinNames().instanceOfPrivateName(), privateFuncInstanceOf, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly), > GlobalPropertyInfo(vm.propertyNames->builtinNames().BuiltinLogPrivateName(), builtinLog, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly), > GlobalPropertyInfo(vm.propertyNames->builtinNames().BuiltinDescribePrivateName(), builtinDescribe, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly), >- GlobalPropertyInfo(vm.propertyNames->builtinNames().NumberPrivateName(), numberConstructor, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly), > GlobalPropertyInfo(vm.propertyNames->builtinNames().RegExpPrivateName(), regExpConstructor, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly), > GlobalPropertyInfo(vm.propertyNames->builtinNames().StringPrivateName(), stringConstructor, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly), > GlobalPropertyInfo(vm.propertyNames->builtinNames().absPrivateName(), privateFuncAbs, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly), >@@ -1024,91 +1023,93 @@ putDirectWithoutTransition(vm, vm.propertyNames-> jsName, lowerName ## Construct > } > #endif // ENABLE(WEBASSEMBLY) > >- { >+ auto setupAdaptiveWatchpoint = [&] (JSObject* base, const Identifier& ident) -> ObjectPropertyCondition { >+ // Performing these gets should not throw. > ExecState* exec = globalExec(); >+ PropertySlot slot(base, PropertySlot::InternalMethodType::Get); >+ bool result = base->getOwnPropertySlot(base, exec, ident, slot); >+ ASSERT_UNUSED(result, result); >+ catchScope.assertNoException(); >+ RELEASE_ASSERT(slot.isCacheableValue()); >+ JSValue functionValue = slot.getValue(exec, ident); >+ catchScope.assertNoException(); >+ ASSERT(jsDynamicCast<JSFunction*>(vm, functionValue)); >+ >+ ObjectPropertyCondition condition = generateConditionForSelfEquivalence(m_vm, nullptr, base, ident.impl()); >+ RELEASE_ASSERT(condition.requiredValue() == functionValue); >+ >+ bool isWatchable = condition.isWatchable(PropertyCondition::EnsureWatchability); >+ RELEASE_ASSERT(isWatchable); // We allow this to install the necessary watchpoints. >+ >+ return condition; >+ }; > >- auto setupAdaptiveWatchpoint = [&] (JSObject* base, const Identifier& ident) -> ObjectPropertyCondition { >- // Performing these gets should not throw. >- PropertySlot slot(base, PropertySlot::InternalMethodType::Get); >- bool result = base->getOwnPropertySlot(base, exec, ident, slot); >- ASSERT_UNUSED(result, result); >- catchScope.assertNoException(); >- RELEASE_ASSERT(slot.isCacheableValue()); >- JSValue functionValue = slot.getValue(exec, ident); >- catchScope.assertNoException(); >- ASSERT(jsDynamicCast<JSFunction*>(vm, functionValue)); >- >- ObjectPropertyCondition condition = generateConditionForSelfEquivalence(m_vm, nullptr, base, ident.impl()); >- RELEASE_ASSERT(condition.requiredValue() == functionValue); >- >- bool isWatchable = condition.isWatchable(PropertyCondition::EnsureWatchability); >- RELEASE_ASSERT(isWatchable); // We allow this to install the necessary watchpoints. >- >- return condition; >- }; >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(arrayIteratorPrototype, m_vm.propertyNames->next); >+ m_arrayIteratorPrototypeNext = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_arrayIteratorProtocolWatchpoint); >+ m_arrayIteratorPrototypeNext->install(vm); >+ } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(this->arrayPrototype(), m_vm.propertyNames->iteratorSymbol); >+ m_arrayPrototypeSymbolIteratorWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_arrayIteratorProtocolWatchpoint); >+ m_arrayPrototypeSymbolIteratorWatchpoint->install(vm); >+ } > >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(arrayIteratorPrototype, m_vm.propertyNames->next); >- m_arrayIteratorPrototypeNext = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_arrayIteratorProtocolWatchpoint); >- m_arrayIteratorPrototypeNext->install(vm); >- } >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(this->arrayPrototype(), m_vm.propertyNames->iteratorSymbol); >- m_arrayPrototypeSymbolIteratorWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_arrayIteratorProtocolWatchpoint); >- m_arrayPrototypeSymbolIteratorWatchpoint->install(vm); >- } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(mapIteratorPrototype, m_vm.propertyNames->next); >+ m_mapIteratorPrototypeNextWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_mapIteratorProtocolWatchpoint); >+ m_mapIteratorPrototypeNextWatchpoint->install(vm); >+ } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_mapPrototype.get(), m_vm.propertyNames->iteratorSymbol); >+ m_mapPrototypeSymbolIteratorWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_mapIteratorProtocolWatchpoint); >+ m_mapPrototypeSymbolIteratorWatchpoint->install(vm); >+ } > >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(mapIteratorPrototype, m_vm.propertyNames->next); >- m_mapIteratorPrototypeNextWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_mapIteratorProtocolWatchpoint); >- m_mapIteratorPrototypeNextWatchpoint->install(vm); >- } >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_mapPrototype.get(), m_vm.propertyNames->iteratorSymbol); >- m_mapPrototypeSymbolIteratorWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_mapIteratorProtocolWatchpoint); >- m_mapPrototypeSymbolIteratorWatchpoint->install(vm); >- } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(setIteratorPrototype, m_vm.propertyNames->next); >+ m_setIteratorPrototypeNextWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_setIteratorProtocolWatchpoint); >+ m_setIteratorPrototypeNextWatchpoint->install(vm); >+ } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_setPrototype.get(), m_vm.propertyNames->iteratorSymbol); >+ m_setPrototypeSymbolIteratorWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_setIteratorProtocolWatchpoint); >+ m_setPrototypeSymbolIteratorWatchpoint->install(vm); >+ } > >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(setIteratorPrototype, m_vm.propertyNames->next); >- m_setIteratorPrototypeNextWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_setIteratorProtocolWatchpoint); >- m_setIteratorPrototypeNextWatchpoint->install(vm); >- } >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_setPrototype.get(), m_vm.propertyNames->iteratorSymbol); >- m_setPrototypeSymbolIteratorWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_setIteratorProtocolWatchpoint); >- m_setPrototypeSymbolIteratorWatchpoint->install(vm); >- } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_stringIteratorPrototype.get(), m_vm.propertyNames->next); >+ m_stringIteratorPrototypeNextWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_stringIteratorProtocolWatchpoint); >+ m_stringIteratorPrototypeNextWatchpoint->install(vm); >+ } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_stringPrototype.get(), m_vm.propertyNames->iteratorSymbol); >+ m_stringPrototypeSymbolIteratorWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_stringIteratorProtocolWatchpoint); >+ m_stringPrototypeSymbolIteratorWatchpoint->install(vm); >+ } > >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_stringIteratorPrototype.get(), m_vm.propertyNames->next); >- m_stringIteratorPrototypeNextWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_stringIteratorProtocolWatchpoint); >- m_stringIteratorPrototypeNextWatchpoint->install(vm); >- } >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_stringPrototype.get(), m_vm.propertyNames->iteratorSymbol); >- m_stringPrototypeSymbolIteratorWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_stringIteratorProtocolWatchpoint); >- m_stringPrototypeSymbolIteratorWatchpoint->install(vm); >- } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_mapPrototype.get(), m_vm.propertyNames->set); >+ m_mapPrototypeSetWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_mapSetWatchpoint); >+ m_mapPrototypeSetWatchpoint->install(vm); >+ } > >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_mapPrototype.get(), m_vm.propertyNames->set); >- m_mapPrototypeSetWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_mapSetWatchpoint); >- m_mapPrototypeSetWatchpoint->install(vm); >- } >+ { >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_setPrototype.get(), m_vm.propertyNames->add); >+ m_setPrototypeAddWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_setAddWatchpoint); >+ m_setPrototypeAddWatchpoint->install(vm); >+ } > >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(m_setPrototype.get(), m_vm.propertyNames->add); >- m_setPrototypeAddWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_setAddWatchpoint); >- m_setPrototypeAddWatchpoint->install(vm); >- } >+ // Unfortunately, the prototype objects of the builtin objects can be touched from concurrent compilers. So eagerly initialize them only if we use JIT. >+ if (VM::canUseJIT()) { >+ this->booleanPrototype(); >+ auto* numberPrototype = this->numberPrototype(); >+ this->symbolPrototype(); > >- { >- ObjectPropertyCondition condition = setupAdaptiveWatchpoint(numberPrototype(), m_vm.propertyNames->toString); >- m_numberPrototypeToStringWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_numberToStringWatchpoint); >- m_numberPrototypeToStringWatchpoint->install(vm); >- m_numberProtoToStringFunction.set(vm, this, jsCast<JSFunction*>(numberPrototype()->getDirect(vm, vm.propertyNames->toString))); >- } >+ ObjectPropertyCondition condition = setupAdaptiveWatchpoint(numberPrototype, m_vm.propertyNames->toString); >+ m_numberPrototypeToStringWatchpoint = std::make_unique<ObjectPropertyChangeAdaptiveWatchpoint<InlineWatchpointSet>>(condition, m_numberToStringWatchpoint); >+ m_numberPrototypeToStringWatchpoint->install(vm); >+ m_numberProtoToStringFunction.set(vm, this, jsCast<JSFunction*>(numberPrototype->getDirect(vm, vm.propertyNames->toString))); > } > > resetPrototype(vm, getPrototypeDirect(vm)); >@@ -1651,7 +1652,6 @@ void JSGlobalObject::visitChildren(JSCell* cell, SlotVisitor& visitor) > visitor.append(thisObject->m_getterSetterStructure); > thisObject->m_nativeStdFunctionStructure.visit(visitor); > visitor.append(thisObject->m_bigIntObjectStructure); >- visitor.append(thisObject->m_symbolObjectStructure); > visitor.append(thisObject->m_regExpStructure); > visitor.append(thisObject->m_generatorFunctionStructure); > visitor.append(thisObject->m_asyncFunctionStructure); >diff --git a/Source/JavaScriptCore/runtime/JSGlobalObject.h b/Source/JavaScriptCore/runtime/JSGlobalObject.h >index de5467c679c8efe00851f92f2b9e4a2c5d4e732c..06e0093b2b5954eda651c14ddf2e319fa64636ba 100644 >--- a/Source/JavaScriptCore/runtime/JSGlobalObject.h >+++ b/Source/JavaScriptCore/runtime/JSGlobalObject.h >@@ -129,9 +129,6 @@ template<typename Watchpoint> class ObjectPropertyChangeAdaptiveWatchpoint; > > #define FOR_EACH_SIMPLE_BUILTIN_TYPE_WITH_CONSTRUCTOR(macro) \ > macro(String, string, stringObject, StringObject, String, object) \ >- macro(Symbol, symbol, symbolObject, SymbolObject, Symbol, object) \ >- macro(Number, number, numberObject, NumberObject, Number, object) \ >- macro(Boolean, boolean, booleanObject, BooleanObject, Boolean, object) \ > macro(Error, error, error, ErrorInstance, Error, object) \ > macro(Map, map, map, JSMap, Map, object) \ > macro(Set, set, set, JSSet, Set, object) \ >@@ -148,7 +145,10 @@ template<typename Watchpoint> class ObjectPropertyChangeAdaptiveWatchpoint; > macro(JSInternalPromise, internalPromise, internalPromise, JSInternalPromise, InternalPromise, object) \ > > #define FOR_EACH_LAZY_BUILTIN_TYPE(macro) \ >+ macro(Boolean, boolean, booleanObject, BooleanObject, Boolean, object) \ > macro(Date, date, date, DateInstance, Date, object) \ >+ macro(Number, number, numberObject, NumberObject, Number, object) \ >+ macro(Symbol, symbol, symbolObject, SymbolObject, Symbol, object) \ > DEFINE_STANDARD_BUILTIN(macro, WeakMap, weakMap) \ > DEFINE_STANDARD_BUILTIN(macro, WeakSet, weakSet) \ > >@@ -456,7 +456,11 @@ class JSGlobalObject : public JSSegmentedVariableObject { > InlineWatchpointSet& mapSetWatchpoint() { return m_mapSetWatchpoint; } > InlineWatchpointSet& setAddWatchpoint() { return m_setAddWatchpoint; } > InlineWatchpointSet& arraySpeciesWatchpoint() { return m_arraySpeciesWatchpoint; } >- InlineWatchpointSet& numberToStringWatchpoint() { return m_numberToStringWatchpoint; } >+ InlineWatchpointSet& numberToStringWatchpoint() >+ { >+ RELEASE_ASSERT(VM::canUseJIT()); >+ return m_numberToStringWatchpoint; >+ } > // If this hasn't been invalidated, it means the array iterator protocol > // is not observable to user code yet. > InlineWatchpointSet m_arrayIteratorProtocolWatchpoint; >@@ -618,12 +622,12 @@ class JSGlobalObject : public JSSegmentedVariableObject { > ObjectPrototype* objectPrototype() const { return m_objectPrototype.get(); } > FunctionPrototype* functionPrototype() const { return m_functionPrototype.get(); } > ArrayPrototype* arrayPrototype() const { return m_arrayPrototype.get(); } >- BooleanPrototype* booleanPrototype() const { return m_booleanPrototype.get(); } >+ JSObject* booleanPrototype() const { return m_booleanObjectStructure.prototype(this); } > StringPrototype* stringPrototype() const { return m_stringPrototype.get(); } >- SymbolPrototype* symbolPrototype() const { return m_symbolPrototype.get(); } >- NumberPrototype* numberPrototype() const { return m_numberPrototype.get(); } >+ JSObject* numberPrototype() const { return m_numberObjectStructure.prototype(this); } > BigIntPrototype* bigIntPrototype() const { return m_bigIntPrototype.get(); } > JSObject* datePrototype() const { return m_dateStructure.prototype(this); } >+ JSObject* symbolPrototype() const { return m_symbolObjectStructure.prototype(this); } > RegExpPrototype* regExpPrototype() const { return m_regExpPrototype.get(); } > ErrorPrototype* errorPrototype() const { return m_errorPrototype.get(); } > IteratorPrototype* iteratorPrototype() const { return m_iteratorPrototype.get(); } >@@ -671,7 +675,7 @@ class JSGlobalObject : public JSSegmentedVariableObject { > return originalArrayStructureForIndexingType(structure->indexingMode() | IsArray) == structure; > } > >- Structure* booleanObjectStructure() const { return m_booleanObjectStructure.get(); } >+ Structure* booleanObjectStructure() const { return m_booleanObjectStructure.get(this); } > Structure* callbackConstructorStructure() const { return m_callbackConstructorStructure.get(this); } > Structure* callbackFunctionStructure() const { return m_callbackFunctionStructure.get(this); } > Structure* callbackObjectStructure() const { return m_callbackObjectStructure.get(this); } >@@ -684,6 +688,7 @@ class JSGlobalObject : public JSSegmentedVariableObject { > Structure* glibWrapperObjectStructure() const { return m_glibWrapperObjectStructure.get(this); } > #endif > Structure* dateStructure() const { return m_dateStructure.get(this); } >+ Structure* symbolObjectStructure() const { return m_symbolObjectStructure.get(this); } > Structure* nullPrototypeObjectStructure() const { return m_nullPrototypeObjectStructure.get(); } > Structure* errorStructure() const { return m_errorStructure.get(); } > Structure* errorStructure(ErrorType errorType) const >@@ -734,14 +739,13 @@ class JSGlobalObject : public JSSegmentedVariableObject { > Structure* getterSetterStructure() const { return m_getterSetterStructure.get(); } > Structure* nativeStdFunctionStructure() const { return m_nativeStdFunctionStructure.get(this); } > PropertyOffset functionNameOffset() const { return m_functionNameOffset; } >- Structure* numberObjectStructure() const { return m_numberObjectStructure.get(); } >+ Structure* numberObjectStructure() const { return m_numberObjectStructure.get(this); } > Structure* mapStructure() const { return m_mapStructure.get(); } > Structure* regExpStructure() const { return m_regExpStructure.get(); } > Structure* generatorFunctionStructure() const { return m_generatorFunctionStructure.get(); } > Structure* asyncFunctionStructure() const { return m_asyncFunctionStructure.get(); } > Structure* asyncGeneratorFunctionStructure() const { return m_asyncGeneratorFunctionStructure.get(); } > Structure* stringObjectStructure() const { return m_stringObjectStructure.get(); } >- Structure* symbolObjectStructure() const { return m_symbolObjectStructure.get(); } > Structure* bigIntObjectStructure() const { return m_bigIntObjectStructure.get(); } > Structure* iteratorResultObjectStructure() const { return m_iteratorResultObjectStructure.get(); } > Structure* regExpMatchesArrayStructure() const { return m_regExpMatchesArrayStructure.get(); } >diff --git a/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js b/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js >index a686be479bda5ba9d58c59c3ed043311ff194e5e..77865f1340c110eb4eed37ea0b6650843e006243 100644 >--- a/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js >+++ b/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js >@@ -54,7 +54,7 @@ function privateInitializeReadableByteStreamController(stream, underlyingByteSou > let autoAllocateChunkSize = underlyingByteSource.autoAllocateChunkSize; > if (autoAllocateChunkSize !== @undefined) { > autoAllocateChunkSize = @toNumber(autoAllocateChunkSize); >- if (autoAllocateChunkSize <= 0 || autoAllocateChunkSize === @Number.POSITIVE_INFINITY || autoAllocateChunkSize === @Number.NEGATIVE_INFINITY) >+ if (autoAllocateChunkSize <= 0 || autoAllocateChunkSize === @Infinity || autoAllocateChunkSize === -@Infinity) > @throwRangeError("autoAllocateChunkSize value is negative or equal to positive or negative infinity"); > } > @putByIdDirectPrivate(this, "autoAllocateChunkSize", autoAllocateChunkSize); >@@ -381,7 +381,7 @@ function readableByteStreamControllerRespond(controller, bytesWritten) > > bytesWritten = @toNumber(bytesWritten); > >- if (@isNaN(bytesWritten) || bytesWritten === @Number.POSITIVE_INFINITY || bytesWritten < 0 ) >+ if (@isNaN(bytesWritten) || bytesWritten === @Infinity || bytesWritten < 0 ) > @throwRangeError("bytesWritten has an incorrect value"); > > @assert(@getByIdDirectPrivate(controller, "pendingPullIntos").length > 0);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=362170">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
saam
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194727
:
362167
| 362170