Attachment 362165 Details for Bug 194726 – Patch

[patch] Patch

bug-194726-20190215152118.patch (text/plain), 1.98 KB, created by Chris Dumez on 2019-02-15 15:21:19 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-02-15 15:21:19 PST

Size: 1.98 KB

patch

obsolete

>Subversion Revision: 241620
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ffcd4b2cc9b821d62a7a239cea4b2fb50bc3b548..2430a42b378a0de41953f85d495cfc228296a947 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-15  Chris Dumez  <cdumez@apple.com>
>+
>+        [PSON] Disable WebContent process cache on devices with less than 3GB of RAM
>+        https://bugs.webkit.org/show_bug.cgi?id=194726
>+        <rdar://problem/48126255>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/WebProcessCache.cpp:
>+        (WebKit::WebProcessCache::updateCapacity):
>+
> 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         [WTF] Add environment variable helpers
>diff --git a/Source/WebKit/UIProcess/WebProcessCache.cpp b/Source/WebKit/UIProcess/WebProcessCache.cpp
>index 756cb53197a048d4b42f6db9bc30e342c8805497..4f9845768f9927ce227046eece0ee719dbd76239 100644
>--- a/Source/WebKit/UIProcess/WebProcessCache.cpp
>+++ b/Source/WebKit/UIProcess/WebProcessCache.cpp
>@@ -104,10 +104,14 @@ void WebProcessCache::updateCapacity(WebProcessPool& processPool)
>         m_capacity = 0;
>     } else {
>         size_t memorySize = ramSize() / GB;
>-
>-        // Allow 4 processes in the cache per GB of RAM, up to 30 processes.
>-        m_capacity = std::min<unsigned>(memorySize * 4, 30);
>-        RELEASE_LOG(ProcessSwapping, "%p - WebProcessCache::updateCapacity: Cache has a capacity of %u processes", this, capacity());
>+        if (memorySize < 3) {
>+            m_capacity = 0;
>+            RELEASE_LOG(ProcessSwapping, "%p - WebProcessCache::updateCapacity: Cache is disabled because device does not have enough RAM", this);
>+        } else {
>+            // Allow 4 processes in the cache per GB of RAM, up to 30 processes.
>+            m_capacity = std::min<unsigned>(memorySize * 4, 30);
>+            RELEASE_LOG(ProcessSwapping, "%p - WebProcessCache::updateCapacity: Cache has a capacity of %u processes", this, capacity());
>+        }
>     }
> 
>     if (!m_capacity)

Actions: View | Formatted Diff | Diff

Attachments on bug 194726: 362165