Attachment 362162 Details for Bug 194642 – Patch for landing

[patch] Patch for landing

patch.txt (text/plain), 2.26 KB, created by Nikita Vasilyev on 2019-02-15 15:00:09 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-02-15 15:00:09 PST

Size: 2.26 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b83b1ec2c2a..894e868888c 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-15  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: remove unused parameter in _parseStylePropertyPayload
>+        https://bugs.webkit.org/show_bug.cgi?id=194642
>+
>+        Reviewed by Devin Rousso.
>+
>+        * UserInterface/Models/DOMNodeStyles.js:
>+        (WI.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
>+        The `styleText` parameter was never used
>+
> 2019-02-14  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r241497.
>diff --git a/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js b/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js
>index c7845078fbc..80b2bb8b2d3 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js
>@@ -506,7 +506,7 @@ WI.DOMNodeStyles = class DOMNodeStyles extends WI.Object
>         return new WI.TextRange(payload.startLine, payload.startColumn, payload.endLine, payload.endColumn);
>     }
> 
>-    _parseStylePropertyPayload(payload, index, styleDeclaration, styleText)
>+    _parseStylePropertyPayload(payload, index, styleDeclaration)
>     {
>         var text = payload.text || "";
>         var name = payload.name;
>@@ -639,8 +639,6 @@ WI.DOMNodeStyles = class DOMNodeStyles extends WI.Object
>             shorthands[shorthand.name] = shorthand.value;
>         }
> 
>-        var text = payload.cssText;
>-
>         var inheritedPropertyCount = 0;
> 
>         var properties = [];
>@@ -650,10 +648,11 @@ WI.DOMNodeStyles = class DOMNodeStyles extends WI.Object
>             if (inherited && WI.CSSProperty.isInheritedPropertyName(propertyPayload.name))
>                 ++inheritedPropertyCount;
> 
>-            var property = this._parseStylePropertyPayload(propertyPayload, i, styleDeclaration, text);
>+            let property = this._parseStylePropertyPayload(propertyPayload, i, styleDeclaration);
>             properties.push(property);
>         }
> 
>+        let text = payload.cssText;
>         var styleSheetTextRange = this._parseSourceRangePayload(payload.range);
> 
>         if (styleDeclaration) {

Actions: View | Formatted Diff | Diff

Attachments on bug 194642: 361996 | 362162