Attachment 362158 Details for Bug 194722 – Patch

[patch] Patch

bug-194722-20190215142606.patch (text/plain), 1.48 KB, created by Andy Estes on 2019-02-15 14:26:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Estes

Created: 2019-02-15 14:26:07 PST

Size: 1.48 KB

patch

obsolete

>Subversion Revision: 241615
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index fc4ab70c3dd2be3a6f4e18b6b6193529b6ce4115..0cafa548a708d7a6fbdd767da86e792c9c35b3eb 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-15  Andy Estes  <aestes@apple.com>
>+
>+        [iOS] Stop setting a background color on the PDF host view
>+        https://bugs.webkit.org/show_bug.cgi?id=194722
>+        <rdar://48124152>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        PDFKit already sets a background color on this view, so thereâs no need (and some harm) in
>+        us doing it too.
>+
>+        * UIProcess/ios/WKPDFView.mm:
>+        (-[WKPDFView web_setContentProviderData:suggestedFilename:]):
>+
> 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] WKWebView callout bar is missing Change Writing Direction item
>diff --git a/Source/WebKit/UIProcess/ios/WKPDFView.mm b/Source/WebKit/UIProcess/ios/WKPDFView.mm
>index 1d525764b3f7b6e4074c34ca8ad6c8ba306aad31..af2acb50c17f23151c1f307f82e7e85b628a4dca 100644
>--- a/Source/WebKit/UIProcess/ios/WKPDFView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKPDFView.mm
>@@ -143,7 +143,6 @@ - (void)web_setContentProviderData:(NSData *)data suggestedFilename:(NSString *)
> 
>         UIView *hostView = hostViewController.view;
>         hostView.frame = webView.bounds;
>-        hostView.backgroundColor = UIColor.grayColor;
> 
>         UIScrollView *scrollView = webView.scrollView;
>         [self removeFromSuperview];

Actions: View | Formatted Diff | Diff

Attachments on bug 194722: 362158