Attachment 362117 Details for Bug 194537 – Patch

[patch] Patch

bug-194537-20190215164817.patch (text/plain), 1.71 KB, created by Philippe Normand on 2019-02-15 08:48:19 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Normand

Created: 2019-02-15 08:48:19 PST

Size: 1.71 KB

patch

obsolete

>Subversion Revision: 241585
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 95b331f59db3e6582376dd501e10436610883685..4c6821a43941a94a7aef2ed6f899e0aba9393420 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-15  Philippe Normand  <pnormand@igalia.com>
>+
>+        [GStreamer] Simplify GObject class name check
>+        https://bugs.webkit.org/show_bug.cgi?id=194537
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback):
>+        Use G_OBJECT_TYPE_NAME() to filter out uridecodebin child
>+        elements.
>+
> 2019-02-15  Philippe Normand  <pnormand@igalia.com>
> 
>         [GStreamer] Decoding media-capabilities configuration initial support
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index f7819d41b648e2bfce39ab02397fa7c5a386daf5..8c67d6816f91b8c805cc50a13eec363ccf86cd3b 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -1753,7 +1753,7 @@ void MediaPlayerPrivateGStreamer::sourceSetupCallback(MediaPlayerPrivateGStreame
> 
> void MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback(GstBin* bin, GstElement* element, MediaPlayerPrivateGStreamer* player)
> {
>-    if (g_strcmp0(G_OBJECT_CLASS_NAME(G_OBJECT_GET_CLASS(G_OBJECT(element))), "GstDownloadBuffer"))
>+    if (g_strcmp0(G_OBJECT_TYPE_NAME(element), "GstDownloadBuffer"))
>         return;
> 
>     player->m_downloadBuffer = element;

Actions: View | Formatted Diff | Diff

Attachments on bug 194537: 362117