WebKit Bugzilla
Attachment 362103 Details for
Bug 194694
: [bmalloc] NSBundle-based application name check should be executed after debug-heap environment variable check
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194694-20190215004853.patch (text/plain), 1.97 KB, created by
Yusuke Suzuki
on 2019-02-15 00:48:54 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yusuke Suzuki
Created:
2019-02-15 00:48:54 PST
Size:
1.97 KB
patch
obsolete
>Subversion Revision: 241577 >diff --git a/Source/bmalloc/ChangeLog b/Source/bmalloc/ChangeLog >index 88b98ed3685390074762a189fa2fc4e1d43819d4..7cc840f2895a8a2266faa7c3b7b6f8324dcd4473 100644 >--- a/Source/bmalloc/ChangeLog >+++ b/Source/bmalloc/ChangeLog >@@ -1,3 +1,18 @@ >+2019-02-15 Yusuke Suzuki <ysuzuki@apple.com> >+ >+ [bmalloc] NSBundle-based application name check should be executed after debug-heap environment variable check >+ https://bugs.webkit.org/show_bug.cgi?id=194694 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Interestingly, NSBundle allocates fair amount of memory and keeps it for a process-long time. For example, it >+ allocates global NSConcreteHashTable, which takes 2.5KB. This patch changes the order of gigacage-check, we >+ first check "Malloc=1" status, and then check the process name through NSBundle. This allows us to remove NSBundle >+ related allocation in JSC initialization in the system malloc mode. >+ >+ * bmalloc/Gigacage.cpp: >+ (Gigacage::shouldBeEnabled): >+ > 2019-02-12 Commit Queue <commit-queue@webkit.org> > > Unreviewed, rolling out r241182. >diff --git a/Source/bmalloc/bmalloc/Gigacage.cpp b/Source/bmalloc/bmalloc/Gigacage.cpp >index bd18082e67d142ebc5c0f0a9566a87acf610cac5..53a8302b30ad7800847d817b163d487fb663ed90 100644 >--- a/Source/bmalloc/bmalloc/Gigacage.cpp >+++ b/Source/bmalloc/bmalloc/Gigacage.cpp >@@ -267,12 +267,12 @@ bool shouldBeEnabled() > std::call_once( > onceFlag, > [] { >- if (!gigacageEnabledForProcess()) >- return; >- > bool result = !PerProcess<Environment>::get()->isDebugHeapEnabled(); > if (!result) > return; >+ >+ if (!gigacageEnabledForProcess()) >+ return; > > if (char* gigacageEnabled = getenv("GIGACAGE_ENABLED")) { > if (!strcasecmp(gigacageEnabled, "no") || !strcasecmp(gigacageEnabled, "false") || !strcasecmp(gigacageEnabled, "0")) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
mark.lam
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194694
: 362103