Attachment 362099 Details for Bug 194674 – Patch

[patch] Patch

bug-194674-20190214231042.patch (text/plain), 1.63 KB, created by Yusuke Suzuki on 2019-02-14 23:10:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-02-14 23:10:43 PST

Size: 1.63 KB

patch

obsolete

>Subversion Revision: 241574
>diff --git a/Source/bmalloc/ChangeLog b/Source/bmalloc/ChangeLog
>index 88b98ed3685390074762a189fa2fc4e1d43819d4..efe83dbc8be658beb8f12b7ae0579902c91cfaf0 100644
>--- a/Source/bmalloc/ChangeLog
>+++ b/Source/bmalloc/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [bmalloc] Do not start scavenger thread if we use system malloc
>+        https://bugs.webkit.org/show_bug.cgi?id=194674
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We always start the scavenger thread even if system malloc is used by the environment variable like "Malloc=1".
>+        Because bmalloc allocation goes to the system malloc if "Malloc=1" is set, we do not need to scavenge. This patch
>+        changes it not to start the scavenger thread.
>+
>+        * bmalloc/Scavenger.cpp:
>+        (bmalloc::Scavenger::Scavenger):
>+
> 2019-02-12  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r241182.
>diff --git a/Source/bmalloc/bmalloc/Scavenger.cpp b/Source/bmalloc/bmalloc/Scavenger.cpp
>index edb014de9b2fcbcae545cc7b9afc41d7bf3ac3f2..ca3362657bfa01f1090f91ac81eae14a13fabce1 100644
>--- a/Source/bmalloc/bmalloc/Scavenger.cpp
>+++ b/Source/bmalloc/bmalloc/Scavenger.cpp
>@@ -67,6 +67,9 @@ struct PrintTime {
> 
> Scavenger::Scavenger(std::lock_guard<Mutex>&)
> {
>+    if (PerProcess<Environment>::get()->isDebugHeapEnabled())
>+        return;
>+
> #if BOS(DARWIN)
>     auto queue = dispatch_queue_create("WebKit Malloc Memory Pressure Handler", DISPATCH_QUEUE_SERIAL);
>     m_pressureHandlerDispatchSource = dispatch_source_create(DISPATCH_SOURCE_TYPE_MEMORYPRESSURE, 0, DISPATCH_MEMORYPRESSURE_CRITICAL, queue);

Actions: View | Formatted Diff | Diff

Attachments on bug 194674: 362099