Attachment 362092 Details for Bug 194687 – Patch

[patch] Patch

bug-194687-20190214192419.patch (text/plain), 3.81 KB, created by Devin Rousso on 2019-02-14 19:24:19 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-02-14 19:24:19 PST

Size: 3.81 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b83b1ec2c2ac4a06e916f9ec40fdab297c826fa8..3de7549d016ae67255f50f3a8ee28d8fb7be14d3 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-02-14  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Canvas: recordings with a single frame sometimes missing TreeElement
>+        https://bugs.webkit.org/show_bug.cgi?id=194687
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/CanvasSidebarPanel.js:
>+        (WI.CanvasSidebarPanel):
>+        Wait until the entire `Recording` has been processed before setting the selected action.
>+
>+        * UserInterface/Views/CanvasSidebarPanel.css:
>+        (.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):
>+        Drive-by: ensure that the recording `TreeOutline` container element has the full height to
>+        take advantage of for virtualization.
>+
>+        * UserInterface/Views/RecordingStateDetailsSidebarPanel.js:
>+        (WI.RecordingStateDetailsSidebarPanel.prototype.set recording):
>+        Drive-by: clear the `DataGrid` list when changing recordings since we removed all subviews.
>+
> 2019-02-14  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r241497.
>diff --git a/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css b/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css
>index e6c137673789a4b892b2ca66b808afbf1e942eb3..e30da033180ea0d264eec0edacf076835d60d670 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css
>@@ -48,6 +48,7 @@
> }
> 
> .sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content {
>+    flex-grow: 1;
>     overflow-y: scroll;
> }
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js
>index b5cc3522151f6330a864b036840620ca9b182cd5..28c4a33673f460b6a873c38818216835d077f197 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js
>@@ -578,8 +578,8 @@ WI.CanvasSidebarPanel = class CanvasSidebarPanel extends WI.NavigationSidebarPan
>         console.assert(isInitialStateAction || this._recordingTreeOutline.children.lastValue instanceof WI.FolderTreeElement, "There should be a WI.FolderTreeElement for the frame for this action.");
>         this._createRecordingActionTreeElement(action, index, isInitialStateAction ? this._recordingTreeOutline : this._recordingTreeOutline.children.lastValue);
> 
>-        if (isInitialStateAction && !this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol])
>-            this.action = action;
>+        if (this._recording.ready && !this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol])
>+            this.action = this._recording.actions[0];
> 
>         if (action === this._recording.actions.lastValue && this._recordingProcessingOptionsContainer) {
>             this._recordingProcessingOptionsContainer.remove();
>diff --git a/Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js
>index 1f6d36b2ba40ba8217dbf3cf9ec5ebe2ff31348c..89da3e8f62b9663fb066e17b2f310407692dcff1 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js
>@@ -58,6 +58,8 @@ WI.RecordingStateDetailsSidebarPanel = class RecordingStateDetailsSidebarPanel e
> 
>         for (let subview of this.contentView.subviews)
>             this.contentView.removeSubview(subview);
>+
>+        this._dataGrids = [];
>     }
> 
>     set action(action)

Actions: View | Formatted Diff | Diff

Attachments on bug 194687: 362092