Attachment 362091 Details for Bug 194689 – Patch

[patch] Patch

bug-194689-20190214185412.patch (text/plain), 1.65 KB, created by youenn fablet on 2019-02-14 18:54:13 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-02-14 18:54:13 PST

Size: 1.65 KB

patch

obsolete

>Subversion Revision: 241548
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 19d31f6ee29da5ee8f667dd084ceea2741a1d176..b797776e2a515e5ff06935965ba4de4e91d15a8f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-02-14  Youenn Fablet  <youenn@apple.com>
>+
>+        Performance should not fire events when its context is stopped
>+        https://bugs.webkit.org/show_bug.cgi?id=194689
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Stop the timer when its context is destroyed.
>+        Add an assertion to ensure the timer does not fire after context is destroyed.
>+
>+        * page/Performance.cpp:
>+        (WebCore::Performance::stop):
>+
> 2019-02-14  Youenn Fablet  <youenn@apple.com>
> 
>         Stop the endpoint synchronously in RTCPeerConnection::close
>diff --git a/Source/WebCore/page/Performance.cpp b/Source/WebCore/page/Performance.cpp
>index d51b26d880ec895d7d699edfbcaba2e65a8465a5..eeb61abf26500cf5d0ce521228b595c14040b73c 100644
>--- a/Source/WebCore/page/Performance.cpp
>+++ b/Source/WebCore/page/Performance.cpp
>@@ -64,7 +64,7 @@ Performance::~Performance() = default;
> void Performance::contextDestroyed()
> {
>     m_performanceTimelineTaskQueue.close();
>-
>+    m_resourceTimingBufferFullTimer.stop();
>     ContextDestructionObserver::contextDestroyed();
> }
> 
>@@ -211,6 +211,8 @@ bool Performance::isResourceTimingBufferFull() const
> 
> void Performance::resourceTimingBufferFullTimerFired()
> {
>+    ASSERT(scriptExecutionContext());
>+
>     while (!m_backupResourceTimingBuffer.isEmpty()) {
>         auto backupBuffer = WTFMove(m_backupResourceTimingBuffer);
>         ASSERT(m_backupResourceTimingBuffer.isEmpty());

Actions: View | Formatted Diff | Diff

Attachments on bug 194689: 362091