Attachment 362090 Details for Bug 194688 – Patch

[patch] Patch

bug-194688-20190214183842.patch (text/plain), 1.63 KB, created by youenn fablet on 2019-02-14 18:38:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-02-14 18:38:43 PST

Size: 1.63 KB

patch

obsolete

>Subversion Revision: 241548
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b2f91d753f9ab0b191a90b5310fe8f9a89f0333b..19d31f6ee29da5ee8f667dd084ceea2741a1d176 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-14  Youenn Fablet  <youenn@apple.com>
>+
>+        Stop the endpoint synchronously in RTCPeerConnection::close
>+        https://bugs.webkit.org/show_bug.cgi?id=194688
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In the case where the peer connection is being closed, it was asynchronously stopping the endpoint.
>+        But the endpoint, before being stopped, could try to fire an event.
>+        If the context is gone in between, we end up with a null pointer dereference.
>+
>+        * Modules/mediastream/RTCPeerConnection.cpp:
>+        (WebCore::RTCPeerConnection::close):
>+
> 2019-02-14  Youenn Fablet  <youenn@apple.com>
> 
>         Make ServiceWorkerClientFetch closer to WebResourceLoader
>diff --git a/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp b/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
>index 338dc1a9a40d8124da68bd40ead4e9039a4e723e..fd58e0fdbd096f4b30c115363edd8b40af300bb4 100644
>--- a/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
>+++ b/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
>@@ -437,9 +437,7 @@ void RTCPeerConnection::close()
> 
>     updateConnectionState();
>     ASSERT(isClosed());
>-    scriptExecutionContext()->postTask([protectedThis = makeRef(*this)](ScriptExecutionContext&) {
>-        protectedThis->doStop();
>-    });
>+    doStop();
> }
> 
> void RTCPeerConnection::emulatePlatformEvent(const String& action)

Actions: View | Formatted Diff | Diff

Attachments on bug 194688: 362090