Attachment 362083 Details for Bug 194684 – Patch

[patch] Patch

bug-194684-20190214171634.patch (text/plain), 1.76 KB, created by Devin Rousso on 2019-02-14 17:16:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-02-14 17:16:34 PST

Size: 1.76 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 0f674693d8e97a346bc7be1fce2a5748bc879b77..ec597ad5bca591e2a52346ad6089fb1f11ab2773 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-02-14  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Canvas: all actions after an offscreen path modification are marked as offscreen path errors
>+        https://bugs.webkit.org/show_bug.cgi?id=194684
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Models/RecordingAction.js:
>+        (WI.RecordingAction.prototype.process):
>+
> 2019-02-13  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: valid values in style attributes are reported as unsupported property values
>diff --git a/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js b/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js
>index 5d08f7052d49ca9cae65f6ce4ad46957801b9477..508b9cc35edf587bbf0c0dfb6e51ffce4836ff8a 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js
>@@ -251,9 +251,9 @@ WI.RecordingAction = class RecordingAction extends WI.Object
> 
>             let lastState = null;
>             if (lastAction) {
>-                let previousState = lastAction.states.lastValue;
>+                lastState = lastAction.states.lastValue;
>                 for (let [name, value] of currentState) {
>-                    let previousValue = previousState.get(name);
>+                    let previousValue = lastState.get(name);
>                     if (value !== previousValue && !Object.shallowEqual(value, previousValue))
>                         this._stateModifiers.add(name);
>                 }

Actions: View | Formatted Diff | Diff

Attachments on bug 194684: 362083