WebKit Bugzilla
Attachment 362054 Details for
Bug 194599
: [ews-app] status bubble should fetch builder name info from BuilderMapping table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
status-bubble-display-name.patch (text/plain), 1.90 KB, created by
Aakash Jain
on 2019-02-14 13:23:17 PST
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Aakash Jain
Created:
2019-02-14 13:23:17 PST
Size:
1.90 KB
patch
obsolete
>Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 241559) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2019-02-14 Aakash Jain <aakash_jain@apple.com> >+ >+ [ews-app] status bubble should fetch builder name info from BuilderMapping table >+ https://bugs.webkit.org/show_bug.cgi?id=194599 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: >+ (StatusBubble._build_bubble): >+ > 2019-02-14 Ross Kirsling <ross.kirsling@sony.com> > > [WTF] Add environment variable helpers >Index: Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py >=================================================================== >--- Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (revision 241559) >+++ Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (working copy) >@@ -26,14 +26,19 @@ from django.http import HttpResponse > from django.shortcuts import render > from django.views import View > from django.views.decorators.clickjacking import xframe_options_exempt >+from ews.models.buildermapping import BuilderMapping > from ews.models.patch import Patch > import ews.config as config > > > class StatusBubble(View): > def _build_bubble(self, build, patch): >- builder_display_name = build.builder_id # TODO: fetch display name from buildermapping table https://bugs.webkit.org/show_bug.cgi?id=194599 >- builder_full_name = build.builder_id # TODO: fetch builder full name from buildermapping table https://bugs.webkit.org/show_bug.cgi?id=194599 >+ try: >+ builder_display_name = build.builder.display_name >+ builder_full_name = build.builder.builder_name >+ except BuilderMapping.DoesNotExist: >+ builder_display_name = build.builder_id >+ builder_full_name = '' > > bubble = { > "name": builder_display_name,
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194599
: 362054