Attachment 362043 Details for Bug 190138 – patch

[patch] patch

patch (text/plain), 5.75 KB, created by chris fleizach on 2019-02-14 11:49:48 PST

(hide)

Description:

Filename:

MIME Type:

Creator: chris fleizach

Created: 2019-02-14 11:49:48 PST

Size: 5.75 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 241557)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2019-02-14  Chris Fleizach  <cfleizach@apple.com>
>+
>+        AX: <footer> HTML5 tag not reading as ARIA Landmark to VoiceOver
>+        https://bugs.webkit.org/show_bug.cgi?id=190138
>+        <rdar://problem/44907695>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make sure the footer element is not ignored; that is it is considered a landmark for search purposes; and
>+        that it has a computedRole value.
>+
>+        * accessibility/AccessibilityObject.cpp:
>+        (WebCore::AccessibilityObject::isLandmark const):
>+        (WebCore::AccessibilityObject::computedRoleString const):
>+        * accessibility/AccessibilityRenderObject.cpp:
>+        (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):
>+
> 2019-02-14  Chris Dumez  <cdumez@apple.com>
> 
>         [PSON] Introduce a WebContent Process cache
>Index: Source/WebCore/accessibility/AccessibilityObject.cpp
>===================================================================
>--- Source/WebCore/accessibility/AccessibilityObject.cpp	(revision 241557)
>+++ Source/WebCore/accessibility/AccessibilityObject.cpp	(working copy)
>@@ -408,16 +408,20 @@
> 
> bool AccessibilityObject::isLandmark() const
> {
>-    AccessibilityRole role = roleValue();
>-    
>-    return role == AccessibilityRole::LandmarkBanner
>-        || role == AccessibilityRole::LandmarkComplementary
>-        || role == AccessibilityRole::LandmarkContentInfo
>-        || role == AccessibilityRole::LandmarkDocRegion
>-        || role == AccessibilityRole::LandmarkMain
>-        || role == AccessibilityRole::LandmarkNavigation
>-        || role == AccessibilityRole::LandmarkRegion
>-        || role == AccessibilityRole::LandmarkSearch;
>+    switch (roleValue()) {
>+    case AccessibilityRole::Footer:
>+    case AccessibilityRole::LandmarkBanner:
>+    case AccessibilityRole::LandmarkComplementary:
>+    case AccessibilityRole::LandmarkContentInfo:
>+    case AccessibilityRole::LandmarkDocRegion:
>+    case AccessibilityRole::LandmarkMain:
>+    case AccessibilityRole::LandmarkNavigation:
>+    case AccessibilityRole::LandmarkRegion:
>+    case AccessibilityRole::LandmarkSearch:
>+        return true;
>+    default:
>+        return false;
>+    }
> }
> 
> bool AccessibilityObject::hasMisspelling() const
>@@ -2508,6 +2512,9 @@
>     if (role == AccessibilityRole::PopUpButton || role == AccessibilityRole::ToggleButton)
>         return reverseAriaRoleMap().get(static_cast<int>(AccessibilityRole::Button));
> 
>+    if (role == AccessibilityRole::Footer)
>+        return reverseAriaRoleMap().get(static_cast<int>(AccessibilityRole::LandmarkContentInfo));
>+
>     if (role == AccessibilityRole::LandmarkDocRegion)
>         return reverseAriaRoleMap().get(static_cast<int>(AccessibilityRole::LandmarkRegion));
> 
>Index: Source/WebCore/accessibility/AccessibilityRenderObject.cpp
>===================================================================
>--- Source/WebCore/accessibility/AccessibilityRenderObject.cpp	(revision 241557)
>+++ Source/WebCore/accessibility/AccessibilityRenderObject.cpp	(working copy)
>@@ -1273,6 +1273,7 @@
>     case AccessibilityRole::DescriptionListDetail:
>     case AccessibilityRole::Details:
>     case AccessibilityRole::DocumentArticle:
>+    case AccessibilityRole::Footer:
>     case AccessibilityRole::LandmarkRegion:
>     case AccessibilityRole::ListItem:
>     case AccessibilityRole::Time:
>Index: LayoutTests/accessibility/roles-computedRoleString-expected.txt
>===================================================================
>--- LayoutTests/accessibility/roles-computedRoleString-expected.txt	(revision 241331)
>+++ LayoutTests/accessibility/roles-computedRoleString-expected.txt	(working copy)
>@@ -9,7 +9,7 @@
> PASS: button -> button. 
> PASS: dfn -> definition. 
> PASS: dl -> . 
>-PASS: footer -> . 
>+PASS: footer -> contentinfo. 
> PASS: form -> form. 
> PASS: header -> banner. 
> PASS: h1 -> heading. 
>Index: LayoutTests/accessibility/roles-computedRoleString.html
>===================================================================
>--- LayoutTests/accessibility/roles-computedRoleString.html	(revision 241331)
>+++ LayoutTests/accessibility/roles-computedRoleString.html	(working copy)
>@@ -17,7 +17,7 @@
>     <dt>X</dt>
>     <dd>X</dd>
> </dl>
>-<footer data-role="" data-platform="atk,mac" class="ex">X</footer>
>+<footer data-role="contentinfo" data-platform="atk,mac" class="ex">X</footer>
> <form data-role="form" data-platform="atk,mac" class="ex">X</form>
> <header data-role="banner" data-platform="atk,mac" class="ex">X</header>
> <h1 data-role="heading" data-platform="atk,mac" class="ex">X</h1>
>Index: LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt
>===================================================================
>--- LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt	(revision 241331)
>+++ LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt	(working copy)
>@@ -9,7 +9,7 @@
> PASS: button -> button. 
> PASS: dfn -> definition. 
> PASS: dl -> . 
>-PASS: footer -> . 
>+PASS: footer -> contentinfo. 
> PASS: form -> form. 
> PASS: header -> banner. 
> PASS: h1 -> heading. 
>Index: LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
>===================================================================
>--- LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt	(revision 241331)
>+++ LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt	(working copy)
>@@ -9,7 +9,7 @@
> PASS: button -> button. 
> PASS: dfn -> definition. 
> PASS: dl -> . 
>-PASS: footer -> . 
>+PASS: footer -> contentinfo. 
> PASS: form -> form. 
> PASS: header -> banner. 
> PASS: h1 -> heading.

Actions: View | Formatted Diff | Diff

Attachments on bug 190138: 351243 | 362043 | 362827 | 362828 | 362830 | 362831 | 362886