Attachment 362042 Details for Bug 194660 – Patch

[patch] Patch

bug-194660-20190214113055.patch (text/plain), 2.94 KB, created by Devin Rousso on 2019-02-14 11:30:56 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-02-14 11:30:56 PST

Size: 2.94 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 0f674693d8e97a346bc7be1fce2a5748bc879b77..da95010e52f25d4a529d3935b890d00e44e76632 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-02-14  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Console: dragging a selection outside the selected element clears the selection
>+        https://bugs.webkit.org/show_bug.cgi?id=194660
>+        <rdar://problem/46719239>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/LogContentView.js:
>+        (WI.LogContentView.prototype._mousemove):
>+        Don't clear the selection if the target of the "mousemove" is outside of the view.
>+
>+        (WI.LogContentView.prototype._updateMessagesSelection):
>+        Drive-by: clear the saved selected messages when we're just selecting a single message.
>+
> 2019-02-13  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: valid values in style attributes are reported as unsupported property values
>diff --git a/Source/WebInspectorUI/UserInterface/Views/LogContentView.js b/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
>index 1caca5c4d30bf9d153310511e3f56499503ace0a..0ab8aa0dd458332a3632b03d3e28f4acff0bfc58 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
>@@ -520,13 +520,13 @@ WI.LogContentView = class LogContentView extends WI.ContentView
> 
>         if (!wrapper) {
>             // No wrapper under the mouse, so look at the selection to try and find one.
>-            if (!selection.isCollapsed) {
>-                wrapper = selection.focusNode.parentNode.enclosingNodeOrSelfWithClass(WI.LogContentView.ItemWrapperStyleClassName);
>-                selection.removeAllRanges();
>-            }
>+            if (!selection.isCollapsed)
>+                wrapper = selection.focusNode.enclosingNodeOrSelfWithClass(WI.LogContentView.ItemWrapperStyleClassName);
> 
>-            if (!wrapper)
>+            if (!wrapper) {
>+                selection.removeAllRanges();
>                 return;
>+            }
>         }
> 
>         if (!selection.isCollapsed)
>@@ -535,6 +535,10 @@ WI.LogContentView = class LogContentView extends WI.ContentView
>         if (wrapper === this._mouseDownWrapper && !this._mouseMoveIsRowSelection)
>             return;
> 
>+        // Don't change the selection if the mouse has moved outside of the view (e.g. for faster scrolling).
>+        if (!this.element.contains(event.target))
>+            return;
>+
>         selection.removeAllRanges();
> 
>         if (!this._mouseMoveIsRowSelection)
>@@ -645,6 +649,7 @@ WI.LogContentView = class LogContentView extends WI.ContentView
>         } else {
>             message.classList.add(WI.LogContentView.SelectedStyleClassName);
>             this._selectedMessages.push(message);
>+            this._selectionRange = null;
>         }
> 
>         if (!rangeSelection)

Actions: View | Formatted Diff | Diff

Attachments on bug 194660: 362042