WebKit Bugzilla
Attachment 362033 Details for
Bug 194657
: Sample domainsVisited diagnostic logging
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194657-20190214103226.patch (text/plain), 1.62 KB, created by
Chris Dumez
on 2019-02-14 10:32:27 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Chris Dumez
Created:
2019-02-14 10:32:27 PST
Size:
1.62 KB
patch
obsolete
>Subversion Revision: 241548 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index bf6eae5e7dce1e2155255f19f0493f07ab3cccfa..355397538fc80cc68c8a0634be4c3f60baa51da8 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2019-02-14 Chris Dumez <cdumez@apple.com> >+ >+ Sample domainsVisited diagnostic logging >+ https://bugs.webkit.org/show_bug.cgi?id=194657 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Sample domainsVisited diagnostic logging, we are getting a lot of data from >+ this key and this is hurting our other keys. >+ >+ * page/Page.cpp: >+ (WebCore::Page::logNavigation): >+ > 2019-02-14 Commit Queue <commit-queue@webkit.org> > > Unreviewed, rolling out r241486. >diff --git a/Source/WebCore/page/Page.cpp b/Source/WebCore/page/Page.cpp >index 690735d4f0cb20c702b2b7b47d48bb2a322e9276..b02688a4a847d56e0074099177b4da503d754288 100644 >--- a/Source/WebCore/page/Page.cpp >+++ b/Source/WebCore/page/Page.cpp >@@ -2369,7 +2369,7 @@ void Page::logNavigation(const Navigation& navigation) > diagnosticLoggingClient().logDiagnosticMessage(DiagnosticLoggingKeys::navigationKey(), navigationDescription, ShouldSample::No); > > if (!navigation.domain.isEmpty()) >- diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::No); >+ diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::Yes); > } > > void Page::mainFrameLoadStarted(const URL& destinationURL, FrameLoadType type)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194657
: 362033