Attachment 362016 Details for Bug 194647 – Landing patch

[patch] Landing patch

patch (text/plain), 2.36 KB, created by chris fleizach on 2019-02-14 08:05:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: chris fleizach

Created: 2019-02-14 08:05:45 PST

Size: 2.36 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 241331)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-02-14  Chris Fleizach  <cfleizach@apple.com>
>+
>+        AX: ARIA Reflection was disabled in error
>+        https://bugs.webkit.org/show_bug.cgi?id=194647
>+        <rdar://problem/48068336>
>+
>+        Reviewed by Ryosuke Niwa.
>+
>+        * Shared/WebPreferences.yaml:
>+
> 2019-02-12  Alex Christensen  <achristensen@webkit.org>
> 
>         Remove firing assertion after r241317
>Index: Source/WebKit/Shared/WebPreferences.yaml
>===================================================================
>--- Source/WebKit/Shared/WebPreferences.yaml	(revision 241331)
>+++ Source/WebKit/Shared/WebPreferences.yaml	(working copy)
>@@ -1435,7 +1435,7 @@
> 
> AriaReflectionEnabled:
>   type: bool
>-  defaultValue: false
>+  defaultValue: true
>   humanReadableName: "ARIA Reflection"
>   humanReadableDescription: "ARIA Reflection support"
>   category: internal
>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 241544)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-02-14  Chris Fleizach  <cfleizach@apple.com>
>+
>+        AX: ARIA Reflection was disabled in error
>+        https://bugs.webkit.org/show_bug.cgi?id=194647
>+        <rdar://problem/48068336>
>+
>+        Reviewed by Ryosuke Niwa.
>+
>+        Remove test override now that this feature should be enabled by default.
>+
>+        * WebKitTestRunner/TestController.cpp:
>+        (WTR::TestController::resetPreferencesToConsistentValues):
>+
> 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
>Index: Tools/WebKitTestRunner/TestController.cpp
>===================================================================
>--- Tools/WebKitTestRunner/TestController.cpp	(revision 241331)
>+++ Tools/WebKitTestRunner/TestController.cpp	(working copy)
>@@ -827,7 +827,6 @@
>     WKPreferencesSetStorageAccessAPIEnabled(preferences, true);
>     
>     WKPreferencesSetAccessibilityObjectModelEnabled(preferences, true);
>-    WKPreferencesSetAriaReflectionEnabled(preferences, true);
>     WKPreferencesSetCSSOMViewScrollingAPIEnabled(preferences, true);
>     WKPreferencesSetMediaCapabilitiesEnabled(preferences, true);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194647: 362005 | 362016