WebKit Bugzilla
Attachment 361996 Details for
Bug 194642
: Web Inspector: remove unused parameter in _parseStylePropertyPayload
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
patch.txt (text/plain), 2.33 KB, created by
Nikita Vasilyev
on 2019-02-13 22:00:02 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Nikita Vasilyev
Created:
2019-02-13 22:00:02 PST
Size:
2.33 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 510afe4c686..09f490745d7 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,14 @@ >+2019-02-13 Nikita Vasilyev <nvasilyev@apple.com> >+ >+ Web Inspector: remove unused parameter in _parseStylePropertyPayload >+ https://bugs.webkit.org/show_bug.cgi?id=194642 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Models/DOMNodeStyles.js: >+ (WI.DOMNodeStyles.prototype._parseStyleDeclarationPayload): >+ `styleText` wasn't used by this method. >+ > 2019-02-13 Nikita Vasilyev <nvasilyev@apple.com> > > Web Inspector: Styles: valid values in style attributes are reported as unsupported property values >diff --git a/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js b/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js >index a199be0310b..0259a16cfc2 100644 >--- a/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js >+++ b/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js >@@ -506,7 +506,7 @@ WI.DOMNodeStyles = class DOMNodeStyles extends WI.Object > return new WI.TextRange(payload.startLine, payload.startColumn, payload.endLine, payload.endColumn); > } > >- _parseStylePropertyPayload(payload, index, styleDeclaration, styleText) >+ _parseStylePropertyPayload(payload, index, styleDeclaration) > { > var text = payload.text || ""; > var name = payload.name; >@@ -653,8 +653,6 @@ WI.DOMNodeStyles = class DOMNodeStyles extends WI.Object > shorthands[shorthand.name] = shorthand.value; > } > >- var text = payload.cssText; >- > var inheritedPropertyCount = 0; > > var properties = []; >@@ -664,10 +662,11 @@ WI.DOMNodeStyles = class DOMNodeStyles extends WI.Object > if (inherited && WI.CSSProperty.isInheritedPropertyName(propertyPayload.name)) > ++inheritedPropertyCount; > >- var property = this._parseStylePropertyPayload(propertyPayload, i, styleDeclaration, text); >+ var property = this._parseStylePropertyPayload(propertyPayload, i, styleDeclaration); > properties.push(property); > } > >+ var text = payload.cssText; > var styleSheetTextRange = this._parseSourceRangePayload(payload.range); > > if (styleDeclaration) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
hi
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194642
:
361996
|
362162