WebKit Bugzilla
Attachment 361969 Details for
Bug 194627
: AX: Crash in handleMenuOpen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
patch (text/plain), 1.70 KB, created by
chris fleizach
on 2019-02-13 17:03:12 PST
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
chris fleizach
Created:
2019-02-13 17:03:12 PST
Size:
1.70 KB
patch
obsolete
>Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 241488) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,18 @@ >+2019-02-13 Chris Fleizach <cfleizach@apple.com> >+ >+ AX: Crash in handleMenuOpen >+ https://bugs.webkit.org/show_bug.cgi?id=194627 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Tests run under libGuardMalloc will cause crashes. >+ >+ This list of objects is a Node list, not an Element list, so we were >+ not removing some nodes when they were being deallocated. >+ >+ * accessibility/AXObjectCache.cpp: >+ (WebCore::AXObjectCache::remove): >+ > 2019-02-13 Eric Carlson <eric.carlson@apple.com> > > [iOS] Add a hack to work around buggy video control library >Index: Source/WebCore/accessibility/AXObjectCache.cpp >=================================================================== >--- Source/WebCore/accessibility/AXObjectCache.cpp (revision 241331) >+++ Source/WebCore/accessibility/AXObjectCache.cpp (working copy) >@@ -747,10 +747,10 @@ > if (is<Element>(node)) { > m_deferredRecomputeIsIgnoredList.remove(downcast<Element>(&node)); > m_deferredSelectedChildredChangedList.remove(downcast<Element>(&node)); >- m_deferredChildrenChangedNodeList.remove(&node); > m_deferredTextFormControlValue.remove(downcast<Element>(&node)); > m_deferredAttributeChange.remove(downcast<Element>(&node)); > } >+ m_deferredChildrenChangedNodeList.remove(&node); > m_deferredTextChangedList.remove(&node); > // Remove the entry if the new focused node is being removed. > m_deferredFocusedNodeChange.removeAllMatching([&node](auto& entry) -> bool {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194627
: 361969