Attachment 361957 Details for Bug 194623 – Patch

[patch] Patch

bug-194623-20190213163147.patch (text/plain), 4.29 KB, created by BJ Burg on 2019-02-13 16:31:48 PST

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2019-02-13 16:31:48 PST

Size: 4.29 KB

patch

obsolete

>Subversion Revision: 241448
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 6c3e1d8846492926e525dea1e53d34775ad4666f..50a95bb1d6e14e0b559328721b20d50d3c57f7b7 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-13  Brian Burg  <bburg@apple.com>
>+
>+        Web Inspector: don't include accessibility role in DOM.Node object payloads
>+        https://bugs.webkit.org/show_bug.cgi?id=194623
>+        <rdar://problem/36384037>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove property of DOM.Node that is no longer being sent.
>+
>+        * inspector/protocol/DOM.json:
>+
> 2019-02-13  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         VariableLengthObject::allocate<T> should initialize objects
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b5ddee82cdaa63f91b895c07870d23e0aae2d73c..0b80739db4e03f0a036b13e26ebd3198200bed3c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,25 @@
>+2019-02-13  Brian Burg  <bburg@apple.com>
>+
>+        Web Inspector: don't include accessibility role in DOM.Node object payloads
>+        https://bugs.webkit.org/show_bug.cgi?id=194623
>+        <rdar://problem/36384037>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Accessibility properties are complicated to fetch at all the points where we want to build and push nodes immediately.
>+        Turning on AX often indirectly causes style recalc and layout. This is bad because we are often building nodes in the
>+        first place due to a DOM node tree update (i.e., NodeInserted).
>+
>+        It turns out that DOM.getAccessibilityPropertiesForNode is called every time we display
>+        the computed role in the Elements Tab > Nodes Sidebar > Accessibility Section. So it is not
>+        necessary to collect this information in a problematic way when initially pushing the node, as
>+        it will be updated anyway.
>+
>+        No new tests, no change in behavior.
>+
>+        * inspector/agents/InspectorDOMAgent.cpp:
>+        (WebCore::InspectorDOMAgent::buildObjectForNode):
>+
> 2019-02-13  Alex Christensen  <achristensen@webkit.org>
> 
>         Stop using setDefersLoading from WebCore
>diff --git a/Source/JavaScriptCore/inspector/protocol/DOM.json b/Source/JavaScriptCore/inspector/protocol/DOM.json
>index 013c2bb2e31b40699827707edaa237f16c8e3ea6..03c437f45a04636eacdc076acc99d872b210690a 100644
>--- a/Source/JavaScriptCore/inspector/protocol/DOM.json
>+++ b/Source/JavaScriptCore/inspector/protocol/DOM.json
>@@ -65,7 +65,6 @@
>                 { "name": "shadowRoots", "type": "array", "optional": true, "items": { "$ref": "Node" }, "description": "Shadow root list for given element host." },
>                 { "name": "templateContent", "$ref": "Node", "optional": true, "description": "Content document fragment for template elements" },
>                 { "name": "pseudoElements", "type": "array", "items": { "$ref": "Node" }, "optional": true, "description": "Pseudo elements associated with this node." },
>-                { "name": "role", "type": "string", "optional": true, "description": "Computed value for first recognized role token, default role per element, or overridden role." },
>                 { "name": "contentSecurityPolicyHash", "type": "string", "optional": true, "description": "Computed SHA-256 Content Security Policy hash source for given element." }
>             ]
>         },
>diff --git a/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp b/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
>index 3536d78ec0f27f697cbc03e2bedd96eebe714fb8..1993b552169546c83e096a236f73ee92ee401af3 100644
>--- a/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
>+++ b/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
>@@ -1594,15 +1594,6 @@ Ref<Inspector::Protocol::DOM::Node> InspectorDOMAgent::buildObjectForNode(Node*
>         value->setShadowRootType(shadowRootType(shadowRoot.mode()));
>     }
> 
>-    // Need to enable AX to get the computed role.
>-    if (!WebCore::AXObjectCache::accessibilityEnabled())
>-        WebCore::AXObjectCache::enableAccessibility();
>-
>-    if (AXObjectCache* axObjectCache = node->document().axObjectCache()) {
>-        if (AccessibilityObject* axObject = axObjectCache->getOrCreate(node))
>-            value->setRole(axObject->computedRoleString());
>-    }
>-
>     return value;
> }
>

Flags:

hi: review+
hi: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 194623: 361957