Attachment 361951 Details for Bug 194621 – Patch

[patch] Patch

bug-194621-20190213155542.patch (text/plain), 1.80 KB, created by Jer Noble on 2019-02-13 15:55:43 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2019-02-13 15:55:43 PST

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 241299
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 51cec6efd7d565c62f94603fbab7b85f1d6ed357..41f45929a9ae60410ee1274e2b70c65985d8521c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-13  Jer Noble  <jer.noble@apple.com>
>+
>+        [Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
>+        https://bugs.webkit.org/show_bug.cgi?id=194621
>+        <rdar://problem/48002560>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When Safari is minimized, no rAF() requests are executed. Don't gate responding to presentation
>+        change events in the media-controller.js on rAF().
>+
>+        * Modules/modern-media-controls/media/media-controller.js:
>+        (MediaController.prototype._returnMediaLayerToInlineIfNeeded):
>+
> 2019-02-13  Jer Noble  <jer.noble@apple.com>
> 
>         Null-deref crash at SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged()
>diff --git a/Source/WebCore/Modules/modern-media-controls/media/media-controller.js b/Source/WebCore/Modules/modern-media-controls/media/media-controller.js
>index 18fa91eb93049bd02ea6dc46755e60672da4dfc3..6753ba9d9a6c4b12066e1519239c1574e9f893b0 100644
>--- a/Source/WebCore/Modules/modern-media-controls/media/media-controller.js
>+++ b/Source/WebCore/Modules/modern-media-controls/media/media-controller.js
>@@ -284,7 +284,7 @@ class MediaController
>     _returnMediaLayerToInlineIfNeeded()
>     {
>         if (this.host)
>-            window.requestAnimationFrame(() => this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode));
>+            this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode);
>     }
> 
>     _controlsClassForLayoutTraits(layoutTraits)

Actions: View | Formatted Diff | Diff

Attachments on bug 194621: 361951