Attachment 361946 Details for Bug 194128 – rebased patch with ProgramArguments

[patch] rebased patch with ProgramArguments

patch (text/plain), 6.29 KB, created by Alex Christensen on 2019-02-13 15:28:58 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-02-13 15:28:58 PST

Size: 6.29 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 241441)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,5 +1,18 @@
> 2019-02-13  Alex Christensen  <achristensen@webkit.org>
> 
>+        Add NetworkingDaemon plist
>+        https://bugs.webkit.org/show_bug.cgi?id=194128
>+        <rdar://problem/47705244>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/NetworkService.xcconfig:
>+        * NetworkProcess/EntryPoint/Cocoa/Daemon: Added.
>+        * NetworkProcess/EntryPoint/Cocoa/Daemon/com.apple.WebKit.NetworkingDaemon.plist: Added.
>+        * WebKit.xcodeproj/project.pbxproj:
>+
>+2019-02-13  Alex Christensen  <achristensen@webkit.org>
>+
>         Remove legacy sync messaging in some IPC code
>         https://bugs.webkit.org/show_bug.cgi?id=194561
> 
>Index: Source/WebKit/Configurations/NetworkService.xcconfig
>===================================================================
>--- Source/WebKit/Configurations/NetworkService.xcconfig	(revision 241441)
>+++ Source/WebKit/Configurations/NetworkService.xcconfig	(working copy)
>@@ -37,5 +37,7 @@
> INFOPLIST_FILE[sdk=iphone*] = NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist;
> INFOPLIST_FILE[sdk=macosx*] = NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-OSX.plist;
> 
>+DAEMON_PLIST_DIRECTORY[sdk=iphone*] = /System/Library/LaunchDaemons
>+
> OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
> OTHER_LDFLAGS[sdk=macosx*] = $(inherited) $(BUILT_PRODUCTS_DIR)/SecItemShim.dylib;
>Index: Source/WebKit/NetworkProcess/EntryPoint/Cocoa/Daemon/com.apple.WebKit.NetworkingDaemon.plist
>===================================================================
>--- Source/WebKit/NetworkProcess/EntryPoint/Cocoa/Daemon/com.apple.WebKit.NetworkingDaemon.plist	(nonexistent)
>+++ Source/WebKit/NetworkProcess/EntryPoint/Cocoa/Daemon/com.apple.WebKit.NetworkingDaemon.plist	(working copy)
>@@ -0,0 +1,22 @@
>+<?xml version="1.0" encoding="UTF-8"?>
>+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
>+<plist version="1.0">
>+<dict>
>+	<key>ProgramArguments</key>
>+	<array>
>+		<string>/System/Library/Frameworks/WebKit.framework/XPCServices/com.apple.WebKit.Networking.xpc/com.apple.WebKit.Networking</string>
>+		<string>WebKitNetworkingDaemon</string>
>+	</array>
>+	<key>Label</key>
>+	<string>com.apple.WebKit.NetworkingDaemon</string>
>+	<key>Program</key>
>+	<string>/System/Library/Frameworks/WebKit.framework/XPCServices/com.apple.WebKit.Networking.xpc/com.apple.WebKit.Networking</string>
>+	<key>MachServices</key>
>+	<dict>
>+		<key>com.apple.WebKit.NetworkingDaemon</key>
>+		<true/>
>+	</dict>
>+	<key>EnablePressuredExit</key>
>+	<true/>
>+</dict>
>+</plist>
>Index: Source/WebKit/WebKit.xcodeproj/project.pbxproj
>===================================================================
>--- Source/WebKit/WebKit.xcodeproj/project.pbxproj	(revision 241441)
>+++ Source/WebKit/WebKit.xcodeproj/project.pbxproj	(working copy)
>@@ -3482,6 +3482,7 @@
> 		5CB2378D1DF0E0C200117AA3 /* _WKWebsitePoliciesInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = _WKWebsitePoliciesInternal.h; sourceTree = "<group>"; };
> 		5CBC9B891C6524A500A8FDCF /* NetworkDataTask.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NetworkDataTask.h; sourceTree = "<group>"; };
> 		5CBC9B8B1C65257300A8FDCF /* NetworkDataTaskCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = NetworkDataTaskCocoa.mm; sourceTree = "<group>"; };
>+		5CC4DF6B2203BD620094E28F /* com.apple.WebKit.NetworkingDaemon.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = com.apple.WebKit.NetworkingDaemon.plist; path = NetworkProcess/EntryPoint/Cocoa/Daemon/com.apple.WebKit.NetworkingDaemon.plist; sourceTree = SOURCE_ROOT; };
> 		5CC5DB9121488E16006CB8A8 /* SharedBufferDataReference.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SharedBufferDataReference.h; sourceTree = "<group>"; };
> 		5CD286491E722F440094FDC8 /* _WKUserContentFilterPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = _WKUserContentFilterPrivate.h; sourceTree = "<group>"; };
> 		5CD2864A1E722F440094FDC8 /* WKContentRuleList.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKContentRuleList.h; sourceTree = "<group>"; };
>@@ -6843,6 +6844,7 @@
> 		5C5CEC372209581B00D6BBB0 /* Daemon */ = {
> 			isa = PBXGroup;
> 			children = (
>+				5CC4DF6B2203BD620094E28F /* com.apple.WebKit.NetworkingDaemon.plist */,
> 				5C5CEC382209583200D6BBB0 /* DaemonEntryPoint.h */,
> 				5C5CEC392209583200D6BBB0 /* DaemonEntryPoint.mm */,
> 			);
>@@ -10108,6 +10110,7 @@
> 				BC8283AF16B4BF7700A278FE /* Resources */,
> 				41D0FC8020E43B4500076AE8 /* Unlock keychain */,
> 				41D0FC8120E43B7000076AE8 /* Process Network entitlements */,
>+				5CC4DF692203BBF00094E28F /* Copy Daemon plist */,
> 			);
> 			buildRules = (
> 			);
>@@ -10506,6 +10509,25 @@
> 			shellPath = /bin/sh;
> 			shellScript = "Scripts/check-xcfilelists.sh\n";
> 		};
>+		5CC4DF692203BBF00094E28F /* Copy Daemon plist */ = {
>+			isa = PBXShellScriptBuildPhase;
>+			buildActionMask = 8;
>+			files = (
>+			);
>+			inputFileListPaths = (
>+			);
>+			inputPaths = (
>+				"$(SRCROOT)/NetworkProcess/EntryPoint/Cocoa/Daemon/com.apple.WebKit.NetworkingDaemon.plist",
>+			);
>+			name = "Copy Daemon plist";
>+			outputFileListPaths = (
>+			);
>+			outputPaths = (
>+			);
>+			runOnlyForDeploymentPostprocessing = 1;
>+			shellPath = /bin/sh;
>+			shellScript = "if [ -z \"${DAEMON_PLIST_DIRECTORY}\" ]; then\n    echo \"Not copying com.apple.WebKit.NetworkingDaemon plist\"\n    exit 0;\nfi\n\nPLIST_OUTPUT_DIRECTORY_PATH=\"${DSTROOT}${DAEMON_PLIST_DIRECTORY}\"\nPLIST_OUTPUT_PATH=\"${PLIST_OUTPUT_DIRECTORY_PATH}/com.apple.WebKit.NetworkingDaemon.plist\"\n\necho \"Copying com.apple.WebKit.NetworkingDaemon plist\"\nmkdir -p \"${PLIST_OUTPUT_DIRECTORY_PATH}\"\nplutil -convert binary1 -o \"${PLIST_OUTPUT_PATH}\" \"${SCRIPT_INPUT_FILE_0}\"\n";
>+		};
> 		5DF408C5131DD46700130071 /* Check For Weak VTables and Externals */ = {
> 			isa = PBXShellScriptBuildPhase;
> 			buildActionMask = 2147483647;

Actions: View | Formatted Diff | Diff

Attachments on bug 194128: 360809 | 360914 | 361946