Attachment 361940 Details for Bug 194613 – Patch

[patch] Patch

bug-194613-20190213144230.patch (text/plain), 1.79 KB, created by Jer Noble on 2019-02-13 14:42:31 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2019-02-13 14:42:31 PST

Size: 1.79 KB

patch

obsolete

>Subversion Revision: 241299
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 5ee78186f966455f6dcf3b34670458d405f1edd4..51cec6efd7d565c62f94603fbab7b85f1d6ed357 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-13  Jer Noble  <jer.noble@apple.com>
>+
>+        Null-deref crash at SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged()
>+        https://bugs.webkit.org/show_bug.cgi?id=194613
>+        <rdar://problem/48023912>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
>+        (WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
>+
> 2019-02-11  Jer Noble  <jer.noble@apple.com>
> 
>         Entering fullscreen inside a shadow root will not set fullscreen pseudoclasses outside of root
>diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm b/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
>index 23d9b2f48d8d8fda9f93f5d8f7b8ff72a729cc4d..992f4593e4f5839c2034a469db763b7e229cf654 100644
>--- a/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
>+++ b/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
>@@ -1031,7 +1031,7 @@ void SourceBufferPrivateAVFObjC::layerDidReceiveError(AVSampleBufferDisplayLayer
> void SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged(bool obscured)
> {
> #if ENABLE(ENCRYPTED_MEDIA) && HAVE(AVCONTENTKEYSESSION)
>-    if (m_mediaSource->cdmInstance()) {
>+    if (m_mediaSource && m_mediaSource->cdmInstance()) {
>         m_mediaSource->outputObscuredDueToInsufficientExternalProtectionChanged(obscured);
>         return;
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 194613: 361940