WebKit Bugzilla
Attachment 361907 Details for
Bug 194588
: Crash in WebKit::CacheStorage::Engine::cachesRootPath
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
sw-cache-salt.patch (text/plain), 1.32 KB, created by
Antti Koivisto
on 2019-02-13 03:14:38 PST
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Antti Koivisto
Created:
2019-02-13 03:14:38 PST
Size:
1.32 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 241430) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2019-02-13 Antti Koivisto <antti@apple.com> >+ >+ Crash in WebKit::CacheStorage::Engine::cachesRootPath >+ https://bugs.webkit.org/show_bug.cgi?id=194588 >+ <rdar://problem/46363997> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * NetworkProcess/cache/CacheStorageEngine.cpp: >+ (WebKit::CacheStorage::Engine::cachesRootPath): >+ >+ Salt may have not been initialized yet when the Engine is destroyed. >+ > 2019-02-13 Ryosuke Niwa <rniwa@webkit.org> > > Crash in Page::setActivityState because m_page is null >Index: Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp >=================================================================== >--- Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (revision 241293) >+++ Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (working copy) >@@ -48,7 +48,7 @@ using namespace NetworkCache; > > String Engine::cachesRootPath(const WebCore::ClientOrigin& origin) > { >- if (!shouldPersist()) >+ if (!shouldPersist() || !m_salt) > return { }; > > Key key(origin.topOrigin.toString(), origin.clientOrigin.toString(), { }, { }, salt());
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194588
: 361907