Attachment 361882 Details for Bug 194577 – patch

[patch] patch

a-backup.diff (text/plain), 1.54 KB, created by Saam Barati on 2019-02-12 18:09:57 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2019-02-12 18:09:57 PST

Size: 1.54 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 241334)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-02-12  Saam barati  <sbarati@apple.com>
>+
>+        JSScript needs to retain its cache path NSURL*
>+        https://bugs.webkit.org/show_bug.cgi?id=194577
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * API/JSScript.mm:
>+        (+[JSScript scriptFromASCIIFile:inVirtualMachine:withCodeSigning:andBytecodeCache:]):
>+        (-[JSScript dealloc]):
>+
> 2019-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Unreviewed, fix -Wimplicit-fallthrough warning after r241140
>Index: Source/JavaScriptCore/API/JSScript.mm
>===================================================================
>--- Source/JavaScriptCore/API/JSScript.mm	(revision 241334)
>+++ Source/JavaScriptCore/API/JSScript.mm	(working copy)
>@@ -106,7 +106,7 @@ + (instancetype)scriptFromASCIIFile:(NSU
>     JSScript *result = [[[JSScript alloc] init] autorelease];
>     result->m_virtualMachine = vm;
>     result->m_source = String::fromUTF8WithLatin1Fallback(buffer.data(), buffer.size());
>-    result->m_cachePath = cachePath;
>+    result->m_cachePath = [cachePath retain];
>     [result readCache];
>     return result;
> }
>@@ -120,6 +120,9 @@ - (void)dealloc
> {
>     if (m_cachedBytecode.size() && !m_cachedBytecode.owned())
>         munmap(const_cast<void*>(m_cachedBytecode.data()), m_cachedBytecode.size());
>+
>+    [m_cachePath release];
>+
>     [super dealloc];
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194577: 361882 | 361884 | 361885 | 361886