Attachment 361870 Details for Bug 194570 – Patch

[patch] Patch

bug-194570-20190212170521.patch (text/plain), 2.25 KB, created by Brent Fulgham on 2019-02-12 17:05:22 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2019-02-12 17:05:22 PST

Size: 2.25 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 241329)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-02-12  Brent Fulgham  <bfulgham@apple.com>
>+
>+        [iOS] Revert ability to set programmatic focus when hardware keyboard is attached
>+        https://bugs.webkit.org/show_bug.cgi?id=194570
>+        <rdar://problem/47673836>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::platformEditorState const):
>+
> 2019-02-12  Alan Coon  <alancoon@apple.com>
> 
>         Apply patch. rdar://problem/48009995
>Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>===================================================================
>--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(revision 241329)
>+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(working copy)
>@@ -4552,7 +4552,6 @@ - (void)_elementDidFocus:(const WebKit::
>             || (_isChangingFocus && ![_focusedFormControlView isHidden])
> #else
>             || _isChangingFocus
>-            || [UIKeyboard isInHardwareKeyboardMode]
> #endif
> #if ENABLE(DRAG_SUPPORT)
>             || _dragDropInteractionState.isPerformingDrop()
>Index: Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	(revision 241329)
>+++ Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	(working copy)
>@@ -200,9 +200,6 @@ void WebPage::platformEditorState(Frame&
>     // immediately so that the UIProcess can update UI, including the position of the caret.
>     bool needsLayout = !frame.view() || frame.view()->needsLayout();
>     bool requiresPostLayoutData = frame.editor().hasComposition();
>-#if !PLATFORM(IOSMAC)
>-    requiresPostLayoutData |= [UIKeyboard isInHardwareKeyboardMode];
>-#endif
>     if (shouldIncludePostLayoutData == IncludePostLayoutDataHint::No && needsLayout && !requiresPostLayoutData) {
>         result.isMissingPostLayoutData = true;
>         return;

Actions: View | Formatted Diff | Diff

Attachments on bug 194570: 361870