Attachment 361860 Details for Bug 194562 – Patch

[patch] Patch

bug-194562-20190212161046.patch (text/plain), 3.29 KB, created by Jonathan Bedard on 2019-02-12 16:10:47 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-02-12 16:10:47 PST

Size: 3.29 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 241325)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-02-12  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Remove bug_dummy from parsed test expectations
>+        https://bugs.webkit.org/show_bug.cgi?id=194562
>+        <rdar://problem/47853999>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
>+        (TestExpectationParser):
>+        (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
>+        skipped tests.
>+        * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
>+
> 2019-02-12  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Expand tests coverage (60 new tests -> 860)
>Index: Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
>===================================================================
>--- Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	(revision 241323)
>+++ Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	(working copy)
>@@ -78,7 +78,6 @@ class TestExpectationWarning(object):
> class TestExpectationParser(object):
>     """Provides parsing facilities for lines in the test_expectation.txt file."""
> 
>-    DUMMY_BUG_MODIFIER = "bug_dummy"
>     BUG_MODIFIER_PREFIX = 'bug'
>     BUG_MODIFIER_REGEX = 'bug\d+'
>     REBASELINE_MODIFIER = 'rebaseline'
>@@ -117,7 +116,7 @@ class TestExpectationParser(object):
>             _log.warning('The following test %s from the Skipped list doesn\'t exist' % test_name)
>         expectation_line = TestExpectationLine()
>         expectation_line.original_string = test_name
>-        expectation_line.modifiers = [TestExpectationParser.DUMMY_BUG_MODIFIER, TestExpectationParser.SKIP_MODIFIER]
>+        expectation_line.modifiers = [TestExpectationParser.SKIP_MODIFIER]
>         # FIXME: It's not clear what the expectations for a skipped test should be; the expectations
>         # might be different for different entries in a Skipped file, or from the command line, or from
>         # only running parts of the tests. It's also not clear if it matters much.
>Index: Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
>===================================================================
>--- Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py	(revision 241323)
>+++ Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py	(working copy)
>@@ -298,9 +298,9 @@ class SkippedTests(Base):
>         exp = TestExpectations(port, ['failures/expected/text.html'], expectations_to_lint=expectations_to_lint)
>         exp.parse_all_expectations()
> 
>-        # Check that the expectation is for BUG_DUMMY SKIP : ... [ Pass ]
>+        # Check that the expectation is for SKIP : ... [ Pass ]
>         self.assertEqual(exp.model().get_modifiers('failures/expected/text.html'),
>-                          [TestExpectationParser.DUMMY_BUG_MODIFIER, TestExpectationParser.SKIP_MODIFIER, TestExpectationParser.WONTFIX_MODIFIER])
>+                          [TestExpectationParser.SKIP_MODIFIER, TestExpectationParser.WONTFIX_MODIFIER])
>         self.assertEqual(exp.model().get_expectations('failures/expected/text.html'), set([PASS]))
> 
>     def test_skipped_tests_work(self):

Actions: View | Formatted Diff | Diff

Attachments on bug 194562: 361860