Attachment 361830 Details for Bug 194554 – Patch for landing

[patch] Patch for landing

bug-194554-20190212133445.patch (text/plain), 2.74 KB, created by Jonathan Bedard on 2019-02-12 13:34:46 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-02-12 13:34:46 PST

Size: 2.74 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 241315)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2019-02-12  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: No option to only show unexpected failures in results.html for iPad
>+        https://bugs.webkit.org/show_bug.cgi?id=194554
>+        <rdar://problem/47922442>
>+
>+        Rubber-stamped by Aakash Jain.
>+
>+        Just because a TestExpecations file does not exist for a specific platform does not mean that
>+        TestExpecations are not being used, given that platforms inherit test expectations.
>+
>+        * Scripts/webkitpy/port/base.py:
>+        (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
>+        * Scripts/webkitpy/port/base_unittest.py:
>+        (PortTest.test_uses_test_expectations_file):
>+
> 2019-02-12  Alex Christensen  <achristensen@webkit.org>
> 
>         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
>Index: Tools/Scripts/webkitpy/port/base.py
>===================================================================
>--- Tools/Scripts/webkitpy/port/base.py	(revision 241306)
>+++ Tools/Scripts/webkitpy/port/base.py	(working copy)
>@@ -1157,7 +1157,10 @@ class Port(object):
>     def uses_test_expectations_file(self):
>         # This is different from checking test_expectations() is None, because
>         # some ports have Skipped files which are returned as part of test_expectations().
>-        return self._filesystem.exists(self.path_to_test_expectations_file())
>+        for path in self.default_baseline_search_path():
>+            if self._filesystem.exists(self._filesystem.join(path, 'TestExpectations')):
>+                return True
>+        return False
> 
>     def warn_if_bug_missing_in_test_expectations(self):
>         return False
>Index: Tools/Scripts/webkitpy/port/base_unittest.py
>===================================================================
>--- Tools/Scripts/webkitpy/port/base_unittest.py	(revision 241306)
>+++ Tools/Scripts/webkitpy/port/base_unittest.py	(working copy)
>@@ -225,9 +225,8 @@ class PortTest(unittest.TestCase):
>     def test_uses_test_expectations_file(self):
>         port = self.make_port(port_name='foo')
>         port.port_name = 'foo'
>-        port.path_to_test_expectations_file = lambda: '/mock-results/TestExpectations'
>         self.assertFalse(port.uses_test_expectations_file())
>-        port._filesystem = MockFileSystem({'/mock-results/TestExpectations': ''})
>+        port._filesystem = MockFileSystem({'/mock-checkout/LayoutTests/platform/foo/TestExpectations': ''})
>         self.assertTrue(port.uses_test_expectations_file())
> 
>     def test_find_no_paths_specified(self):

Actions: View | Formatted Diff | Diff

Attachments on bug 194554: 361828 | 361830