Attachment 361818 Details for Bug 194549 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

time-range-1.patch (text/plain), 1.61 KB, created by Joseph Pecoraro on 2019-02-12 11:57:18 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-02-12 11:57:18 PST

Size: 1.61 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 18abb869033..9968634301d 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-02-12  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have
>+        https://bugs.webkit.org/show_bug.cgi?id=194549
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Models/Timeline.js:
>+        (WI.Timeline.prototype.recordsInTimeRange):
>+
> 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: Remove unused maxUsage in CPUTimelineView
>diff --git a/Source/WebInspectorUI/UserInterface/Models/Timeline.js b/Source/WebInspectorUI/UserInterface/Models/Timeline.js
>index 3de983dcaae..756ce574c40 100644
>--- a/Source/WebInspectorUI/UserInterface/Models/Timeline.js
>+++ b/Source/WebInspectorUI/UserInterface/Models/Timeline.js
>@@ -95,8 +95,8 @@ WI.Timeline = class Timeline extends WI.Object
> 
>     recordsInTimeRange(startTime, endTime, includeRecordBeforeStart)
>     {
>-        let lowerIndex = this._records.lowerBound(startTime, (time, record) => time - record.timestamp);
>-        let upperIndex = this._records.upperBound(endTime, (time, record) => time - record.timestamp);
>+        let lowerIndex = this._records.lowerBound(startTime, (time, record) => time - record.startTime);
>+        let upperIndex = this._records.upperBound(endTime, (time, record) => time - record.startTime);
> 
>         // Include the record right before the start time.
>         if (includeRecordBeforeStart && lowerIndex > 0)

Actions: View | Formatted Diff | Diff

Attachments on bug 194549: 361818