WebKit Bugzilla
Attachment 361808 Details for
Bug 194546
: AX: Fix flaky accessibility/loading-iframe-sends-notification.html
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
patch (text/plain), 3.05 KB, created by
chris fleizach
on 2019-02-12 11:11:30 PST
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
chris fleizach
Created:
2019-02-12 11:11:30 PST
Size:
3.05 KB
patch
obsolete
>Index: LayoutTests/ChangeLog >=================================================================== >--- LayoutTests/ChangeLog (revision 241304) >+++ LayoutTests/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2019-02-12 Chris Fleizach <cfleizach@apple.com> >+ >+ AX: Fix flaky accessibility/loading-iframe-sends-notification.html >+ https://bugs.webkit.org/show_bug.cgi?id=194546 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This test was relying on timing between load events being sent and accessibility events being sent. >+ We don't need to do that, we can more directly test this interplay. >+ >+ * accessibility/loading-iframe-sends-notification-expected.txt: >+ * accessibility/loading-iframe-sends-notification.html: >+ > 2019-02-12 Adrian Perez de Castro <aperez@igalia.com> > > Unreviewed WPE gardening. Unskip content extensions tests after r241283 >Index: LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt >=================================================================== >--- LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt (revision 241296) >+++ LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt (working copy) >@@ -13,7 +13,6 @@ > PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is false > Got notification on iframe. > PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is true >-PASS gotIframeNotification is true > PASS successfullyParsed is true > > TEST COMPLETE >Index: LayoutTests/accessibility/loading-iframe-sends-notification.html >=================================================================== >--- LayoutTests/accessibility/loading-iframe-sends-notification.html (revision 241296) >+++ LayoutTests/accessibility/loading-iframe-sends-notification.html (working copy) >@@ -42,8 +42,6 @@ > > function runTest() > { >- window.gotIframeNotification = false; >- > if (window.accessibilityController) { > window.root = accessibilityController.rootElement; > >@@ -59,24 +57,16 @@ > return; > > debug("Got notification on iframe."); >- gotIframeNotification = true; > > // Check that the button within the iframe is now reachable from the root. > shouldBeTrue("findByAccessibleTitleSubstring(root, 'InnerButton') != null"); >+ accessibilityController.removeNotificationListener(); >+ finishJSTest(); > }); > } > > window.iframeElement = document.getElementById("iframe"); >- iframeElement.addEventListener("load", function() { >- window.setTimeout(function() { >- shouldBeTrue("gotIframeNotification"); >- if (window.accessibilityController) >- accessibilityController.removeNotificationListener(); > >- finishJSTest(); >- }, 10); >- }, false); >- > // Load content into the iframe. This will trigger the event > // handler above, which will check that the accessibility tree > // was updated with new content.
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194546
: 361808