Attachment 361794 Details for Bug 194538 – patch

[patch] patch

scrollingtree-nodemap-remove.patch (text/plain), 1.31 KB, created by Antti Koivisto on 2019-02-12 06:55:42 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2019-02-12 06:55:42 PST

Size: 1.31 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 241293)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-02-12  Antti Koivisto  <antti@apple.com>
>+
>+        Crash in WebCore::ScrollingTree::updateTreeFromStateNode
>+        https://bugs.webkit.org/show_bug.cgi?id=194538
>+        <rdar://problem/47841926>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/scrolling/ScrollingTree.cpp:
>+        (WebCore::ScrollingTree::updateTreeFromStateNode):
>+
>+        Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.
>+
> 2019-02-12  Rob Buis  <rbuis@igalia.com>
> 
>         Implement serializing in MIME type parser
>Index: Source/WebCore/page/scrolling/ScrollingTree.cpp
>===================================================================
>--- Source/WebCore/page/scrolling/ScrollingTree.cpp	(revision 241293)
>+++ Source/WebCore/page/scrolling/ScrollingTree.cpp	(working copy)
>@@ -229,6 +229,9 @@ void ScrollingTree::updateTreeFromStateN
>             auto* parent = parentIt->value;
>             node->setParent(parent);
>             parent->appendChild(*node);
>+        } else {
>+            // FIXME: Use WeakPtr in m_nodeMap.
>+            m_nodeMap.remove(nodeID);
>         }
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194538: 361794