WebKit Bugzilla
Attachment 361744 Details for
Bug 194526
: Web Inspector: Remove unused maxUsage in CPUTimelineView
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
[PATCH] Proposed Fix
maxusage-1.patch (text/plain), 1.84 KB, created by
Joseph Pecoraro
on 2019-02-11 17:44:44 PST
(
hide
)
Description:
[PATCH] Proposed Fix
Filename:
MIME Type:
Creator:
Joseph Pecoraro
Created:
2019-02-11 17:44:44 PST
Size:
1.84 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 35f37ac904e..18abb869033 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,14 @@ >+2019-02-11 Joseph Pecoraro <pecoraro@apple.com> >+ >+ Web Inspector: Remove unused maxUsage in CPUTimelineView >+ https://bugs.webkit.org/show_bug.cgi?id=194526 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Views/CPUTimelineView.js: >+ (WI.CPUTimelineView): >+ (WI.CPUTimelineView.prototype.shown): >+ > 2019-02-08 Devin Rousso <drousso@apple.com> > > Web Inspector: Audit: show keyboard shortcut in export tooltip >diff --git a/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js b/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js >index b34413dca6b..34e31833afa 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js >@@ -32,7 +32,6 @@ WI.CPUTimelineView = class CPUTimelineView extends WI.TimelineView > super(timeline, extraArguments); > > this._recording = extraArguments.recording; >- this._maxUsage = -Infinity; > > this.element.classList.add("cpu"); > >@@ -78,8 +77,6 @@ WI.CPUTimelineView = class CPUTimelineView extends WI.TimelineView > { > super.reset(); > >- this._maxUsage = -Infinity; >- > this.clear(); > } > >@@ -195,8 +192,6 @@ WI.CPUTimelineView = class CPUTimelineView extends WI.TimelineView > let cpuTimelineRecord = event.data.record; > console.assert(cpuTimelineRecord instanceof WI.CPUTimelineRecord); > >- this._maxUsage = Math.max(this._maxUsage, cpuTimelineRecord.usage); >- > if (cpuTimelineRecord.startTime >= this.startTime && cpuTimelineRecord.endTime <= this.endTime) > this.needsLayout(); > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194526
: 361744 |
361758