Attachment 361718 Details for Bug 177484 – Patch

[patch] Patch

bug-177484-20190211153509.patch (text/plain), 33.32 KB, created by Said Abou-Hallawa on 2019-02-11 15:35:10 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Said Abou-Hallawa

Created: 2019-02-11 15:35:10 PST

Size: 33.32 KB

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 241266)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-02-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        requestAnimationFrame should execute before the next frame
>+        https://bugs.webkit.org/show_bug.cgi?id=177484
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add tracing signposts for requestAnimationFrame scheduling and flushing
>+        the layers interval.
>+
>+        * wtf/SystemTracing.h:
>+
> 2019-02-10  Darin Adler  <darin@apple.com>
> 
>         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
>Index: Source/WTF/wtf/SystemTracing.h
>===================================================================
>--- Source/WTF/wtf/SystemTracing.h	(revision 241266)
>+++ Source/WTF/wtf/SystemTracing.h	(working copy)
>@@ -75,6 +75,11 @@ enum TracePointCode {
>     DisplayListRecordEnd,
>     DisplayRefreshDispatchingToMainThread,
> 
>+    ScheduleRenderingUpdate,
>+    TriggerRenderingUpdate,
>+    RenderingUpdateStart,
>+    RenderingUpdateEnd,
>+
>     WebKitRange = 10000,
>     WebHTMLViewPaintStart,
>     WebHTMLViewPaintEnd,
>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 241266)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,71 @@
>+2019-02-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        requestAnimationFrame should execute before the next frame
>+        https://bugs.webkit.org/show_bug.cgi?id=177484
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This change will fix two issues with animation timing:
>+
>+        1. Servicing requestAnimationFrame callbacks happens when the DisplayLink
>+           fires. This may happen even if the frame is missed and no display is
>+           committed.
>+
>+        2. Javascript may try to refresh the screen more than 60 FPS. WebCore 
>+           currently runs the layout and commits the layer although the graphical
>+           system will throttle to 60 FPS at the end.
>+
>+        These two issues can be fixed if we do the following:
>+
>+        1. DisplayMonitor callback will scheduleCompositingLayerFlush() instead
>+           of servicing requestAnimationFrame callbacks.
>+
>+        2. When the page is about to be displayed, requestAnimationFrame callbacks
>+           will be served.
>+
>+        * Sources.txt:
>+        * WebCore.xcodeproj/project.pbxproj:
>+        * animation/DocumentAnimationScheduler.cpp:
>+        (WebCore::DocumentAnimationScheduler::unscheduleWebAnimationsResolution):
>+        (WebCore::DocumentAnimationScheduler::displayRefreshFired):
>+        (WebCore::DocumentAnimationScheduler::scheduleScriptedAnimationResolution): Deleted.
>+        * animation/DocumentAnimationScheduler.h:
>+        * dom/Document.cpp:
>+        (WebCore::Document::callRequestAnimationFrameCallbacks):
>+        * dom/Document.h:
>+        * dom/ScriptedAnimationController.cpp:
>+        (WebCore::ScriptedAnimationController::callRequestAnimationFrameCallbacks):
>+        (WebCore::ScriptedAnimationController::scheduleAnimation):
>+        (WebCore::ScriptedAnimationController::animationTimerFired):
>+        (WebCore::ScriptedAnimationController::documentAnimationSchedulerDidFire):
>+        (WebCore::ScriptedAnimationController::serviceScriptedAnimations): Deleted.
>+        * dom/ScriptedAnimationController.h:
>+        * page/FrameTree.cpp:
>+        * page/Page.cpp:
>+        (WebCore::Page::processPreLayoutActions):
>+        (WebCore::Page::processPreRenderActions):
>+        (WebCore::Page::callRequestAnimationFrameCallbacks):
>+        (WebCore::Page::renderScheduler):
>+        (WebCore::Page::willDisplayPage): Deleted.
>+        * page/Page.h:
>+        * page/PageOverlayController.cpp:
>+        (WebCore::PageOverlayController::didChangeViewExposedRect):
>+        (WebCore::PageOverlayController::notifyFlushRequired):
>+        * page/RenderScheduler.cpp: Added.
>+        (WebCore::RenderScheduler::RenderScheduler):
>+        (WebCore::RenderScheduler::scheduleRender):
>+        (WebCore::RenderScheduler::startTimer):
>+        (WebCore::RenderScheduler::clearTimer):
>+        (WebCore::RenderScheduler::windowScreenDidChange):
>+        (WebCore::RenderScheduler::createDisplayRefreshMonitor const):
>+        (WebCore::RenderScheduler::displayRefreshFired):
>+        * page/RenderScheduler.h: Added.
>+        (WebCore::RenderScheduler::create):
>+        * page/mac/ServicesOverlayController.mm:
>+        (WebCore::ServicesOverlayController::Highlight::notifyFlushRequired):
>+        * rendering/RenderLayerCompositor.cpp:
>+        (WebCore::RenderLayerCompositor::scheduleLayerFlushNow):
>+
> 2019-02-11  Youenn Fablet  <youenn@apple.com>
> 
>         Make Request constructor throw if FetchRequestInit.signal is not undefined, null or an AbortSignal object
>Index: Source/WebCore/Sources.txt
>===================================================================
>--- Source/WebCore/Sources.txt	(revision 241266)
>+++ Source/WebCore/Sources.txt	(working copy)
>@@ -1533,6 +1533,7 @@ page/ProcessWarming.cpp
> page/Quirks.cpp
> page/RemoteDOMWindow.cpp
> page/RemoteFrame.cpp
>+page/RenderScheduler.cpp
> page/ResourceUsageOverlay.cpp
> page/ResourceUsageThread.cpp
> page/RuntimeEnabledFeatures.cpp
>Index: Source/WebCore/WebCore.xcodeproj/project.pbxproj
>===================================================================
>--- Source/WebCore/WebCore.xcodeproj/project.pbxproj	(revision 241266)
>+++ Source/WebCore/WebCore.xcodeproj/project.pbxproj	(working copy)
>@@ -1779,6 +1779,7 @@
> 		5550CB421E955E3C00111AA0 /* ImageTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = 5550CB411E955E3C00111AA0 /* ImageTypes.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		555130011E7CCCCB00A69E38 /* DecodingOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 555130001E7CCCCA00A69E38 /* DecodingOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		555B87ED1CAAF0AB00349425 /* ImageDecoderCG.h in Headers */ = {isa = PBXBuildFile; fileRef = 555B87EB1CAAF0AB00349425 /* ImageDecoderCG.h */; };
>+		556C7C4B22123997009B06CA /* RenderScheduler.h in Headers */ = {isa = PBXBuildFile; fileRef = 556C7C4722123942009B06CA /* RenderScheduler.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		5576A5651D88A70800CCC04C /* ImageFrame.h in Headers */ = {isa = PBXBuildFile; fileRef = 5576A5631D88A70800CCC04C /* ImageFrame.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		55A336F91D821E3C0022C4C7 /* ImageBackingStore.h in Headers */ = {isa = PBXBuildFile; fileRef = 55A336F81D821E3C0022C4C7 /* ImageBackingStore.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		55AF14E61EAAC59B0026EEAA /* UTIRegistry.h in Headers */ = {isa = PBXBuildFile; fileRef = 55AF14E41EAAC59B0026EEAA /* UTIRegistry.h */; settings = {ATTRIBUTES = (Private, ); }; };
>@@ -8642,6 +8643,8 @@
> 		555130001E7CCCCA00A69E38 /* DecodingOptions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DecodingOptions.h; sourceTree = "<group>"; };
> 		555B87EA1CAAF0AB00349425 /* ImageDecoderCG.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ImageDecoderCG.cpp; sourceTree = "<group>"; };
> 		555B87EB1CAAF0AB00349425 /* ImageDecoderCG.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ImageDecoderCG.h; sourceTree = "<group>"; };
>+		556C7C4722123942009B06CA /* RenderScheduler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderScheduler.h; sourceTree = "<group>"; };
>+		556C7C4922123943009B06CA /* RenderScheduler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderScheduler.cpp; sourceTree = "<group>"; };
> 		5576A5621D88A70800CCC04C /* ImageFrame.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ImageFrame.cpp; sourceTree = "<group>"; };
> 		5576A5631D88A70800CCC04C /* ImageFrame.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ImageFrame.h; sourceTree = "<group>"; };
> 		5597FCCB2076C06800D35BB0 /* GlyphDisplayListCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GlyphDisplayListCache.h; sourceTree = "<group>"; };
>@@ -20481,6 +20484,8 @@
> 				46BCBBC3208500A700710638 /* RemoteDOMWindow.idl */,
> 				46B9518C207D632900A7D2DD /* RemoteFrame.cpp */,
> 				46B95192207D632E00A7D2DD /* RemoteFrame.h */,
>+				556C7C4922123943009B06CA /* RenderScheduler.cpp */,
>+				556C7C4722123942009B06CA /* RenderScheduler.h */,
> 				A5071E821C56D079009951BE /* ResourceUsageData.h */,
> 				ADBAD6EC1BCDD95000381325 /* ResourceUsageOverlay.cpp */,
> 				ADBAD6ED1BCDD95000381325 /* ResourceUsageOverlay.h */,
>@@ -31286,6 +31291,7 @@
> 				1479FAF0109AE37500DED655 /* RenderRubyBase.h in Headers */,
> 				1479FAF2109AE37500DED655 /* RenderRubyRun.h in Headers */,
> 				1479FAF4109AE37500DED655 /* RenderRubyText.h in Headers */,
>+				556C7C4B22123997009B06CA /* RenderScheduler.h in Headers */,
> 				BC3BE9940E9C1C7C00835588 /* RenderScrollbar.h in Headers */,
> 				BC3BE9950E9C1C7C00835588 /* RenderScrollbarPart.h in Headers */,
> 				BC3BE9990E9C1E5D00835588 /* RenderScrollbarTheme.h in Headers */,
>Index: Source/WebCore/animation/DocumentAnimationScheduler.cpp
>===================================================================
>--- Source/WebCore/animation/DocumentAnimationScheduler.cpp	(revision 241266)
>+++ Source/WebCore/animation/DocumentAnimationScheduler.cpp	(working copy)
>@@ -67,15 +67,7 @@ bool DocumentAnimationScheduler::schedul
> void DocumentAnimationScheduler::unscheduleWebAnimationsResolution()
> {
>     m_scheduledWebAnimationsResolution = false;
>-
>-    if (!m_scheduledScriptedAnimationResolution)
>-        DisplayRefreshMonitorManager::sharedManager().unregisterClient(*this);
>-}
>-
>-bool DocumentAnimationScheduler::scheduleScriptedAnimationResolution()
>-{
>-    m_scheduledScriptedAnimationResolution = true;
>-    return DisplayRefreshMonitorManager::sharedManager().scheduleAnimation(*this);
>+    DisplayRefreshMonitorManager::sharedManager().unregisterClient(*this);
> }
> 
> void DocumentAnimationScheduler::displayRefreshFired()
>@@ -94,12 +86,6 @@ void DocumentAnimationScheduler::display
>         m_document->timeline().documentAnimationSchedulerDidFire();
>     }
> 
>-    if (m_scheduledScriptedAnimationResolution) {
>-        m_scheduledScriptedAnimationResolution = false;
>-        if (auto* scriptedAnimationController = m_document->scriptedAnimationController())
>-            scriptedAnimationController->documentAnimationSchedulerDidFire();
>-    }
>-
>     m_isFiring = false;
> }
> 
>Index: Source/WebCore/animation/DocumentAnimationScheduler.h
>===================================================================
>--- Source/WebCore/animation/DocumentAnimationScheduler.h	(revision 241266)
>+++ Source/WebCore/animation/DocumentAnimationScheduler.h	(working copy)
>@@ -59,7 +59,6 @@ private:
> 
>     RefPtr<Document> m_document;
>     bool m_scheduledWebAnimationsResolution { false };
>-    bool m_scheduledScriptedAnimationResolution { false };
>     bool m_isFiring { false };
>     Seconds m_lastTimestamp { 0_s };
> 
>Index: Source/WebCore/dom/Document.cpp
>===================================================================
>--- Source/WebCore/dom/Document.cpp	(revision 241266)
>+++ Source/WebCore/dom/Document.cpp	(working copy)
>@@ -6293,6 +6293,12 @@ void Document::resumeScriptedAnimationCo
>         m_scriptedAnimationController->resume();
> }
> 
>+void Document::callRequestAnimationFrameCallbacks()
>+{
>+    if (m_scriptedAnimationController)
>+        m_scriptedAnimationController->callRequestAnimationFrameCallbacks(domWindow()->nowTimestamp());
>+}
>+
> void Document::windowScreenDidChange(PlatformDisplayID displayID)
> {
> #if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
>Index: Source/WebCore/dom/Document.h
>===================================================================
>--- Source/WebCore/dom/Document.h	(revision 241266)
>+++ Source/WebCore/dom/Document.h	(working copy)
>@@ -1067,7 +1067,9 @@ public:
>     ScriptedAnimationController* scriptedAnimationController() { return m_scriptedAnimationController.get(); }
>     void suspendScriptedAnimationControllerCallbacks();
>     void resumeScriptedAnimationControllerCallbacks();
>-    
>+
>+    void callRequestAnimationFrameCallbacks();
>+
>     void windowScreenDidChange(PlatformDisplayID);
> 
>     void finishedParsing();
>Index: Source/WebCore/dom/ScriptedAnimationController.cpp
>===================================================================
>--- Source/WebCore/dom/ScriptedAnimationController.cpp	(revision 241266)
>+++ Source/WebCore/dom/ScriptedAnimationController.cpp	(working copy)
>@@ -189,7 +189,7 @@ void ScriptedAnimationController::cancel
>     }
> }
> 
>-void ScriptedAnimationController::serviceScriptedAnimations(double timestamp)
>+void ScriptedAnimationController::callRequestAnimationFrameCallbacks(double timestamp)
> {
>     if (!m_callbacks.size() || m_suspendCount || !requestAnimationFrameEnabled())
>         return;
>@@ -262,8 +262,10 @@ void ScriptedAnimationController::schedu
> 
> #if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
>     if (!m_isUsingTimer && !isThrottled()) {
>-        if (m_document->animationScheduler().scheduleScriptedAnimationResolution())
>+        if (auto* page = this->page()) {
>+            page->renderScheduler().scheduleRender();
>             return;
>+        }
> 
>         m_isUsingTimer = true;
>     }
>@@ -292,14 +294,14 @@ void ScriptedAnimationController::schedu
> void ScriptedAnimationController::animationTimerFired()
> {
>     m_lastAnimationFrameTimestamp = m_document->domWindow()->nowTimestamp();
>-    serviceScriptedAnimations(m_lastAnimationFrameTimestamp);
>+    callRequestAnimationFrameCallbacks(m_lastAnimationFrameTimestamp);
> }
> 
> #if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
> void ScriptedAnimationController::documentAnimationSchedulerDidFire()
> {
>     // We obtain the time from the animation scheduler so that we use the same timestamp as the DocumentTimeline.
>-    serviceScriptedAnimations(m_document->animationScheduler().lastTimestamp().seconds());
>+    callRequestAnimationFrameCallbacks(m_document->animationScheduler().lastTimestamp().seconds());
> }
> #endif
> 
>Index: Source/WebCore/dom/ScriptedAnimationController.h
>===================================================================
>--- Source/WebCore/dom/ScriptedAnimationController.h	(revision 241266)
>+++ Source/WebCore/dom/ScriptedAnimationController.h	(working copy)
>@@ -52,7 +52,7 @@ public:
> 
>     CallbackId registerCallback(Ref<RequestAnimationFrameCallback>&&);
>     void cancelCallback(CallbackId);
>-    void serviceScriptedAnimations(double timestamp);
>+    void callRequestAnimationFrameCallbacks(double timestamp);
> 
>     void suspend();
>     void resume();
>Index: Source/WebCore/page/FrameTree.cpp
>===================================================================
>--- Source/WebCore/page/FrameTree.cpp	(revision 241266)
>+++ Source/WebCore/page/FrameTree.cpp	(working copy)
>@@ -23,6 +23,7 @@
> 
> #include "Document.h"
> #include "Frame.h"
>+#include "FrameLoader.h"
> #include "FrameView.h"
> #include "HTMLFrameOwnerElement.h"
> #include "Page.h"
>Index: Source/WebCore/page/Page.cpp
>===================================================================
>--- Source/WebCore/page/Page.cpp	(revision 241266)
>+++ Source/WebCore/page/Page.cpp	(working copy)
>@@ -1112,13 +1112,6 @@ void Page::didFinishLoad()
>         m_performanceMonitor->didFinishLoad();
> }
> 
>-void Page::willDisplayPage()
>-{
>-#if ENABLE(INTERSECTION_OBSERVER)
>-    updateIntersectionObservations();
>-#endif
>-}
>-
> bool Page::isOnlyNonUtilityPage() const
> {
>     return !isUtilityPage() && nonUtilityPageCount == 1;
>@@ -1260,6 +1253,18 @@ void Page::removeActivityStateChangeObse
>     m_activityStateChangeObservers.remove(&observer);
> }
> 
>+void Page::processPreLayoutActions()
>+{
>+    callRequestAnimationFrameCallbacks();
>+}
>+
>+void Page::processPreRenderActions()
>+{
>+#if ENABLE(INTERSECTION_OBSERVER)
>+    updateIntersectionObservations();
>+#endif
>+}
>+
> #if ENABLE(INTERSECTION_OBSERVER)
> void Page::addDocumentNeedingIntersectionObservationUpdate(Document& document)
> {
>@@ -1286,6 +1291,14 @@ void Page::scheduleForcedIntersectionObs
> }
> #endif
> 
>+void Page::callRequestAnimationFrameCallbacks()
>+{
>+    for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {
>+        if (frame->document())
>+            frame->document()->callRequestAnimationFrameCallbacks();
>+    }
>+}
>+
> void Page::suspendScriptedAnimations()
> {
>     m_scriptedAnimationsSuspended = true;
>@@ -2815,6 +2828,13 @@ void Page::didChangeMainDocument()
> #endif
> }
> 
>+RenderScheduler& Page::renderScheduler()
>+{
>+    if (!m_renderScheduler)
>+        m_renderScheduler = RenderScheduler::create(*this);
>+    return *m_renderScheduler;
>+}
>+
> void Page::forEachDocument(const Function<void(Document&)>& functor)
> {
>     for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) {
>Index: Source/WebCore/page/Page.h
>===================================================================
>--- Source/WebCore/page/Page.h	(revision 241266)
>+++ Source/WebCore/page/Page.h	(working copy)
>@@ -32,6 +32,7 @@
> #include "Pagination.h"
> #include "RTCController.h"
> #include "Region.h"
>+#include "RenderScheduler.h"
> #include "ScrollTypes.h"
> #include "Supplementable.h"
> #include "Timer.h"
>@@ -261,6 +262,8 @@ public:
> 
>     PerformanceMonitor* performanceMonitor() { return m_performanceMonitor.get(); }
> 
>+    RenderScheduler& renderScheduler();
>+
>     ValidationMessageClient* validationMessageClient() const { return m_validationMessageClient.get(); }
>     void updateValidationBubbleStateIfNeeded();
> 
>@@ -333,8 +336,6 @@ public:
>     void didStartProvisionalLoad();
>     void didFinishLoad(); // Called when the load has been committed in the main frame.
> 
>-    WEBCORE_EXPORT void willDisplayPage();
>-
>     // The view scale factor is multiplied into the page scale factor by all
>     // callers of setPageScaleFactor.
>     WEBCORE_EXPORT void setViewScaleFactor(float);
>@@ -464,12 +465,17 @@ public:
>     WEBCORE_EXPORT void addActivityStateChangeObserver(ActivityStateChangeObserver&);
>     WEBCORE_EXPORT void removeActivityStateChangeObserver(ActivityStateChangeObserver&);
> 
>+    WEBCORE_EXPORT void processPreLayoutActions();
>+    WEBCORE_EXPORT void processPreRenderActions();
>+
> #if ENABLE(INTERSECTION_OBSERVER)
>     void addDocumentNeedingIntersectionObservationUpdate(Document&);
>     void scheduleForcedIntersectionObservationUpdate(Document&);
>     void updateIntersectionObservations();
> #endif
> 
>+    void callRequestAnimationFrameCallbacks();
>+
>     WEBCORE_EXPORT void suspendScriptedAnimations();
>     WEBCORE_EXPORT void resumeScriptedAnimations();
>     bool scriptedAnimationsSuspended() const { return m_scriptedAnimationsSuspended; }
>@@ -860,6 +866,8 @@ private:
>     int m_headerHeight { 0 };
>     int m_footerHeight { 0 };
> 
>+    std::unique_ptr<RenderScheduler> m_renderScheduler;
>+
>     HashSet<RenderObject*> m_relevantUnpaintedRenderObjects;
>     Region m_topRelevantPaintedRegion;
>     Region m_bottomRelevantPaintedRegion;
>Index: Source/WebCore/page/PageOverlayController.cpp
>===================================================================
>--- Source/WebCore/page/PageOverlayController.cpp	(revision 241266)
>+++ Source/WebCore/page/PageOverlayController.cpp	(working copy)
>@@ -317,7 +317,7 @@ void PageOverlayController::didChangeDev
> 
> void PageOverlayController::didChangeViewExposedRect()
> {
>-    m_page.chrome().client().scheduleCompositingLayerFlush();
>+    m_page.renderScheduler().scheduleRender();
> }
> 
> void PageOverlayController::didScrollFrame(Frame& frame)
>@@ -411,7 +411,7 @@ float PageOverlayController::deviceScale
> 
> void PageOverlayController::notifyFlushRequired(const WebCore::GraphicsLayer*)
> {
>-    m_page.chrome().client().scheduleCompositingLayerFlush();
>+    m_page.renderScheduler().scheduleRender();
> }
> 
> void PageOverlayController::didChangeOverlayFrame(PageOverlay& overlay)
>Index: Source/WebCore/page/RenderScheduler.cpp
>===================================================================
>--- Source/WebCore/page/RenderScheduler.cpp	(nonexistent)
>+++ Source/WebCore/page/RenderScheduler.cpp	(working copy)
>@@ -0,0 +1,96 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
>+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
>+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+#include "RenderScheduler.h"
>+
>+#include "Chrome.h"
>+#include "ChromeClient.h"
>+#include "DisplayRefreshMonitorManager.h"
>+#include "Page.h"
>+#include <wtf/SystemTracing.h>
>+
>+namespace WebCore {
>+
>+RenderScheduler::RenderScheduler(Page& page)
>+    : m_page(page)
>+{
>+#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
>+    windowScreenDidChange(page.chrome().displayID());
>+#endif
>+}
>+
>+void RenderScheduler::scheduleRender()
>+{
>+    if (m_scheduled)
>+        return;
>+
>+    tracePoint(ScheduleRenderingUpdate);
>+
>+#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
>+    if (!DisplayRefreshMonitorManager::sharedManager().scheduleAnimation(*this))
>+#endif
>+        startTimer(Seconds(1.0 / 60));
>+
>+    m_scheduled = true;
>+}
>+
>+void RenderScheduler::startTimer(Seconds delay)
>+{
>+    ASSERT(!m_refreshTimer);
>+    m_refreshTimer = std::make_unique<Timer>(*this, &RenderScheduler::displayRefreshFired);
>+    m_refreshTimer->startOneShot(delay);
>+}
>+
>+void RenderScheduler::clearTimer()
>+{
>+    m_refreshTimer = nullptr;
>+}
>+
>+#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
>+void RenderScheduler::windowScreenDidChange(PlatformDisplayID displayID)
>+{
>+    DisplayRefreshMonitorManager::sharedManager().windowScreenDidChange(displayID, *this);
>+}
>+
>+RefPtr<DisplayRefreshMonitor> RenderScheduler::createDisplayRefreshMonitor(PlatformDisplayID displayID) const
>+{
>+    if (auto monitor = m_page.chrome().client().createDisplayRefreshMonitor(displayID))
>+        return monitor;
>+
>+    return DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor(displayID);
>+}
>+
>+void RenderScheduler::displayRefreshFired()
>+{
>+    tracePoint(TriggerRenderingUpdate);
>+
>+    m_page.chrome().client().scheduleCompositingLayerFlush();
>+    clearTimer();
>+    m_scheduled = false;
>+}
>+#endif
>+
>+}
>Index: Source/WebCore/page/RenderScheduler.h
>===================================================================
>--- Source/WebCore/page/RenderScheduler.h	(nonexistent)
>+++ Source/WebCore/page/RenderScheduler.h	(working copy)
>@@ -0,0 +1,68 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
>+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
>+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#include "DisplayRefreshMonitorClient.h"
>+#include <wtf/Seconds.h>
>+
>+namespace WebCore {
>+
>+class Page;
>+class Timer;
>+
>+class RenderScheduler
>+#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
>+    : public DisplayRefreshMonitorClient
>+#endif
>+{
>+    WTF_MAKE_FAST_ALLOCATED;
>+public:
>+    static std::unique_ptr<RenderScheduler> create(Page& page)
>+    {
>+        return std::make_unique<RenderScheduler>(page);
>+    }
>+
>+    RenderScheduler(Page&);
>+    void scheduleRender();
>+
>+#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
>+    void windowScreenDidChange(PlatformDisplayID);
>+#endif
>+
>+private:
>+#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
>+    RefPtr<DisplayRefreshMonitor> createDisplayRefreshMonitor(PlatformDisplayID) const final;
>+#endif
>+    void startTimer(Seconds);
>+    void clearTimer();
>+    void displayRefreshFired() final;
>+
>+    Page& m_page;
>+    std::unique_ptr<Timer> m_refreshTimer;
>+    bool m_scheduled { false };
>+};
>+
>+}
>Index: Source/WebCore/page/mac/ServicesOverlayController.mm
>===================================================================
>--- Source/WebCore/page/mac/ServicesOverlayController.mm	(revision 241266)
>+++ Source/WebCore/page/mac/ServicesOverlayController.mm	(working copy)
>@@ -121,7 +121,7 @@ void ServicesOverlayController::Highligh
>     if (!m_controller)
>         return;
> 
>-    m_controller->page().chrome().client().scheduleCompositingLayerFlush();
>+    m_controller->page().renderScheduler().scheduleRender();
> }
> 
> void ServicesOverlayController::Highlight::paintContents(const GraphicsLayer*, GraphicsContext& graphicsContext, GraphicsLayerPaintingPhase, const FloatRect&, GraphicsLayerPaintBehavior)
>Index: Source/WebCore/rendering/RenderLayerCompositor.cpp
>===================================================================
>--- Source/WebCore/rendering/RenderLayerCompositor.cpp	(revision 241266)
>+++ Source/WebCore/rendering/RenderLayerCompositor.cpp	(working copy)
>@@ -430,7 +430,7 @@ void RenderLayerCompositor::notifyFlushR
> void RenderLayerCompositor::scheduleLayerFlushNow()
> {
>     m_hasPendingLayerFlush = false;
>-    page().chrome().client().scheduleCompositingLayerFlush();
>+    page().renderScheduler().scheduleRender();
> }
> 
> void RenderLayerCompositor::scheduleLayerFlush(bool canThrottle)
>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 241266)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,23 @@
>+2019-02-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        requestAnimationFrame should execute before the next frame
>+        https://bugs.webkit.org/show_bug.cgi?id=177484
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Handle the page-level rendering actions through two phases: one before
>+        running the layout and the second is before committing the drawing.
>+
>+        * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
>+        (WebKit::RemoteLayerTreeDrawingArea::flushLayers):
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::processPreLayoutActions):
>+        (WebKit::WebPage::processPreRenderActions):
>+        (WebKit::WebPage::willDisplayPage): Deleted.
>+        * WebProcess/WebPage/WebPage.h:
>+        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
>+        (WebKit::TiledCoreAnimationDrawingArea::flushLayers):
>+
> 2019-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [WPE] Do not try to create empty egl windows
>Index: Source/WebKit/WebProcess/WebPage/WebPage.cpp
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/WebPage.cpp	(revision 241266)
>+++ Source/WebKit/WebProcess/WebPage/WebPage.cpp	(working copy)
>@@ -3569,9 +3569,14 @@ void WebPage::didFlushLayerTreeAtTime(Mo
> }
> #endif
> 
>-void WebPage::willDisplayPage()
>+void WebPage::processPreLayoutActions()
> {
>-    m_page->willDisplayPage();
>+    m_page->processPreLayoutActions();
>+}
>+
>+void WebPage::processPreRenderActions()
>+{
>+    m_page->processPreRenderActions();
> }
> 
> WebInspector* WebPage::inspector(LazyCreationPolicy behavior)
>Index: Source/WebKit/WebProcess/WebPage/WebPage.h
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/WebPage.h	(revision 241266)
>+++ Source/WebKit/WebProcess/WebPage/WebPage.h	(working copy)
>@@ -300,7 +300,8 @@ public:
>     void didFlushLayerTreeAtTime(MonotonicTime);
> #endif
> 
>-    void willDisplayPage();
>+    void processPreLayoutActions();
>+    void processPreRenderActions();
> 
>     enum class LazyCreationPolicy { UseExistingOnly, CreateIfNeeded };
> 
>Index: Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm	(revision 241266)
>+++ Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm	(working copy)
>@@ -347,8 +347,9 @@ void RemoteLayerTreeDrawingArea::flushLa
>     RemoteLayerBackingStoreCollection& backingStoreCollection = m_remoteLayerTreeContext->backingStoreCollection();
>     backingStoreCollection.willFlushLayers();
> 
>+    m_webPage.processPreLayoutActions();
>     m_webPage.layoutIfNeeded();
>-    m_webPage.willDisplayPage();
>+    m_webPage.processPreRenderActions();
> 
>     FloatRect visibleRect(FloatPoint(), m_viewSize);
>     if (m_scrolledViewExposedRect)
>Index: Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	(revision 241266)
>+++ Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	(working copy)
>@@ -59,6 +59,7 @@
> #import <pal/spi/cocoa/QuartzCoreSPI.h>
> #import <wtf/MachSendRight.h>
> #import <wtf/MainThread.h>
>+#import <wtf/SystemTracing.h>
> 
> #if ENABLE(ASYNC_SCROLLING)
> #import <WebCore/AsyncScrollingCoordinator.h>
>@@ -459,12 +460,15 @@ void TiledCoreAnimationDrawingArea::flus
>     if (layerTreeStateIsFrozen())
>         return;
> 
>+    TraceScope traceScope(RenderingUpdateStart, RenderingUpdateEnd);
>+
>     @autoreleasepool {
>         scaleViewToFitDocumentIfNeeded();
> 
>+        m_webPage.processPreLayoutActions();
>         m_webPage.layoutIfNeeded();
>         m_webPage.flushPendingEditorStateUpdate();
>-        m_webPage.willDisplayPage();
>+        m_webPage.processPreRenderActions();
> 
>         updateIntrinsicContentSizeIfNeeded();
> 
>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 241281)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-02-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        requestAnimationFrame should execute before the next frame
>+        https://bugs.webkit.org/show_bug.cgi?id=177484
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Tracing/SystemTracePoints.plist:
>+
> 2019-02-11  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r241272 and r241276.
>Index: Tools/Tracing/SystemTracePoints.plist
>===================================================================
>--- Tools/Tracing/SystemTracePoints.plist	(revision 241266)
>+++ Tools/Tracing/SystemTracePoints.plist	(working copy)
>@@ -202,10 +202,44 @@
>                  <key>Component</key>
>                  <string>47</string>
>                  <key>Code</key>
>+                 <string>5025</string>
>+             </dict>
>+
>+
>+             <dict>
>+                 <key>Name</key>
>+                 <string>Schedule display refresh</string>
>+                 <key>Type</key>
>+                 <string>Impulse</string>
>+                 <key>Component</key>
>+                 <string>47</string>
>+                 <key>Code</key>
>                  <string>5026</string>
>              </dict>
>              <dict>
>                  <key>Name</key>
>+                 <string>Trigger display refresh</string>
>+                 <key>Type</key>
>+                 <string>Impulse</string>
>+                 <key>Component</key>
>+                 <string>47</string>
>+                 <key>Code</key>
>+                 <string>5027</string>
>+             </dict>
>+             <dict>
>+                 <key>Name</key>
>+                 <string>Update rendering</string>
>+                 <key>Type</key>
>+                 <string>Interval</string>
>+                 <key>Component</key>
>+                 <string>47</string>
>+                 <key>CodeBegin</key>
>+                 <string>5028</string>
>+                 <key>CodeEnd</key>
>+                 <string>5029</string>
>+             </dict>
>+             <dict>
>+                 <key>Name</key>
>                  <string>Paint WebHTMLView</string>
>                  <key>Type</key>
>                  <string>Interval</string>

Actions: View | Formatted Diff | Diff

Attachments on bug 177484: 356578 | 361620 | 361621 | 361622 | 361623 | 361718 | 361727 | 361743 | 361749 | 361750 | 361752 | 361756 | 361760 | 361764 | 361769 | 361775 | 361776 | 361779 | 361783 | 361947 | 361963 | 361970 | 361973 | 361974 | 362845 | 362847 | 362848 | 362849 | 362850 | 362851 | 363268 | 363274 | 363286 | 363295 | 363309 | 363313 | 363417 | 363419 | 363420 | 363831 | 363846 | 363850 | 363857 | 363862 | 363940 | 366413 | 366416 | 366417 | 366418 | 366427 | 366731 | 366736 | 366740 | 366745 | 367083 | 367091 | 367145 | 367151 | 367160 | 367186