Attachment 361693 Details for Bug 194504 – Patch

[patch] Patch

0001-Cocoa-Notify-AVSystemController-of-our-presenting-PI.patch (text/plain), 19.88 KB, created by Jer Noble on 2019-02-11 10:31:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2019-02-11 10:31:34 PST

Size: 19.88 KB

patch

obsolete

>From 2c33e1b7c1f43bf5d14016b5f17d84215b54e5a6 Mon Sep 17 00:00:00 2001
>From: Jer Noble <jer.noble@apple.com>
>Date: Mon, 11 Feb 2019 10:30:05 -0800
>Subject: [PATCH] [Cocoa] Notify AVSystemController of our presenting PID
> before registering as a Now Playing app.
> https://bugs.webkit.org/show_bug.cgi?id=194504
>
>Reviewed by NOBODY (OOPS!).
>
>Source/WebCore:
>
>This allows the MediaRemote framework to associate the WebContent process with its host application.
>
>* Modules/mediastream/UserMediaRequest.cpp:
>(WebCore::UserMediaRequest::start):
>* platform/audio/PlatformMediaSessionManager.h:
>(WebCore::PlatformMediaSessionManager::prepareToSendUserMediaPermissionRequest):
>* platform/audio/cocoa/MediaSessionManagerCocoa.h:
>* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
>(MediaSessionManagerCocoa::prepareToSendUserMediaPermissionRequest):
>(MediaSessionManagerCocoa::providePresentingApplicationPIDIfNecessary):
>(MediaSessionManagerCocoa::updateNowPlayingInfo):
>
>Source/WebCore/PAL:
>
>* PAL.xcodeproj/project.pbxproj:
>* pal/spi/ios/CelestialSPI.h: Renamed from Source/WebKit/Platform/spi/ios/CelestialSPI.h.
>
>Source/WebKit:
>
>* WebKit.xcodeproj/project.pbxproj:
>* WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
>(WebKit::WebUserMediaClient::requestUserMediaAccess):
>* WebProcess/WebPage/WebPage.cpp:
>(WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.
>* WebProcess/WebPage/WebPage.h:
>(WebKit::WebPage::userMediaPermissionRequestManager):
>* WebProcess/WebPage/ios/WebPageIOS.mm:
>(WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.
>---
> Source/WebCore/ChangeLog                           | 19 +++++++++++++++
> .../Modules/mediastream/UserMediaRequest.cpp       |  2 ++
> Source/WebCore/PAL/ChangeLog                       | 10 ++++++++
> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj   |  4 ++++
> .../PAL/pal}/spi/ios/CelestialSPI.h                |  0
> .../platform/audio/PlatformMediaSessionManager.h   |  1 +
> .../audio/cocoa/MediaSessionManagerCocoa.h         |  6 ++++-
> .../audio/cocoa/MediaSessionManagerCocoa.mm        | 27 ++++++++++++++++++++++
> Source/WebKit/ChangeLog                            | 17 ++++++++++++++
> Source/WebKit/WebKit.xcodeproj/project.pbxproj     |  2 --
> .../WebCoreSupport/WebUserMediaClient.cpp          |  1 -
> Source/WebKit/WebProcess/WebPage/WebPage.cpp       |  6 -----
> Source/WebKit/WebProcess/WebPage/WebPage.h         |  1 -
> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm | 23 ------------------
> 14 files changed, 85 insertions(+), 34 deletions(-)
> rename Source/{WebKit/Platform => WebCore/PAL/pal}/spi/ios/CelestialSPI.h (100%)
>
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1b3855bb4de..a2ee70ddbd1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-02-11  Jer Noble  <jer.noble@apple.com>
>+
>+        [Cocoa] Notify AVSystemController of our presenting PID before registering as a Now Playing app.
>+        https://bugs.webkit.org/show_bug.cgi?id=194504
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This allows the MediaRemote framework to associate the WebContent process with its host application.
>+
>+        * Modules/mediastream/UserMediaRequest.cpp:
>+        (WebCore::UserMediaRequest::start):
>+        * platform/audio/PlatformMediaSessionManager.h:
>+        (WebCore::PlatformMediaSessionManager::prepareToSendUserMediaPermissionRequest):
>+        * platform/audio/cocoa/MediaSessionManagerCocoa.h:
>+        * platform/audio/cocoa/MediaSessionManagerCocoa.mm:
>+        (MediaSessionManagerCocoa::prepareToSendUserMediaPermissionRequest):
>+        (MediaSessionManagerCocoa::providePresentingApplicationPIDIfNecessary):
>+        (MediaSessionManagerCocoa::updateNowPlayingInfo):
>+
> 2019-01-31  Jer Noble  <jer.noble@apple.com>
> 
>         [Cocoa][EME] AirPlaying a FairPlay-protected HLS stream fails to decrypt
>diff --git a/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp b/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
>index ff5db7388f2..da2628f27c5 100644
>--- a/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
>+++ b/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
>@@ -42,6 +42,7 @@
> #include "JSOverconstrainedError.h"
> #include "Logging.h"
> #include "MediaConstraints.h"
>+#include "PlatformMediaSessionManager.h"
> #include "RealtimeMediaSourceCenter.h"
> #include "SchemeRegistry.h"
> #include "Settings.h"
>@@ -209,6 +210,7 @@ void UserMediaRequest::start()
>         return;
>     }
> 
>+    PlatformMediaSessionManager::sharedManager().prepareToSendUserMediaPermissionRequest();
>     controller->requestUserMediaAccess(*this);
> }
> 
>diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog
>index 8d7d1d2138f..7b3d2e974ad 100644
>--- a/Source/WebCore/PAL/ChangeLog
>+++ b/Source/WebCore/PAL/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-02-11  Jer Noble  <jer.noble@apple.com>
>+
>+        [Cocoa] Notify AVSystemController of our presenting PID before registering as a Now Playing app.
>+        https://bugs.webkit.org/show_bug.cgi?id=194504
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * PAL.xcodeproj/project.pbxproj:
>+        * pal/spi/ios/CelestialSPI.h: Renamed from Source/WebKit/Platform/spi/ios/CelestialSPI.h.
>+
> 2019-02-07  Chris Dumez  <cdumez@apple.com>
> 
>         Mark more heap-allocated classes as fast allocated
>diff --git a/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj b/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
>index 032d0084c55..ac7a6d25bea 100644
>--- a/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
>@@ -154,6 +154,7 @@
> 		A3AB6E651F3D217F009C14B1 /* SystemSleepListenerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = A3AB6E631F3D217F009C14B1 /* SystemSleepListenerMac.mm */; };
> 		A3C66CDC1F462D6A009E6EE9 /* SessionID.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */; };
> 		A3C66CDD1F462D6A009E6EE9 /* SessionID.h in Headers */ = {isa = PBXBuildFile; fileRef = A3C66CDB1F462D6A009E6EE9 /* SessionID.h */; };
>+		CDF91113220E4EEC001EA39E /* CelestialSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CDF91112220E4EEC001EA39E /* CelestialSPI.h */; };
> 		CE5673872151A7B9002F92D7 /* IOKitSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE5673862151A7B9002F92D7 /* IOKitSPI.h */; };
> 		E5D45D122106A07400D2B738 /* NSColorWellSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = E5D45D112106A07400D2B738 /* NSColorWellSPI.h */; };
> 		E5D45D142106A18700D2B738 /* NSPopoverColorWellSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = E5D45D132106A18700D2B738 /* NSPopoverColorWellSPI.h */; };
>@@ -317,6 +318,7 @@
> 		A3C66CDA1F462D6A009E6EE9 /* SessionID.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SessionID.cpp; sourceTree = "<group>"; };
> 		A3C66CDB1F462D6A009E6EE9 /* SessionID.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SessionID.h; sourceTree = "<group>"; };
> 		C2147A4A1EFD0AA600056FA5 /* CopyPALHeaders.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = CopyPALHeaders.xcconfig; sourceTree = "<group>"; };
>+		CDF91112220E4EEC001EA39E /* CelestialSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CelestialSPI.h; sourceTree = "<group>"; };
> 		CE5673862151A7B9002F92D7 /* IOKitSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IOKitSPI.h; sourceTree = "<group>"; };
> 		E5D45D112106A07400D2B738 /* NSColorWellSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSColorWellSPI.h; sourceTree = "<group>"; };
> 		E5D45D132106A18700D2B738 /* NSPopoverColorWellSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSPopoverColorWellSPI.h; sourceTree = "<group>"; };
>@@ -427,6 +429,7 @@
> 		0C5AF90D1F43A4A4002EAC02 /* ios */ = {
> 			isa = PBXGroup;
> 			children = (
>+				CDF91112220E4EEC001EA39E /* CelestialSPI.h */,
> 				0C5AF90F1F43A4C7002EAC02 /* CoreUISPI.h */,
> 				0C5AF9101F43A4C7002EAC02 /* DataDetectorsUISPI.h */,
> 				0C5AF9111F43A4C7002EAC02 /* GraphicsServicesSPI.h */,
>@@ -730,6 +733,7 @@
> 				F442915E1FA52473002CC93E /* NSFileSizeFormatterSPI.h in Headers */,
> 				0C7785901F45130F00F4EBB6 /* NSFontSPI.h in Headers */,
> 				A10826FE1F58A433004772AC /* NSGraphicsSPI.h in Headers */,
>+				CDF91113220E4EEC001EA39E /* CelestialSPI.h in Headers */,
> 				7A3A6A8020CADB4700317AAE /* NSImageSPI.h in Headers */,
> 				0C7785911F45130F00F4EBB6 /* NSImmediateActionGestureRecognizerSPI.h in Headers */,
> 				7A1656441F97B2B900BA3CE4 /* NSKeyedArchiverSPI.h in Headers */,
>diff --git a/Source/WebKit/Platform/spi/ios/CelestialSPI.h b/Source/WebCore/PAL/pal/spi/ios/CelestialSPI.h
>similarity index 100%
>rename from Source/WebKit/Platform/spi/ios/CelestialSPI.h
>rename to Source/WebCore/PAL/pal/spi/ios/CelestialSPI.h
>diff --git a/Source/WebCore/platform/audio/PlatformMediaSessionManager.h b/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
>index 065d94fedc8..45c70520b7d 100644
>--- a/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
>+++ b/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
>@@ -64,6 +64,7 @@ public:
>     virtual double lastUpdatedNowPlayingElapsedTime() const { return NAN; }
>     virtual uint64_t lastUpdatedNowPlayingInfoUniqueIdentifier() const { return 0; }
>     virtual bool registeredAsNowPlayingApplication() const { return false; }
>+    virtual void prepareToSendUserMediaPermissionRequest() { }
> 
>     bool willIgnoreSystemInterruptions() const { return m_willIgnoreSystemInterruptions; }
>     void setWillIgnoreSystemInterruptions(bool ignore) { m_willIgnoreSystemInterruptions = ignore; }
>diff --git a/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h b/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h
>index 47c1fdfc9f8..8830e2e3659 100644
>--- a/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h
>+++ b/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h
>@@ -45,6 +45,7 @@ public:
>     double lastUpdatedNowPlayingElapsedTime() const final { return m_lastUpdatedNowPlayingElapsedTime; }
>     uint64_t lastUpdatedNowPlayingInfoUniqueIdentifier() const final { return m_lastUpdatedNowPlayingInfoUniqueIdentifier; }
>     bool registeredAsNowPlayingApplication() const final { return m_registeredAsNowPlayingApplication; }
>+    void prepareToSendUserMediaPermissionRequest() final;
> 
> protected:
>     void scheduleUpdateNowPlayingInfo() override;
>@@ -57,12 +58,15 @@ protected:
>     void clientCharacteristicsChanged(PlatformMediaSession&) override;
>     void sessionCanProduceAudioChanged(PlatformMediaSession&) override;
> 
>+    void providePresentingApplicationPIDIfNecessary();
>+
>     PlatformMediaSession* nowPlayingEligibleSession();
> 
> private:
>     bool m_nowPlayingActive { false };
>     bool m_registeredAsNowPlayingApplication { false };
>-    
>+    bool m_havePresentedApplicationPID { false };
>+
>     // For testing purposes only.
>     String m_lastUpdatedNowPlayingTitle;
>     double m_lastUpdatedNowPlayingDuration { NAN };
>diff --git a/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm b/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
>index cb3dfc77d41..86b7ca78d18 100644
>--- a/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
>+++ b/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
>@@ -34,11 +34,17 @@
> #include "Logging.h"
> #include "MediaPlayer.h"
> #include "PlatformMediaSession.h"
>+#include "RuntimeApplicationChecks.h"
>+#include <pal/spi/ios/CelestialSPI.h>
> #include <wtf/BlockObjCExceptions.h>
> #include <wtf/Function.h>
> 
> #include "MediaRemoteSoftLink.h"
> 
>+SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(Celestial)
>+SOFT_LINK_CLASS_OPTIONAL(Celestial, AVSystemController)
>+SOFT_LINK_CONSTANT_MAY_FAIL(Celestial, AVSystemController_PIDToInheritApplicationStateFrom, NSString *)
>+
> using namespace WebCore;
> 
> static const size_t kWebAudioBufferSize = 128;
>@@ -120,6 +126,11 @@ void MediaSessionManagerCocoa::beginInterruption(PlatformMediaSession::Interrupt
>     PlatformMediaSessionManager::beginInterruption(type);
> }
> 
>+void MediaSessionManagerCocoa::prepareToSendUserMediaPermissionRequest()
>+{
>+    providePresentingApplicationPIDIfNecessary();
>+}
>+
> void MediaSessionManagerCocoa::scheduleUpdateNowPlayingInfo()
> {
>     if (!m_nowPlayingUpdateTaskQueue.hasPendingTasks())
>@@ -167,6 +178,21 @@ void MediaSessionManagerCocoa::sessionCanProduceAudioChanged(PlatformMediaSessio
>     scheduleUpdateNowPlayingInfo();
> }
> 
>+void MediaSessionManagerCocoa::providePresentingApplicationPIDIfNecessary()
>+{
>+    if (m_havePresentedApplicationPID)
>+        return;
>+    m_havePresentedApplicationPID = true;
>+
>+    if (!canLoadAVSystemController_PIDToInheritApplicationStateFrom())
>+        return;
>+
>+    NSError *error = nil;
>+    [[getAVSystemControllerClass() sharedAVSystemController] setAttribute:@(presentingApplicationPID()) forKey:getAVSystemController_PIDToInheritApplicationStateFrom() error:&error];
>+    if (error)
>+        WTFLogAlways("Failed to set up PID proxying: %s", error.localizedDescription.UTF8String);
>+}
>+
> PlatformMediaSession* MediaSessionManagerCocoa::nowPlayingEligibleSession()
> {
>     if (auto element = HTMLMediaElement::bestMediaElementForShowingPlaybackControlsManager(MediaElementSession::PlaybackControlsPurpose::NowPlaying))
>@@ -216,6 +242,7 @@ void MediaSessionManagerCocoa::updateNowPlayingInfo()
> 
>     if (!m_registeredAsNowPlayingApplication) {
>         m_registeredAsNowPlayingApplication = true;
>+        providePresentingApplicationPIDIfNecessary();
>         MRMediaRemoteSetCanBeNowPlayingApplication(true);
>     }
> 
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ee5f983b7de..69e546af83a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-02-11  Jer Noble  <jer.noble@apple.com>
>+
>+        [Cocoa] Notify AVSystemController of our presenting PID before registering as a Now Playing app.
>+        https://bugs.webkit.org/show_bug.cgi?id=194504
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKit.xcodeproj/project.pbxproj:
>+        * WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
>+        (WebKit::WebUserMediaClient::requestUserMediaAccess):
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.
>+        * WebProcess/WebPage/WebPage.h:
>+        (WebKit::WebPage::userMediaPermissionRequestManager):
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.
>+
> 2019-02-08  Keith Rollin  <krollin@apple.com>
> 
>         Unreviewed build fix.
>diff --git a/Source/WebKit/WebKit.xcodeproj/project.pbxproj b/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>index 3eacefc54b1..7513157668c 100644
>--- a/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>+++ b/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>@@ -1862,7 +1862,6 @@
> 		076E884F1A13CBC6005E90FC /* APIInjectedBundlePageContextMenuClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIInjectedBundlePageContextMenuClient.h; sourceTree = "<group>"; };
> 		07A5EBB91C7BA43E00B9CA69 /* WKFrameHandleRef.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WKFrameHandleRef.cpp; sourceTree = "<group>"; };
> 		07A5EBBA1C7BA43E00B9CA69 /* WKFrameHandleRef.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKFrameHandleRef.h; sourceTree = "<group>"; };
>-		07A8F3861E64A8F900B668E8 /* CelestialSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CelestialSPI.h; sourceTree = "<group>"; };
> 		0867D6A5FE840307C02AAC07 /* AppKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = AppKit.framework; path = /System/Library/Frameworks/AppKit.framework; sourceTree = "<absolute>"; };
> 		089C1667FE841158C02AAC07 /* en */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = "<group>"; };
> 		0E97D74C200E8FF300BF6643 /* SafeBrowsingSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = SafeBrowsingSPI.h; sourceTree = "<group>"; };
>@@ -8686,7 +8685,6 @@
> 				2DB7667021B5E48A0045DDB1 /* AccessibilitySupportSPI.h */,
> 				CE1A0BCC1A48E6C60054EF74 /* AssertionServicesSPI.h */,
> 				CDA041F31ACE2105004A13EC /* BackBoardServicesSPI.h */,
>-				07A8F3861E64A8F900B668E8 /* CelestialSPI.h */,
> 				CE1A0BCD1A48E6C60054EF74 /* CorePDFSPI.h */,
> 				2D4AF0882044C3C4006C8817 /* FrontBoardServicesSPI.h */,
> 				CE1A0BCF1A48E6C60054EF74 /* ManagedConfigurationSPI.h */,
>diff --git a/Source/WebKit/WebProcess/WebCoreSupport/WebUserMediaClient.cpp b/Source/WebKit/WebProcess/WebCoreSupport/WebUserMediaClient.cpp
>index b45c1c91720..8f667fcb3df 100644
>--- a/Source/WebKit/WebProcess/WebCoreSupport/WebUserMediaClient.cpp
>+++ b/Source/WebKit/WebProcess/WebCoreSupport/WebUserMediaClient.cpp
>@@ -42,7 +42,6 @@ void WebUserMediaClient::pageDestroyed()
> 
> void WebUserMediaClient::requestUserMediaAccess(UserMediaRequest& request)
> {
>-    m_page.prepareToSendUserMediaPermissionRequest();
>     m_page.userMediaPermissionRequestManager().startUserMediaRequest(request);
> }
> 
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index de34617e40f..b3e90af63a9 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -4025,12 +4025,6 @@ void WebPage::didReceiveNotificationPermissionDecision(uint64_t notificationID,
> 
> #if ENABLE(MEDIA_STREAM)
> 
>-#if !PLATFORM(IOS_FAMILY)
>-void WebPage::prepareToSendUserMediaPermissionRequest()
>-{
>-}
>-#endif
>-
> void WebPage::userMediaAccessWasGranted(uint64_t userMediaID, WebCore::CaptureDevice&& audioDevice, WebCore::CaptureDevice&& videoDevice, String&& mediaDeviceIdentifierHashSalt)
> {
>     m_userMediaPermissionRequestManager->userMediaAccessWasGranted(userMediaID, WTFMove(audioDevice), WTFMove(videoDevice), WTFMove(mediaDeviceIdentifierHashSalt));
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.h b/Source/WebKit/WebProcess/WebPage/WebPage.h
>index 6062ad88bc9..aac3f6d6663 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.h
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.h
>@@ -584,7 +584,6 @@ public:
> 
> #if ENABLE(MEDIA_STREAM)
>     UserMediaPermissionRequestManager& userMediaPermissionRequestManager() { return m_userMediaPermissionRequestManager; }
>-    void prepareToSendUserMediaPermissionRequest();
>     void captureDevicesChanged();
> #endif
> 
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index 7eb71ae912a..4fb4c22ed33 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -122,13 +122,6 @@
> #import <wtf/cocoa/Entitlements.h>
> #import <wtf/text/TextStream.h>
> 
>-#if ENABLE(MEDIA_STREAM)
>-#import "CelestialSPI.h"
>-SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL(Celestial)
>-SOFT_LINK_CLASS_OPTIONAL(Celestial, AVSystemController)
>-SOFT_LINK_CONSTANT_MAY_FAIL(Celestial, AVSystemController_PIDToInheritApplicationStateFrom, NSString *)
>-#endif
>-
> namespace WebKit {
> using namespace WebCore;
> 
>@@ -3155,22 +3148,6 @@ bool WebPage::platformPrefersTextLegibilityBasedZoomScaling() const
> #endif
> }
> 
>-#if ENABLE(MEDIA_STREAM)
>-void WebPage::prepareToSendUserMediaPermissionRequest()
>-{
>-    static std::once_flag once;
>-    std::call_once(once, [] {
>-        if (!canLoadAVSystemController_PIDToInheritApplicationStateFrom())
>-            return;
>-
>-        NSError *error = nil;
>-        [[getAVSystemControllerClass() sharedAVSystemController] setAttribute:@(WebCore::presentingApplicationPID()) forKey:getAVSystemController_PIDToInheritApplicationStateFrom() error:&error];
>-        if (error)
>-            WTFLogAlways("Failed to set up PID proxying: %s", error.localizedDescription.UTF8String);
>-    });
>-}
>-#endif
>-
> } // namespace WebKit
> 
> #endif // PLATFORM(IOS_FAMILY)
>-- 
>2.15.1
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194504: 361692 | 361693 | 361697 | 361704