Attachment 361671 Details for Bug 194497 – Patch

[patch] Patch

wpe-empty-egl-window.diff (text/plain), 2.08 KB, created by Carlos Garcia Campos on 2019-02-11 04:08:44 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-02-11 04:08:44 PST

Size: 2.08 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 41b1e9d6e9e..aecc1504c0f 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [WPE] Do not try to create empty egl windows
>+        https://bugs.webkit.org/show_bug.cgi?id=194497
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In AcceleratedSurfaceWPE we ensure the size we pass to wpe is at least 0x0, but wl_egl_window_create() returns
>+        nullptr if 0 is passed as width or height. We should use at least 1x1 instead.
>+
>+        * WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:
>+        (WebKit::AcceleratedSurfaceWPE::initialize):
>+        (WebKit::AcceleratedSurfaceWPE::clientResize):
>+
> 2019-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [WPE] Send client host fd and library name as web process creation parameters
>diff --git a/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp b/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp
>index 9b8ccbcb5cd..530d746f984 100644
>--- a/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp
>@@ -66,7 +66,7 @@ void AcceleratedSurfaceWPE::initialize()
>     };
>     wpe_renderer_backend_egl_target_set_client(m_backend, &s_client, this);
>     wpe_renderer_backend_egl_target_initialize(m_backend, downcast<PlatformDisplayLibWPE>(PlatformDisplay::sharedDisplay()).backend(),
>-        std::max(0, m_size.width()), std::max(0, m_size.height()));
>+        std::max(1, m_size.width()), std::max(1, m_size.height()));
> }
> 
> void AcceleratedSurfaceWPE::finalize()
>@@ -94,7 +94,7 @@ uint64_t AcceleratedSurfaceWPE::surfaceID() const
> void AcceleratedSurfaceWPE::clientResize(const IntSize& size)
> {
>     ASSERT(m_backend);
>-    wpe_renderer_backend_egl_target_resize(m_backend, std::max(0, m_size.width()), std::max(0, m_size.height()));
>+    wpe_renderer_backend_egl_target_resize(m_backend, std::max(1, m_size.width()), std::max(1, m_size.height()));
> }
> 
> void AcceleratedSurfaceWPE::willRenderFrame()

Flags:

zan: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194497: 361671