Attachment 361670 Details for Bug 194496 – Patch

[patch] Patch

bug-194496-20190211200904.patch (text/plain), 1.19 KB, created by Takashi Komori on 2019-02-11 03:11:57 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Takashi Komori

Created: 2019-02-11 03:11:57 PST

Size: 1.19 KB

patch

obsolete

>Subversion Revision: 241201
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 65f74dfeaae7a472234fa7e1b3c21cc410129eda..a98800aec3085834a6ffab11f6eaa0b789b35af9 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
>+
>+        [WinCairo][MiniBrowser] Basic authentication always fails.
>+        https://bugs.webkit.org/show_bug.cgi?id=194496
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * MiniBrowser/win/DialogHelper.h:
>+        (Dialog::getText):
>+
> 2019-02-08  Beth Dakin  <bdakin@apple.com>
> 
>         Add afterScreenUpdates to WKSnapshotConfiguration
>diff --git a/Tools/MiniBrowser/win/DialogHelper.h b/Tools/MiniBrowser/win/DialogHelper.h
>index 093df4727b7a162253e512b62d9a8b163be00db7..6590fe00255841fa93a0fe7c6bffbc0dc13fd2d0 100644
>--- a/Tools/MiniBrowser/win/DialogHelper.h
>+++ b/Tools/MiniBrowser/win/DialogHelper.h
>@@ -106,7 +106,7 @@ protected:
>     {
>         auto length = getTextLength(itemId);
>         std::vector<TCHAR> buffer(length + 1, 0);
>-        GetWindowText(item(itemId), buffer.data(), length);
>+        GetWindowText(item(itemId), buffer.data(), length + 1);
>         return std::wstring { buffer.data() };
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194496: 361670