WebKit Bugzilla
Attachment 361605 Details for
Bug 194472
: [GTK] Fix typo in the newly added API
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-194472-20190209153023.patch (text/plain), 2.94 KB, created by
Alice Mikhaylenko
on 2019-02-09 02:30:25 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alice Mikhaylenko
Created:
2019-02-09 02:30:25 PST
Size:
2.94 KB
patch
obsolete
>Subversion Revision: 241239 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 302c8e280042af11aaf9165e67dd134ede49f408..ac269e36930a99ba18028abb60b1348f3254bb5f 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,16 @@ >+2019-02-09 Alexander Mikhaylenko <exalm7659@gmail.com> >+ >+ [GTK] Fix typo in the newly added API >+ https://bugs.webkit.org/show_bug.cgi?id=194472 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fix a typo: enableed -> enabled. >+ >+ * UIProcess/API/glib/WebKitSettings.cpp: >+ (webkit_settings_set_enable_back_forward_navigation_gestures): >+ * UIProcess/API/gtk/WebKitSettings.h: >+ > 2019-02-08 Alex Christensen <achristensen@webkit.org> > > Speculative fix for Mojave API test after r241223 >diff --git a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp >index a840651c6daa81c1b5fa6bed5e03319020295ec4..a7570947bc500ecaeedbe36764550edc1554d542 100644 >--- a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp >+++ b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp >@@ -3557,21 +3557,21 @@ gboolean webkit_settings_get_enable_back_forward_navigation_gestures(WebKitSetti > /** > * webkit_settings_set_enable_back_forward_navigation_gestures: > * @settings: a #WebKitSettings >- * @enableed: value to be set >+ * @enabled: value to be set > * > * Set the #WebKitSettings:enable-back-forward-navigation-gestures property. > * > * Since: 2.24 > */ >-void webkit_settings_set_enable_back_forward_navigation_gestures(WebKitSettings* settings, gboolean enableed) >+void webkit_settings_set_enable_back_forward_navigation_gestures(WebKitSettings* settings, gboolean enabled) > { > g_return_if_fail(WEBKIT_IS_SETTINGS(settings)); > > WebKitSettingsPrivate* priv = settings->priv; >- if (priv->enableBackForwardNavigationGestures == enableed) >+ if (priv->enableBackForwardNavigationGestures == enabled) > return; > >- priv->enableBackForwardNavigationGestures = enableed; >+ priv->enableBackForwardNavigationGestures = enabled; > g_object_notify(G_OBJECT(settings), "enable-back-forward-navigation-gestures"); > } > >diff --git a/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h b/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h >index ff203373d8dc1e086587e4067d7ce4f2013daf5a..42092ada579fcebf99d134e067a47e3440448ea9 100644 >--- a/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h >+++ b/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h >@@ -477,7 +477,7 @@ webkit_settings_get_enable_back_forward_navigation_gestures (WebKitSettings * > > WEBKIT_API void > webkit_settings_set_enable_back_forward_navigation_gestures (WebKitSettings *settings, >- gboolean enableed); >+ gboolean enabled); > > WEBKIT_API guint32 > webkit_settings_font_size_to_points (guint32 pixels);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
mcatanzaro
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194472
: 361605