Attachment 361598 Details for Bug 194471 – Patch

[patch] Patch

bug-194471-20190208225806.patch (text/plain), 1.74 KB, created by Yusuke Suzuki on 2019-02-08 22:58:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-02-08 22:58:07 PST

Size: 1.74 KB

patch

obsolete

>Subversion Revision: 241233
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index e014af22e574e054359497fd02191a9d713ea56b..f638858a5f5dcacc3830b326883480e9d3683b34 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        [JSC] CachedTypes should use jsString instead of JSString::create
>+        https://bugs.webkit.org/show_bug.cgi?id=194471
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use jsString() here because JSString::create is a bit low-level API and it requires some invariant like "length is not zero".
>+
>+        * runtime/CachedTypes.cpp:
>+        (JSC::CachedJSValue::decode const):
>+
> 2019-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         [JSC] String.fromCharCode's slow path always generates 16bit string
>diff --git a/Source/JavaScriptCore/runtime/CachedTypes.cpp b/Source/JavaScriptCore/runtime/CachedTypes.cpp
>index 4358171e6c33f5dbaea05ec3cfebd1e5c64395d1..f6ffee4990c19c0ffa52bfb423ef37946761df43 100644
>--- a/Source/JavaScriptCore/runtime/CachedTypes.cpp
>+++ b/Source/JavaScriptCore/runtime/CachedTypes.cpp
>@@ -1112,8 +1112,8 @@ class CachedJSValue : public VariableLengthObject<WriteBarrier<Unknown>> {
>             v = this->buffer<CachedSymbolTable>()->decode(decoder);
>             break;
>         case EncodedType::String: {
>-            UniquedStringImpl* impl = this->buffer<CachedUniquedStringImpl>()->decode(decoder);
>-            v = JSString::create(decoder.vm(), adoptRef(*impl));
>+            StringImpl* impl = this->buffer<CachedUniquedStringImpl>()->decode(decoder);
>+            v = jsString(&decoder.vm(), adoptRef(*impl));
>             break;
>         }
>         case EncodedType::ImmutableButterfly:

Flags:

mark.lam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194471: 361598