WebKit Bugzilla
Attachment 361549 Details for
Bug 194449
: Ensure old binaries have old snapshotting behaviors
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
for-review.txt (text/plain), 3.03 KB, created by
Beth Dakin
on 2019-02-08 15:53:34 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Beth Dakin
Created:
2019-02-08 15:53:34 PST
Size:
3.03 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 241215) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,19 @@ >+2019-02-08 Beth Dakin <bdakin@apple.com> >+ >+ Ensure old binaries have old snapshotting behaviors >+ https://bugs.webkit.org/show_bug.cgi?id=194449 >+ -and corresponding- >+ rdar://problem/47931954 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Make sure that a nil configuration behaves the same way that it used to on apps >+ that were linked before FirstWithSnapshotAfterScreenUpdates >+ >+ * UIProcess/API/Cocoa/WKWebView.mm: >+ (-[WKWebView takeSnapshotWithConfiguration:completionHandler:]): >+ * UIProcess/Cocoa/VersionChecks.h: >+ > 2019-02-08 Truitt Savell <tsavell@apple.com> > > Unreviewed, rolling out r241197. >Index: Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm >=================================================================== >--- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (revision 241199) >+++ Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (working copy) >@@ -1185,7 +1185,7 @@ - (void)takeSnapshotWithConfiguration:(W > }]; > }; > >- if (snapshotConfiguration && !snapshotConfiguration.afterScreenUpdates) { >+ if ((snapshotConfiguration && !snapshotConfiguration.afterScreenUpdates) || !linkedOnOrAfter(WebKit::SDKVersion::FirstWithSnapshotAfterScreenUpdates)) { > callSnapshotRect(); > return; > } >Index: Source/WebKit/UIProcess/Cocoa/VersionChecks.h >=================================================================== >--- Source/WebKit/UIProcess/Cocoa/VersionChecks.h (revision 241197) >+++ Source/WebKit/UIProcess/Cocoa/VersionChecks.h (working copy) >@@ -32,6 +32,8 @@ > #else > #define DYLD_IOS_VERSION_FIRST_WITH_LAZY_GESTURE_RECOGNIZER_INSTALLATION 0 > #define DYLD_IOS_VERSION_FIRST_WITH_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION 0 >+#define DYLD_IOS_VERSION_FIRST_WITH_SNAPSHOT_AFTER_SCREEN_UPDATES 0 >+#define DYLD_MACOS_VERSION_FIRST_WITH_SNAPSHOT_AFTER_SCREEN_UPDATES 0 > #endif > > namespace WebKit { >@@ -50,12 +52,14 @@ enum class SDKVersion : uint32_t { > FirstWithMainThreadReleaseAssertionInWebPageProxy = DYLD_IOS_VERSION_12_0, > FirstWithLazyGestureRecognizerInstallation = DYLD_IOS_VERSION_FIRST_WITH_LAZY_GESTURE_RECOGNIZER_INSTALLATION, > FirstWithProcessSwapOnCrossSiteNavigation = DYLD_IOS_VERSION_FIRST_WITH_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION, >+ FirstWithSnapshotAfterScreenUpdates = DYLD_IOS_VERSION_FIRST_WITH_SNAPSHOT_AFTER_SCREEN_UPDATES, > #elif PLATFORM(MAC) > FirstWithNetworkCache = DYLD_MACOSX_VERSION_10_11, > FirstWithExceptionsForDuplicateCompletionHandlerCalls = DYLD_MACOSX_VERSION_10_13, > FirstWithDropToNavigateDisallowedByDefault = DYLD_MACOSX_VERSION_10_13, > FirstWithExpiredOnlyReloadBehavior = DYLD_MACOSX_VERSION_10_13, > FirstWithMainThreadReleaseAssertionInWebPageProxy = DYLD_MACOSX_VERSION_10_14, >+ FirstWithSnapshotAfterScreenUpdates = DYLD_MACOS_VERSION_FIRST_WITH_SNAPSHOT_AFTER_SCREEN_UPDATES, > #endif > }; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
darin
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 194449
: 361549