Attachment 361546 Details for Bug 194460 – Patch

[patch] Patch

bug-194460-20190208154622.patch (text/plain), 1.71 KB, created by Robin Morisset on 2019-02-08 15:46:22 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Morisset

Created: 2019-02-08 15:46:22 PST

Size: 1.71 KB

patch

obsolete

>Subversion Revision: 241209
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 037dbf58915fa2e107fef866195f2cfbb21579e4..b2e321c459a7da5df21cbab89f6a9f82f43e7239 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-02-08  Robin Morisset  <rmorisset@apple.com>
>+
>+        B3LowerMacros wrongly sets m_changed to true in the case of AtomicWeakCAS on x86
>+        https://bugs.webkit.org/show_bug.cgi?id=194460
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Trivial fix, should already be covered by testAtomicWeakCAS in testb3.cpp.
>+
>+        * b3/B3LowerMacros.cpp:
>+
> 2019-02-08  Robin Morisset  <rmorisset@apple.com>
> 
>         Make B3Value::returnsBool() more precise
>diff --git a/Source/JavaScriptCore/b3/B3LowerMacros.cpp b/Source/JavaScriptCore/b3/B3LowerMacros.cpp
>index d4c755a2b9eacd5110fee4586f3419d51469c7ba..abc5653ea156fe4f3841b9fe85c823a3fc81af93 100644
>--- a/Source/JavaScriptCore/b3/B3LowerMacros.cpp
>+++ b/Source/JavaScriptCore/b3/B3LowerMacros.cpp
>@@ -230,6 +230,7 @@ private:
>                         m_insertionSet.insertIntConstant(m_index, expectedValue, mask(width)));
>                     
>                     atomic->child(0) = maskedExpectedValue;
>+                    m_changed = true;
>                 }
>                 
>                 if (atomic->opcode() == AtomicStrongCAS) {
>@@ -238,9 +239,9 @@ private:
>                         m_insertionSet.insertClone(m_index, atomic));
>                     
>                     atomic->replaceWithIdentity(newValue);
>+                    m_changed = true;
>                 }
>-                
>-                m_changed = true;
>+
>                 break;
>             }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194460: 361546