Attachment 361539 Details for Bug 194454 – Patch

[patch] Patch

bug-194454-20190208155306.patch (text/plain), 3.77 KB, created by Devin Rousso on 2019-02-08 14:53:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-02-08 14:53:07 PST

Size: 3.77 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index aae175a9202312dc91c19f13a4d02b9ae8f50358..ffdb62365c5b55c0a617b4288059187caebb2396 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-02-08  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Audit: show keyboard shortcut in export tooltip
>+        https://bugs.webkit.org/show_bug.cgi?id=194454
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/AuditTestContentView.js:
>+        (WI.AuditTestContentView):
>+        (WI.AuditTestContentView.prototype.get saveData):
>+        (WI.AuditTestContentView.prototype._exportResult): Added.
>+        (WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked):
>+        (WI.AuditTestContentView.prototype._exportAudit): Deleted.
>+
>+        * Localizations/en.lproj/localizedStrings.js:
>+
> 2019-02-08  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: close unbalanced quotes and parenthesis when editing values
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index d8c79558caadaefbeb25f954bdbfb8499d5091ad..88d3ce1ea9c28eb746c386312ad91763ef3399c2 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -422,6 +422,7 @@ localizedStrings["Export HAR"] = "Export HAR";
> localizedStrings["Export Result"] = "Export Result";
> localizedStrings["Export Test"] = "Export Test";
> localizedStrings["Export recording (%s)"] = "Export recording (%s)";
>+localizedStrings["Export result (%s)"] = "Export result (%s)";
> localizedStrings["Expression"] = "Expression";
> localizedStrings["Extension Scripts"] = "Extension Scripts";
> localizedStrings["Extensions"] = "Extensions";
>diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js b/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js
>index 840ae3bcaca0f8ee5e6df02266e41377c50f6d8d..646d692d91afc919666a898d3500666e5a29d47a 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js
>@@ -34,6 +34,7 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView
>         this.element.classList.add("audit-test");
> 
>         this._exportButtonNavigationItem = new WI.ButtonNavigationItem("audit-export", WI.UIString("Export"), "Images/Export.svg", 15, 15);
>+        this._exportButtonNavigationItem.tooltip = WI.UIString("Export result (%s)").format(WI.saveKeyboardShortcut.displayName);
>         this._exportButtonNavigationItem.buttonStyle = WI.ButtonNavigationItem.Style.ImageAndText;
>         this._exportButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
>         this._exportButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleExportButtonNavigationItemClicked, this);
>@@ -65,7 +66,7 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView
> 
>     get saveData()
>     {
>-        return {customSaveHandler: () => { this._exportAudit(); }};
>+        return {customSaveHandler: () => { this._exportResult(); }};
>     }
> 
>     get result()
>@@ -262,7 +263,7 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView
> 
>     // Private
> 
>-    _exportAudit()
>+    _exportResult()
>     {
>         WI.auditManager.export(this.representedObject.result);
>     }
>@@ -280,7 +281,7 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView
> 
>     _handleExportButtonNavigationItemClicked(event)
>     {
>-        this._exportAudit();
>+        this._exportResult();
>     }
> 
>     _handleTestChanged(event)

Actions: View | Formatted Diff | Diff

Attachments on bug 194454: 361539